From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41211C47254 for ; Tue, 5 May 2020 08:15:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DE642068E for ; Tue, 5 May 2020 08:15:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=web.de header.i=@web.de header.b="UqOdNS+4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728402AbgEEIPd (ORCPT ); Tue, 5 May 2020 04:15:33 -0400 Received: from mout.web.de ([217.72.192.78]:57769 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725833AbgEEIPc (ORCPT ); Tue, 5 May 2020 04:15:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1588666508; bh=xb0+yObJ8LX/ryqF56WrDSm/1zLQIxqPtNdtj7KlzLQ=; h=X-UI-Sender-Class:Cc:Subject:From:To:Date; b=UqOdNS+4km77RSRM1WoqtscWjlmjpU/whCRrTEhVHavftK4qXyDODNzucPjWN+T0C 8/s3tWW1YrJV9JqIxZW+RH+wv31RihaTBKVAaLHhPJ0nCiDmVF/hCJNfWDs3wMEMaH buUNOueAAtjVMDgbzYS09yV2KkrI9h6BtfpTo6HQ= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([78.48.132.123]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MrOhx-1ikzGt0K9v-00oX8B; Tue, 05 May 2020 10:15:08 +0200 Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Hans Verkuil , Jernej Skrabec , Mauro Carvalho Chehab , Maxime Ripard Subject: Re: [PATCH] media: sun8i: Fix an error handling path in deinterlace_runtime_resume() From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= To: Christophe Jaillet , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Message-ID: <75dd05b8-7895-e1cf-2c76-2327aa11f033@web.de> Date: Tue, 5 May 2020 10:15:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ra9Z1AZM1ohG0BJsAfpYw+Nq3NhM9qaNW9+6pJX6nXvLTpOydkY 0E9GoHt+vErz4+EFcOHtR2q45a38/z5DZ6wrk53Dv0iyymtqJI7cTecD2cyhxVL/5Fsxcw7 qjWCCGhv6XQkDJ54Fh0UQd3u0NpkBWVTl+b4+JiHzc55lF2Pn/w7nfR3n3l6XR5j0y/ud+s WDl9IdT9Th2sD9a+NYa/w== X-UI-Out-Filterresults: notjunk:1;V03:K0:SEoUJAW4u8I=:eJrDYbtggXycnYIbCBf16Z P+y1YFruoAMZBTtQITaRV7TP74W0R6XLq4t2gBOgO6F3dNkjR21ab3jtb9HKwX6aDmgDxbwVV q+/r16AH5Wucqj/7RB2VGmgZVDbFzO61UwrXL0Wjir2ACek+W/bwOHXTbOIXSHpWVbbjOjJP2 QP0mKkIopAIaHLhuroleE+A9VtQwgv+zDixbBXOFDQ4JX8J7L4Rr0i142UfvE/Kr9sKbFF6Dm xRr+TIvLAiix84TWCauT8jlKMLZndTd8cyQTIkrsBi2aF4HwuGIi7qy6QGRn2udzEhOSKnK69 +z6+/XdcwooWa/wwtYnOF3KDCqUg2v4IJv01Wu5O9icxuBzRltKVnjuPsoxnfhHe9GwZyTVd5 KpOfM1g0V/w9UqJeJ4LkYFBhcuMrBScSYWU/QCavSd2EylZdLCjM96vFd5biV3xd3yDZHWtaq amKCwTA6aUt1Yj0t6roxNb6CmvXsr6tQ1MFll+rGyULh/c7gf5wrDnhKyk6jazTzMdtVtihl+ Jb5PS3w9rFRPn3zNzeG0vHoab4VDVTDFZiJqJQU20gRR7HA65twynG4MUiY6PlJsU1/DuogJ5 VainFFj7zb5zozrJMk/4c5ssfu0/PCpAVPp45JQ0TdJx3rx9chZ4uuvi0ja8HMXo0vCNJXZLp nOviS2QlZKPJol9xpCQVdbAl1AcPsvoMJAeRhX7r/lr4YaRkJbwnviU8VykjFfJZ7Ez4GvqGk fOHgoDSqK2ST7qS1tKwV5Mmnuj5cwq4+qEDC9p2geh8rTGLu+g+oyepZSoF799Rsy23Ok1UPJ +jxH+wdSE/ukoB+C83yW8HxsaadjnK6Z5ZFZ0gLqUtvbRKoBPwPn8+gmCxDXtzoo++wjtg06E 27mI9YOB7+W5UHVAUbBYNRar+cPiqoThF05XJAUjygrf5kh4yKBkJ0cpzhUEa8m51PEDnlmDk enkBewrcQpT351gSSqSITNFDramlGNbQmPnaPQfCSJK6oVvKA3nL0SnCdzevav7LEyTYopVhu AVZqO+mIDKY6piQhtDw6zw49iHsy4/rFuxHk9CntmhUWDRzx9/f+5M29S65PK0ihOUdETpNDY 2Ytz/+j6L+k917zbaWbpH3SHK9BfRnnhyHx5ETRcU1RhD1/PCnGCWt/DV1qxQUox7jM4QrHVB o0AOBE/+CiT7BmHfWqlPyVOyjsvZ0IfVIgMThfsSjx0VE7de6BJMRh9qLiKFMTiOf12oGTRUl ACkejzQgzF8qCmDYL Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > It is spurious to call 'clk_disable_unprepare()' when > 'clk_prepare_enable()' has not been called yet. Can it be that the usage of the word =E2=80=9Csuspicious=E2=80=9D would be= more appropriate for such a change description? > Re-order the error handling path to avoid it. Would it be also helpful to explicitly mention in the commit message that you would like to move a call of the function =E2=80=9Cclk_rate_exclu= sive_put=E2=80=9D to the end of this function implementation for the correction of the desired exception handling? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Elfring Date: Tue, 05 May 2020 08:15:05 +0000 Subject: Re: [PATCH] media: sun8i: Fix an error handling path in deinterlace_runtime_resume() Message-Id: <75dd05b8-7895-e1cf-2c76-2327aa11f033@web.de> List-Id: References: <20200505075034.168296-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20200505075034.168296-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Christophe Jaillet , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Hans Verkuil , Jernej Skrabec , Mauro Carvalho Chehab , Maxime Ripard > It is spurious to call 'clk_disable_unprepare()' when > 'clk_prepare_enable()' has not been called yet. Can it be that the usage of the word “suspicious” would be more appropriate for such a change description? > Re-order the error handling path to avoid it. Would it be also helpful to explicitly mention in the commit message that you would like to move a call of the function “clk_rate_exclusive_put” to the end of this function implementation for the correction of the desired exception handling? Regards, Markus