From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1498FC4361B for ; Fri, 11 Dec 2020 04:31:41 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 6C53F23ED2 for ; Fri, 11 Dec 2020 04:31:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C53F23ED2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0A260AC9C; Fri, 11 Dec 2020 05:31:38 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 7C620AC9B for ; Fri, 11 Dec 2020 05:31:35 +0100 (CET) IronPort-SDR: vvAItlTZ1Ix3RENgTNHAwgtkV0WZyP0CAziGr1/RSnm31HS/TAHrhg9oocJvRCRVg9yKThzyR2 zimyB+XeRAOw== X-IronPort-AV: E=McAfee;i="6000,8403,9831"; a="173614441" X-IronPort-AV: E=Sophos;i="5.78,410,1599548400"; d="scan'208";a="173614441" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2020 20:31:33 -0800 IronPort-SDR: Sm22omyeoSgiMg2eYUDGxtO23WgEYQnUZIyLfHbrQxiWhkOysAXbf4+IVRt/gbNi70DC98HcVm R4yc2CPG/P3g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,410,1599548400"; d="scan'208";a="408952004" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 10 Dec 2020 20:31:32 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 10 Dec 2020 20:31:30 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX606.ccr.corp.intel.com (10.109.6.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 11 Dec 2020 12:31:29 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Fri, 11 Dec 2020 12:31:29 +0800 From: "Guo, Jia" To: "Yang, SteveX" , "dev@dpdk.org" CC: "hemant.agrawal@nxp.com" , "sachin.saxena@oss.nxp.com" , "Wang, Haiyue" , "xavier.huwei@huawei.com" , "humin29@huawei.com" , "yisen.zhuang@huawei.com" , "oulijun@huawei.com" , "Xing, Beilei" , "Wu, Jingjing" , "Yang, Qiming" , "Zhang, Qi Z" , "Xu, Rosen" , "hkalra@marvell.com" , "jerinj@marvell.com" , "ndabilpuram@marvell.com" , "kirankumark@marvell.com" , "rmody@marvell.com" , "shshaikh@marvell.com" , "andrew.rybchenko@oktetlabs.ru" , "mczekaj@marvell.com" , "wei.dai@intel.com" , "fengchunsong@huawei.com" , "lihuisong@huawei.com" , "Yigit, Ferruh" , "chenhao164@huawei.com" , "Zhang, Helin" , "Ananyev, Konstantin" , "yanglong.wu@intel.com" , "xiaolong.ye@intel.com" , "Xu, Ting" , "Li, Xiaoyun" , "Lu, Wenzhuo" , "Pei, Andy" , "Wei, Dan" , "skori@marvell.com" , "vattunuru@marvell.com" , "sony.chacko@qlogic.com" , "Richardson, Bruce" , "ivan.malov@oktetlabs.ru" , "zyta.szpak@semihalf.com" , "slawomir.rosek@semihalf.com" , "rad@semihalf.com" , "Yang, SteveX" Thread-Topic: [PATCH v1 00/12] fix rx packets dropped issue Thread-Index: AQHWzdoUueytzPGVcUqYofz18eadkKnxT/WQ Date: Fri, 11 Dec 2020 04:31:28 +0000 Message-ID: <75edbd3dde1f4756a8b2dd0eb4fffc5c@intel.com> References: <20201209031628.29572-1-stevex.yang@intel.com> In-Reply-To: <20201209031628.29572-1-stevex.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 00/12] fix rx packets dropped issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, steve What I saw is that you replace of frame size checking to mtu checking, but = you still use "18" as overhead number to configure max_rx_pkt_len? =20 uint32_t frame_size =3D mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN; dev->data->dev_conf.rxmode.max_rx_pkt_len =3D frame_size; > -----Original Message----- > From: Steve Yang > Sent: Wednesday, December 9, 2020 11:16 AM > To: dev@dpdk.org > Cc: hemant.agrawal@nxp.com; sachin.saxena@oss.nxp.com; Guo, Jia > ; Wang, Haiyue ; > xavier.huwei@huawei.com; humin29@huawei.com; > yisen.zhuang@huawei.com; oulijun@huawei.com; Xing, Beilei > ; Wu, Jingjing ; Yang, Qimi= ng > ; Zhang, Qi Z ; Xu, Rosen > ; hkalra@marvell.com; jerinj@marvell.com; > ndabilpuram@marvell.com; kirankumark@marvell.com; > rmody@marvell.com; shshaikh@marvell.com; > andrew.rybchenko@oktetlabs.ru; mczekaj@marvell.com; wei.dai@intel.com; > fengchunsong@huawei.com; lihuisong@huawei.com; Yigit, Ferruh > ; chenhao164@huawei.com; Zhang, Helin > ; Ananyev, Konstantin > ; yanglong.wu@intel.com; > xiaolong.ye@intel.com; Xu, Ting ; Li, Xiaoyun > ; Lu, Wenzhuo ; Pei, Andy > ; Wei, Dan ; skori@marvell.com; > vattunuru@marvell.com; sony.chacko@qlogic.com; Richardson, Bruce > ; ivan.malov@oktetlabs.ru; > zyta.szpak@semihalf.com; slawomir.rosek@semihalf.com; > rad@semihalf.com; Yang, SteveX > Subject: [PATCH v1 00/12] fix rx packets dropped issue >=20 > The jumbo frame used the 'RTE_ETHER_MAX_LEN' as boundary condition, > this fix will change the boundary condition with 'RTE_ETHER_MTU'. >=20 > When the MTU(1500) set, the frame type of rx packet will be different if > used different overhead, it will cause the consistency issue, and the nor= mal > packet will be dropped. Hence, using fixed value 'RTE_ETHER_MTU' > can avoid this issue. >=20 > Following scopes will be changed: > - 'rte_ethdev' > - 'app', e.g.: 'test-pmd'; > - net PMDs which support VLAN tag(s) within overhead, e.g.: i40e; >=20 > Steve Yang (12): > net/dpaa2: fix the jumbo frame flag condition for mtu set > net/e1000: fix the jumbo frame flag condition for mtu set > net/hns3: fix the jumbo frame flag condition for mtu set > net/i40e: fix the jumbo frame flag condition > net/iavf: fix the jumbo frame flag condition > net/ice: fix the jumbo frame flag condition > net/ipn3ke: fix the jumbo frame flag condition for mtu set > net/octeontx: fix the jumbo frame flag condition for mtu set > net/octeontx2: fix the jumbo frame flag condition for mtu > net/qede: fix the jumbo frame flag condition for mtu set > net/sfc: fix the jumbo frame flag condition for mtu set > net/thunderx: fix the jumbo frame flag condition for mtu set >=20 > drivers/net/dpaa2/dpaa2_ethdev.c | 2 +- > drivers/net/e1000/em_ethdev.c | 2 +- > drivers/net/e1000/igb_ethdev.c | 2 +- > drivers/net/hns3/hns3_ethdev.c | 2 +- > drivers/net/hns3/hns3_ethdev_vf.c | 2 +- > drivers/net/i40e/i40e_ethdev.c | 2 +- > drivers/net/i40e/i40e_ethdev.h | 1 + > drivers/net/i40e/i40e_ethdev_vf.c | 10 +++++----- > drivers/net/i40e/i40e_fdir.c | 2 +- > drivers/net/i40e/i40e_rxtx.c | 8 ++++---- > drivers/net/iavf/iavf.h | 1 + > drivers/net/iavf/iavf_ethdev.c | 10 +++++----- > drivers/net/ice/ice_dcf_ethdev.c | 8 ++++---- > drivers/net/ice/ice_ethdev.c | 2 +- > drivers/net/ice/ice_ethdev.h | 1 + > drivers/net/ice/ice_rxtx.c | 10 +++++----- > drivers/net/ipn3ke/ipn3ke_representor.c | 2 +- > drivers/net/octeontx/octeontx_ethdev.c | 2 +- > drivers/net/octeontx2/otx2_ethdev_ops.c | 2 +- > drivers/net/qede/qede_ethdev.c | 2 +- > drivers/net/sfc/sfc_ethdev.c | 2 +- > drivers/net/thunderx/nicvf_ethdev.c | 2 +- > 22 files changed, 40 insertions(+), 37 deletions(-) >=20 > -- > 2.17.1