From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933343AbdCaNOm (ORCPT ); Fri, 31 Mar 2017 09:14:42 -0400 Received: from lb3-smtp-cloud2.xs4all.net ([194.109.24.29]:36433 "EHLO lb3-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932927AbdCaNOj (ORCPT ); Fri, 31 Mar 2017 09:14:39 -0400 Subject: Re: [PATCH v5 3/6] documentation: media: Add documentation for new RGB and YUV bus formats To: Neil Armstrong , dri-devel@lists.freedesktop.org, laurent.pinchart+renesas@ideasonboard.com, architt@codeaurora.org, mchehab@kernel.org References: <1490864675-17336-1-git-send-email-narmstrong@baylibre.com> <1490864675-17336-4-git-send-email-narmstrong@baylibre.com> Cc: Jose.Abreu@synopsys.com, kieran.bingham@ideasonboard.com, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-media@vger.kernel.org, hans.verkuil@cisco.com, sakari.ailus@linux.intel.com From: Hans Verkuil Message-ID: <75ede5b8-ad35-c23f-2f02-c206df379357@xs4all.nl> Date: Fri, 31 Mar 2017 15:14:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1490864675-17336-4-git-send-email-narmstrong@baylibre.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/03/17 11:04, Neil Armstrong wrote: > Add documentation for added Bus Formats to describe RGB and YUV formats used > as input to the Synopsys DesignWare HDMI TX Controller. > > Signed-off-by: Neil Armstrong > --- > Documentation/media/uapi/v4l/subdev-formats.rst | 871 +++++++++++++++++++++++- > 1 file changed, 857 insertions(+), 14 deletions(-) This looks good, but the "Packed YUV Formats" documentation should be updated. Currently this says: - The number of bus samples per pixel. Pixels that are wider than the bus width must be transferred in multiple samples. Common values are 1, 1.5 (encoded as 1_5) and 2. I propose this change: - The number of bus samples per pixel. Pixels that are wider than the bus width must be transferred in multiple samples. Common values are 0.5 (encoded as 0_5; in this case two pixels are transferred per bus sample), 1, 1.5 (encoded as 1_5) and 2. With that additional change you can add my: Acked-by: Hans Verkuil Regards, Hans From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Verkuil Subject: Re: [PATCH v5 3/6] documentation: media: Add documentation for new RGB and YUV bus formats Date: Fri, 31 Mar 2017 15:14:35 +0200 Message-ID: <75ede5b8-ad35-c23f-2f02-c206df379357@xs4all.nl> References: <1490864675-17336-1-git-send-email-narmstrong@baylibre.com> <1490864675-17336-4-git-send-email-narmstrong@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from lb1-smtp-cloud2.xs4all.net (lb1-smtp-cloud2.xs4all.net [194.109.24.21]) by gabe.freedesktop.org (Postfix) with ESMTPS id CFEBC6EABC for ; Fri, 31 Mar 2017 13:14:38 +0000 (UTC) In-Reply-To: <1490864675-17336-4-git-send-email-narmstrong@baylibre.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Neil Armstrong , dri-devel@lists.freedesktop.org, laurent.pinchart+renesas@ideasonboard.com, architt@codeaurora.org, mchehab@kernel.org Cc: Jose.Abreu@synopsys.com, linux-doc@vger.kernel.org, kieran.bingham@ideasonboard.com, linux-kernel@vger.kernel.org, hans.verkuil@cisco.com, sakari.ailus@linux.intel.com, linux-amlogic@lists.infradead.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gMzAvMDMvMTcgMTE6MDQsIE5laWwgQXJtc3Ryb25nIHdyb3RlOgo+IEFkZCBkb2N1bWVudGF0 aW9uIGZvciBhZGRlZCBCdXMgRm9ybWF0cyB0byBkZXNjcmliZSBSR0IgYW5kIFlVViBmb3JtYXRz IHVzZWQKPiBhcyBpbnB1dCB0byB0aGUgU3lub3BzeXMgRGVzaWduV2FyZSBIRE1JIFRYIENvbnRy b2xsZXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogTmVpbCBBcm1zdHJvbmcgPG5hcm1zdHJvbmdAYmF5 bGlicmUuY29tPgo+IC0tLQo+ICBEb2N1bWVudGF0aW9uL21lZGlhL3VhcGkvdjRsL3N1YmRldi1m b3JtYXRzLnJzdCB8IDg3MSArKysrKysrKysrKysrKysrKysrKysrKy0KPiAgMSBmaWxlIGNoYW5n ZWQsIDg1NyBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkKClRoaXMgbG9va3MgZ29vZCwg YnV0IHRoZSAiUGFja2VkIFlVViBGb3JtYXRzIiBkb2N1bWVudGF0aW9uIHNob3VsZCBiZSB1cGRh dGVkLgoKQ3VycmVudGx5IHRoaXMgc2F5czoKCi0gIFRoZSBudW1iZXIgb2YgYnVzIHNhbXBsZXMg cGVyIHBpeGVsLiBQaXhlbHMgdGhhdCBhcmUgd2lkZXIgdGhhbiB0aGUKICAgYnVzIHdpZHRoIG11 c3QgYmUgdHJhbnNmZXJyZWQgaW4gbXVsdGlwbGUgc2FtcGxlcy4gQ29tbW9uIHZhbHVlcyBhcmUK ICAgMSwgMS41IChlbmNvZGVkIGFzIDFfNSkgYW5kIDIuCgpJIHByb3Bvc2UgdGhpcyBjaGFuZ2U6 CgotICBUaGUgbnVtYmVyIG9mIGJ1cyBzYW1wbGVzIHBlciBwaXhlbC4gUGl4ZWxzIHRoYXQgYXJl IHdpZGVyIHRoYW4gdGhlCiAgIGJ1cyB3aWR0aCBtdXN0IGJlIHRyYW5zZmVycmVkIGluIG11bHRp cGxlIHNhbXBsZXMuIENvbW1vbiB2YWx1ZXMgYXJlCiAgIDAuNSAoZW5jb2RlZCBhcyAwXzU7IGlu IHRoaXMgY2FzZSB0d28gcGl4ZWxzIGFyZSB0cmFuc2ZlcnJlZCBwZXIgYnVzCiAgIHNhbXBsZSks IDEsIDEuNSAoZW5jb2RlZCBhcyAxXzUpIGFuZCAyLgoKV2l0aCB0aGF0IGFkZGl0aW9uYWwgY2hh bmdlIHlvdSBjYW4gYWRkIG15OgoKQWNrZWQtYnk6IEhhbnMgVmVya3VpbCA8aGFucy52ZXJrdWls QGNpc2NvLmNvbT4KClJlZ2FyZHMsCgoJSGFucwpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: hverkuil@xs4all.nl (Hans Verkuil) Date: Fri, 31 Mar 2017 15:14:35 +0200 Subject: [PATCH v5 3/6] documentation: media: Add documentation for new RGB and YUV bus formats In-Reply-To: <1490864675-17336-4-git-send-email-narmstrong@baylibre.com> References: <1490864675-17336-1-git-send-email-narmstrong@baylibre.com> <1490864675-17336-4-git-send-email-narmstrong@baylibre.com> Message-ID: <75ede5b8-ad35-c23f-2f02-c206df379357@xs4all.nl> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On 30/03/17 11:04, Neil Armstrong wrote: > Add documentation for added Bus Formats to describe RGB and YUV formats used > as input to the Synopsys DesignWare HDMI TX Controller. > > Signed-off-by: Neil Armstrong > --- > Documentation/media/uapi/v4l/subdev-formats.rst | 871 +++++++++++++++++++++++- > 1 file changed, 857 insertions(+), 14 deletions(-) This looks good, but the "Packed YUV Formats" documentation should be updated. Currently this says: - The number of bus samples per pixel. Pixels that are wider than the bus width must be transferred in multiple samples. Common values are 1, 1.5 (encoded as 1_5) and 2. I propose this change: - The number of bus samples per pixel. Pixels that are wider than the bus width must be transferred in multiple samples. Common values are 0.5 (encoded as 0_5; in this case two pixels are transferred per bus sample), 1, 1.5 (encoded as 1_5) and 2. With that additional change you can add my: Acked-by: Hans Verkuil Regards, Hans