Remembered my earlier comment. If the intention is to set HARDLINK, must it go with REQ_F_LINK? And if not, is it ever valid to set them both? That's not like there is a preference, but as it affects userspace, it'd be better to state it clearly and make code to check it. On 11/12/2019 00:12, Jens Axboe wrote: > On 12/10/19 2:10 PM, Pavel Begunkov wrote: >> Apart from debug code (see comments below) io_uring part of >> the patchset looks good. > > Hah, oops! > >> Reviewed-by: Pavel Begunkov > > Thanks > -- Pavel Begunkov