From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BDBEC43331 for ; Tue, 12 Nov 2019 08:17:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 204ED2084F for ; Tue, 12 Nov 2019 08:17:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="BX3IR55p" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727264AbfKLIRZ (ORCPT ); Tue, 12 Nov 2019 03:17:25 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:34468 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725821AbfKLIRZ (ORCPT ); Tue, 12 Nov 2019 03:17:25 -0500 Received: by mail-lj1-f194.google.com with SMTP id 139so16742084ljf.1 for ; Tue, 12 Nov 2019 00:17:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1UOrfE7eL3IqcRqo+GTUG4MyEyzZRkxeXy7A5k+rq7w=; b=BX3IR55pLCl6cXu5ECToHFRRet9jbkK5ccrkybPqkm9HryzEg+Vk1y587h9AeXIVNl hfxfeum8529o7h1XtQJZ0VtiGv4f4AjFzSyvTRbO8RczB2sYykTB2nw3/elVxka7pA/v BghNo/TL0TazYty8NYdFLKhrCgy/i7EqozlAE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1UOrfE7eL3IqcRqo+GTUG4MyEyzZRkxeXy7A5k+rq7w=; b=i3PKkZD/39e8EumC7X7AtAlZwfzqNjINkwEzKcVxPhj4+hRWWgchpDuM85NSmPAQgA dGHnWR+y0Lujtmf93rrzc4Xxymc455fFcruPZcehF//y0594NCHDPPe562p/Nd5Gismh CLsW/AX/O7KMJPEDqwvkANBTeSWzML8o8z53cecqpvPQtq/bk9ndSkBAoU0amrW5hDeE UoGKF5B/2tRxoSpnhjq5QKaook9PBd4h6FVLpRe9WLNgqRn9Q8Neld1fmOjmeYIRMTdQ cXJowVZfXE2Ag0cOFcXWybAB6nhl8Y+xTmFFi+yPBwE3ugFS2/xe0tvpNRhd866Y4NNO djNg== X-Gm-Message-State: APjAAAXDu3FtC//zTO8dqc3ymKhzpX7Kg2IuqAwSTU/kBmFSsj7b20uF L9y4toqaIsuq5FQT/efpYBJMZA== X-Google-Smtp-Source: APXvYqwnzpW96b39jBou0jnSlL/HS7I564u3+KsUO4+qOnY1pdOoDbEAhAuUMgbbOG4MEk38oTo25g== X-Received: by 2002:a2e:8518:: with SMTP id j24mr8331198lji.13.1573546643476; Tue, 12 Nov 2019 00:17:23 -0800 (PST) Received: from [172.16.11.28] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id a22sm7966566ljn.58.2019.11.12.00.17.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Nov 2019 00:17:22 -0800 (PST) Subject: Re: [PATCH v4 34/47] soc: fsl: qe: change return type of cpm_muram_alloc() to s32 To: Qiang Zhao , Leo Li , Christophe Leroy Cc: "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Scott Wood References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-35-linux@rasmusvillemoes.dk> From: Rasmus Villemoes Message-ID: <75efc4ce-c6da-92c4-e3a5-5e37311b0f33@rasmusvillemoes.dk> Date: Tue, 12 Nov 2019 09:17:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/11/2019 09.01, Qiang Zhao wrote: > On Fri, Nov 8, 2019 at 21:01 Rasmus Villemoes wrote: > >> -unsigned long cpm_muram_alloc_fixed(unsigned long offset, unsigned long >> size) >> +s32 cpm_muram_alloc_fixed(unsigned long offset, unsigned long size) >> { >> - unsigned long start; >> + long start; >> unsigned long flags; >> struct genpool_data_fixed muram_pool_data_fixed; > > "start" should be s32 here too? Yes, of course. Good catch. Rasmus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 256B3C43331 for ; Tue, 12 Nov 2019 08:19:45 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 610E92084F for ; Tue, 12 Nov 2019 08:19:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="BX3IR55p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 610E92084F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47C0z06CbnzF4Tx for ; Tue, 12 Nov 2019 19:19:40 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=rasmusvillemoes.dk (client-ip=2a00:1450:4864:20::242; helo=mail-lj1-x242.google.com; envelope-from=linux@rasmusvillemoes.dk; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="BX3IR55p"; dkim-atps=neutral Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47C0wT0SDNzF5FK for ; Tue, 12 Nov 2019 19:17:26 +1100 (AEDT) Received: by mail-lj1-x242.google.com with SMTP id e9so16685642ljp.13 for ; Tue, 12 Nov 2019 00:17:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1UOrfE7eL3IqcRqo+GTUG4MyEyzZRkxeXy7A5k+rq7w=; b=BX3IR55pLCl6cXu5ECToHFRRet9jbkK5ccrkybPqkm9HryzEg+Vk1y587h9AeXIVNl hfxfeum8529o7h1XtQJZ0VtiGv4f4AjFzSyvTRbO8RczB2sYykTB2nw3/elVxka7pA/v BghNo/TL0TazYty8NYdFLKhrCgy/i7EqozlAE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1UOrfE7eL3IqcRqo+GTUG4MyEyzZRkxeXy7A5k+rq7w=; b=Ln7C+YnvsReY0dZVSHK/FvQ0Hp6j+IstqAJlyFNMrS3rIn12nQ/i9Z0tyPUPyzzvPK 6QIXKhUFDGFsqSWHNuQy9SWpvbsC2x2Higzkm/2QNi21oBfauMM3hnaYodSTiUKCWoIM J1p0vKRGlG4mNQdKknMcSBNgINs0mqZeBI2aqO033TLP8FVwYdNTRM3s157tyG8/BGdQ azCxC/yCA/kMMjTNjobm2wGrJHs0G+R1Kb/tzTp4/qQI7tmenIy8YRZ/ryh8xfWjfpOc JwP3h+BOiD/hjljvfuAAGUoi3xjToJxLmCRFjm+Wrq6JD8qXhReZGRz229j8ogGKbbPO /sZQ== X-Gm-Message-State: APjAAAUHitzH7tgMsUJSl9pohGBzP7gQsxpXSHKuMgiHZ90gef+WPtJi atdK0sA318fv15gxzaFeIb6jAw== X-Google-Smtp-Source: APXvYqwnzpW96b39jBou0jnSlL/HS7I564u3+KsUO4+qOnY1pdOoDbEAhAuUMgbbOG4MEk38oTo25g== X-Received: by 2002:a2e:8518:: with SMTP id j24mr8331198lji.13.1573546643476; Tue, 12 Nov 2019 00:17:23 -0800 (PST) Received: from [172.16.11.28] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id a22sm7966566ljn.58.2019.11.12.00.17.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Nov 2019 00:17:22 -0800 (PST) Subject: Re: [PATCH v4 34/47] soc: fsl: qe: change return type of cpm_muram_alloc() to s32 To: Qiang Zhao , Leo Li , Christophe Leroy References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-35-linux@rasmusvillemoes.dk> From: Rasmus Villemoes Message-ID: <75efc4ce-c6da-92c4-e3a5-5e37311b0f33@rasmusvillemoes.dk> Date: Tue, 12 Nov 2019 09:17:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Scott Wood , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 12/11/2019 09.01, Qiang Zhao wrote: > On Fri, Nov 8, 2019 at 21:01 Rasmus Villemoes wrote: > >> -unsigned long cpm_muram_alloc_fixed(unsigned long offset, unsigned long >> size) >> +s32 cpm_muram_alloc_fixed(unsigned long offset, unsigned long size) >> { >> - unsigned long start; >> + long start; >> unsigned long flags; >> struct genpool_data_fixed muram_pool_data_fixed; > > "start" should be s32 here too? Yes, of course. Good catch. Rasmus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC2BFC43331 for ; Tue, 12 Nov 2019 08:17:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCE852084F for ; Tue, 12 Nov 2019 08:17:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kUmiKam4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="BX3IR55p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCE852084F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bweUUZISTiLoB8J2JUOUd5Sm/j/J6P9KyX5Ekemqd3I=; b=kUmiKam4c+Q90u 2KTyHBjUO0XuDrVhGOfdQYoqcYRnqMoDH6W3Fg15Hj4BQxe4chRF82s/Lw8qV0UW+lStv0eri79xs cYxZOgXpNCZPL00UmWIDCVbGDUUWf0M4CDqHgEjRioypevizHasRlVar7M3/12BnVimC/ZZIrpRSG zYV4+EiEn/GuKH0f/26uHiHSXOmKayWZK7bnTGHsZ65gw72XTEHSy3MSDjaFpvT6V4w8LFnSp8Bfr Vf5de6hDybokKwEVEB5C4fdL6lOYInBgk/Izqb28igNQTs7DUDe8lQjzOImEAOaqr/uxCAldK9o7i QMrWoqoD1Y5nuYZALOCw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iURMf-0002O2-03; Tue, 12 Nov 2019 08:17:29 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iURMb-0002N2-R0 for linux-arm-kernel@lists.infradead.org; Tue, 12 Nov 2019 08:17:27 +0000 Received: by mail-lj1-x242.google.com with SMTP id n5so16718059ljc.9 for ; Tue, 12 Nov 2019 00:17:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1UOrfE7eL3IqcRqo+GTUG4MyEyzZRkxeXy7A5k+rq7w=; b=BX3IR55pLCl6cXu5ECToHFRRet9jbkK5ccrkybPqkm9HryzEg+Vk1y587h9AeXIVNl hfxfeum8529o7h1XtQJZ0VtiGv4f4AjFzSyvTRbO8RczB2sYykTB2nw3/elVxka7pA/v BghNo/TL0TazYty8NYdFLKhrCgy/i7EqozlAE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1UOrfE7eL3IqcRqo+GTUG4MyEyzZRkxeXy7A5k+rq7w=; b=XyA8jGyvjcykXOqPjeduV9z0G2hzC1IcsegCY55enqp/9gbTimCJrKG6vl1JHhEJo3 WQr/ryPwlOdtmmGTjBSw5buZaZCgxDX+4x5h4PZdtZQBEOpIXRJ7IOFu05WbrT60x6T8 g60spA7dEFSaZJJThZlpbEDaE3t7dwPsawq+TTsHK6hQdv4qZaiuNgCCU6esESfnZ1Um 2N8bvrY5rgn6qh5oYKsj99/BG7eUh+NcD+Q1IMPuhShh/F7/PMOcGiI45frMHgU9RID3 Rs2tbb7+3vOUUIoRuwmLiSBXb+rXdnNbfscazm/SFbsddLAvLc7pSm9mvlUm2oI7n7iV cE3A== X-Gm-Message-State: APjAAAUvLW5Y7ngfWaHWCebmYxlhdVE5QSiborDwSzybf55UopzRYkMp SMMvo3LgPEjEwbCYRdSjieCD2n1a2eOZJJ9l X-Google-Smtp-Source: APXvYqwnzpW96b39jBou0jnSlL/HS7I564u3+KsUO4+qOnY1pdOoDbEAhAuUMgbbOG4MEk38oTo25g== X-Received: by 2002:a2e:8518:: with SMTP id j24mr8331198lji.13.1573546643476; Tue, 12 Nov 2019 00:17:23 -0800 (PST) Received: from [172.16.11.28] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id a22sm7966566ljn.58.2019.11.12.00.17.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Nov 2019 00:17:22 -0800 (PST) Subject: Re: [PATCH v4 34/47] soc: fsl: qe: change return type of cpm_muram_alloc() to s32 To: Qiang Zhao , Leo Li , Christophe Leroy References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-35-linux@rasmusvillemoes.dk> From: Rasmus Villemoes Message-ID: <75efc4ce-c6da-92c4-e3a5-5e37311b0f33@rasmusvillemoes.dk> Date: Tue, 12 Nov 2019 09:17:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191112_001725_869831_47F96584 X-CRM114-Status: GOOD ( 11.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Scott Wood , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/11/2019 09.01, Qiang Zhao wrote: > On Fri, Nov 8, 2019 at 21:01 Rasmus Villemoes wrote: > >> -unsigned long cpm_muram_alloc_fixed(unsigned long offset, unsigned long >> size) >> +s32 cpm_muram_alloc_fixed(unsigned long offset, unsigned long size) >> { >> - unsigned long start; >> + long start; >> unsigned long flags; >> struct genpool_data_fixed muram_pool_data_fixed; > > "start" should be s32 here too? Yes, of course. Good catch. Rasmus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel