All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
	stefanb@linux.vnet.ibm.com, "Michael S. Tsirkin" <mst@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	Laszlo Ersek <lersek@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v12 0/6] Add support for TPM Physical Presence interface
Date: Wed, 12 Dec 2018 17:24:52 +0100	[thread overview]
Message-ID: <75f0819a-78dd-9ee2-5559-4d975412ffa3@redhat.com> (raw)
In-Reply-To: <20180910083222.8245-1-marcandre.lureau@redhat.com>

Hi Marc-André,

On 9/10/18 10:32 AM, Marc-André Lureau wrote:
> Hi,
> 
> The following patches implement the TPM Physical Presence Interface
> that allows a user to set a command via ACPI (sysfs entry in Linux)
> that, upon the next reboot, the firmware looks for and acts upon by
> sending sequences of commands to the TPM.
> 
> A dedicated memory region is added to the TPM CRB & TIS devices, at
> address/size 0xFED45000/0x400. A new "etc/tpm/config" fw_cfg entry
> holds the location for that PPI region and some version details, to
> allow for future flexibility.
> 
> With the associated edk2/ovmf firmware, the Windows HLK "PPI 1.3" test
> now runs successfully.
> 
> It is based on previous work from Stefan Berger ("[PATCH v2 0/4]
> Implement Physical Presence interface for TPM 1.2 and 2")
> 
> The edk2 support is merged upstream.

I made trivial review comments in indivial patches.
Can you respin a rebased version for further testing?

Thanks,

Phil.

      parent reply	other threads:[~2018-12-12 16:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-10  8:32 [Qemu-devel] [PATCH v12 0/6] Add support for TPM Physical Presence interface Marc-André Lureau
2018-09-10  8:32 ` [Qemu-devel] [PATCH v12 1/6] hw/i386: add pc-i440fx-3.1 & pc-q35-3.1 Marc-André Lureau
2018-09-10  8:32 ` [Qemu-devel] [PATCH v12 2/6] tpm: add a "ppi" boolean property Marc-André Lureau
2018-09-10  8:32 ` [Qemu-devel] [PATCH v12 3/6] tpm: allocate/map buffer for TPM Physical Presence interface Marc-André Lureau
2018-12-12 15:58   ` Philippe Mathieu-Daudé
2018-12-12 20:22     ` Marc-André Lureau
2018-09-10  8:32 ` [Qemu-devel] [PATCH v12 4/6] acpi: expose TPM/PPI configuration parameters to firmware via fw_cfg Marc-André Lureau
2018-12-12 16:04   ` Philippe Mathieu-Daudé
2018-12-12 19:19     ` Laszlo Ersek
2018-09-10  8:32 ` [Qemu-devel] [PATCH v12 5/6] acpi: build TPM Physical Presence interface Marc-André Lureau
2018-12-12 16:09   ` Philippe Mathieu-Daudé
2018-12-12 22:00     ` Marc-André Lureau
2018-09-10  8:32 ` [Qemu-devel] [PATCH v12 6/6] tpm: add ACPI memory clear interface Marc-André Lureau
2018-12-12 16:22   ` Philippe Mathieu-Daudé
2018-12-13 12:01     ` Igor Mammedov
2018-12-13 12:18       ` Marc-André Lureau
2018-12-13 14:06         ` Philippe Mathieu-Daudé
2018-12-13 14:30           ` Marc-André Lureau
2018-12-13 14:24         ` Igor Mammedov
2018-12-12 16:24 ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75f0819a-78dd-9ee2-5559-4d975412ffa3@redhat.com \
    --to=philmd@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=lersek@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.