From: Jacob Keller <jacob.e.keller@intel.com>
To: Shannon Nelson <shannon.nelson@amd.com>, <netdev@vger.kernel.org>,
<davem@davemloft.net>, <kuba@kernel.org>
Cc: <brett.creeley@amd.com>, <drivers@pensando.io>, <nitya.sunkad@amd.com>
Subject: Re: [PATCH v2 net] ionic: remove WARN_ON to prevent panic_on_warn
Date: Thu, 6 Jul 2023 12:55:40 -0700 [thread overview]
Message-ID: <75f89fd0-191e-0248-89d1-aa9f1bad715a@intel.com> (raw)
In-Reply-To: <20230706182006.48745-1-shannon.nelson@amd.com>
On 7/6/2023 11:20 AM, Shannon Nelson wrote:
> From: Nitya Sunkad <nitya.sunkad@amd.com>
>
> Remove unnecessary early code development check and the WARN_ON
> that it uses. The irq alloc and free paths have long been
> cleaned up and this check shouldn't have stuck around so long.
>
> Fixes: 77ceb68e29cc ("ionic: Add notifyq support")
> Signed-off-by: Nitya Sunkad <nitya.sunkad@amd.com>
> Signed-off-by: Shannon Nelson <shannon.nelson@amd.com>
> ---
> v2:
> - Remove unnecessary n_qcq->flags & IONIC_QCQ_F_INTR check from early
> development
>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> drivers/net/ethernet/pensando/ionic/ionic_lif.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> index 7c20a44e549b..612b0015dc43 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c
> @@ -475,11 +475,6 @@ static void ionic_qcqs_free(struct ionic_lif *lif)
> static void ionic_link_qcq_interrupts(struct ionic_qcq *src_qcq,
> struct ionic_qcq *n_qcq)
> {
> - if (WARN_ON(n_qcq->flags & IONIC_QCQ_F_INTR)) {
> - ionic_intr_free(n_qcq->cq.lif->ionic, n_qcq->intr.index);
> - n_qcq->flags &= ~IONIC_QCQ_F_INTR;
> - }
> -
> n_qcq->intr.vector = src_qcq->intr.vector;
> n_qcq->intr.index = src_qcq->intr.index;
> n_qcq->napi_qcq = src_qcq->napi_qcq;
next prev parent reply other threads:[~2023-07-06 19:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 18:20 [PATCH v2 net] ionic: remove WARN_ON to prevent panic_on_warn Shannon Nelson
2023-07-06 19:55 ` Jacob Keller [this message]
2023-07-07 8:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75f89fd0-191e-0248-89d1-aa9f1bad715a@intel.com \
--to=jacob.e.keller@intel.com \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nitya.sunkad@amd.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.