From: David Engraf <david.engraf@sysgo.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: gregkh@linuxfoundation.org, rafael.j.wysocki@intel.com,
hdegoede@redhat.com, aspriel@gmail.com, brgl@bgdev.pl,
heikki.krogerus@linux.intel.com, vivek.gautam@codeaurora.org,
joe@perches.com, jroedel@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] device: Fix comment for driver_data in struct device
Date: Wed, 6 Feb 2019 08:49:08 +0100 [thread overview]
Message-ID: <75fac672-f1f2-5b15-d871-308469943eb9@sysgo.com> (raw)
In-Reply-To: <20190205132339.GW9224@smile.fi.intel.com>
On 05.02.19 at 14:23, Andy Shevchenko wrote:
> On Tue, Feb 05, 2019 at 01:19:52PM +0100, David Engraf wrote:
>> dev_set_drvdata/dev_get_drvdata is used to access driver_data
>> in struct device.
>
> The original comment might be slight confusing, though we all know the concept
> of getters and setters.
Okay you're right. I was a bit confused about the syntax.
Thanks
- David
>> void *platform_data; /* Platform specific data, device
>> core doesn't touch it */
>> void *driver_data; /* Driver data, set and get with
>> - dev_set/get_drvdata */
>> + dev_set_drvdata/dev_get_drvdata */
>> struct dev_links_info links;
>> struct dev_pm_info power;
>> struct dev_pm_domain *pm_domain;
>> --
>> 2.17.1
>>
>
prev parent reply other threads:[~2019-02-06 7:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 12:19 [PATCH] device: Fix comment for driver_data in struct device David Engraf
2019-02-05 13:23 ` Andy Shevchenko
2019-02-06 7:49 ` David Engraf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75fac672-f1f2-5b15-d871-308469943eb9@sysgo.com \
--to=david.engraf@sysgo.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aspriel@gmail.com \
--cc=brgl@bgdev.pl \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=joe@perches.com \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.