From: Hannes Reinecke <hare@suse.de>
To: Xiao Ni <xni@redhat.com>
Cc: Jes Sorensen <jsorensen@fb.com>, Coly Li <colyli@suse.de>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>
Subject: Re: [PATCH] mdadm: split off shared library
Date: Tue, 14 Sep 2021 09:26:41 +0200 [thread overview]
Message-ID: <75fdd0fe-154b-f8eb-9ac3-bb948b432e39@suse.de> (raw)
In-Reply-To: <CALTww29nZV4A1BM_ShrmL1ud4YZC2YTG8q4LvW8pfhZwb=MhVQ@mail.gmail.com>
On 9/14/21 9:08 AM, Xiao Ni wrote:
> Hi Hannes
>
> Thanks for these patches. It's a good idea to make codes more clearly
> that which codes belong to which file.
> There are many efforts that move codes from mdadm.c and mdadm.h to
> specific files. Is it better to put these
> patches together? For example, the patches(6, 11, 12, 16, 19, 20, 27,
> 28) try to clean mdadm.c. Could you put
> similar patches together? And there are some rename patches too, they
> are sporadic.
>
Sure. Wasn't sure how you'd like to handle it; some prefer smaller
patches, some prefer less patches overall ...
> For patch03, the argument is name, but it uses optarg in the function
> mdadm_get_layout. Is it an error?
>
Have to check.
> By the way, are there some other users who use the library besides mdadm/mdmon?
>
Not yet, but there is a program I wrote some time ago
https://github.com/hreinecke/md_monitor.git
which currently does an 'exec' on mdadm, and error handling _that_ is a
major pain. Having a shared library will make life easier there.
And I've some projects planned which would need to leverage mdadm
functionality, so for those a mdadm library would be ideal.
> And it's good for me if you send patches directly by email to
> linux-raid mail list.
>
Sure.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer
next prev parent reply other threads:[~2021-09-14 7:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 14:35 [PATCH] mdadm: split off shared library Hannes Reinecke
2021-08-26 16:28 ` Coly Li
2021-10-01 10:44 ` Tkaczyk, Mariusz
2021-10-05 9:24 ` Paul Menzel
2021-09-14 7:08 ` Xiao Ni
2021-09-14 7:26 ` Hannes Reinecke [this message]
2021-09-14 7:56 ` Xiao Ni
2021-10-06 10:58 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75fdd0fe-154b-f8eb-9ac3-bb948b432e39@suse.de \
--to=hare@suse.de \
--cc=colyli@suse.de \
--cc=jsorensen@fb.com \
--cc=linux-raid@vger.kernel.org \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.