From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A56F8C433C1 for ; Tue, 23 Mar 2021 12:21:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2723A619B1 for ; Tue, 23 Mar 2021 12:21:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2723A619B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 92B406B0189; Tue, 23 Mar 2021 08:21:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B2436B018B; Tue, 23 Mar 2021 08:21:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 705866B018C; Tue, 23 Mar 2021 08:21:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0162.hostedemail.com [216.40.44.162]) by kanga.kvack.org (Postfix) with ESMTP id 505276B0189 for ; Tue, 23 Mar 2021 08:21:36 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 08ABA4FEC for ; Tue, 23 Mar 2021 12:21:36 +0000 (UTC) X-FDA: 77951049792.12.EC6D9C2 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf28.hostedemail.com (Postfix) with ESMTP id A9A8820001D6 for ; Tue, 23 Mar 2021 12:21:34 +0000 (UTC) Received: by mail-ed1-f51.google.com with SMTP id bf3so23228551edb.6 for ; Tue, 23 Mar 2021 05:21:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=+l1FkHneCCxWHd7Lw55HE5rWouIsqHp49qYTvqtcL2k=; b=c8HZ4UuxI4tMpK3bfOLxR2mpo2MYKjvUiQ3fDpVE+daGCpuplamrRZQkT+MrcWUDbE 5fyesazaC9swWYpVAsVh4bjZCtwWMyo/tYRDg8l+MScxBoss1amGb4MNmqBlxAzSsGPY gOG1OA3nzcmgdlOYVNV3GxkgtZojqXbIgReIqXgqpyfywJ5+hzVa7c24OFzgdgVYRkTY X8zseP4vAQZp4vxpZJollDELEll+ZMamuzK23/jJ7yRb7Ifi+XvjIer9ZwRemGYQ315T /DXnwlr8mzNHEe9AYR+J/Jv2FPEsCyxQ60Uf8yJ6Uv1DjSraOu2v18Vtd+YfcHVagmnn UdKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=+l1FkHneCCxWHd7Lw55HE5rWouIsqHp49qYTvqtcL2k=; b=koI1G86wdi0QObpUsXxyltlSfQo5Otjefvwu7gXw6iugyhpfGwNQ/+Ow+ZugAQyQLi r/7JaV+0ya/YPO9mGlAuQh63EYIIXXg6+m9POVbDwvdrB+DeGTymcOkmLmma/z7TiT17 FQmnQcRWpGZCNiCuQ0GvG7cOZfL2umezTLa6ja2tz+E3KQB5FIQq/h+124RADvHymXcG kzrDdCG3/+VFO0Bwlqx5XX9riXpS93r2hTSw32U6IJVD5Lv2a9WacE1fqzhgWDsvFJpx xolRiDEAuiACr6i1QZmGg0/azffVga9lVjYjCH06ANR900IAWbKlKkzetHAGpzDgVV1u /OmA== X-Gm-Message-State: AOAM532CXWOihH9M14i04BAhxYLKZUYFzkV0IxbUGL5/GFhfqZcVvJ9A l6UmjGiasWCmrp2HG2p0PK8= X-Google-Smtp-Source: ABdhPJzVRLqp4Hqmn/EMxIcWHlx0cmTl0G2L+0FrDyPfaGc6f7BT8Nm5ZnhhEkfP/NS62yrvo8DYwg== X-Received: by 2002:aa7:c850:: with SMTP id g16mr4274306edt.324.1616502094239; Tue, 23 Mar 2021 05:21:34 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:fdcd:4dd1:a1af:a7ec? ([2a02:908:1252:fb60:fdcd:4dd1:a1af:a7ec]) by smtp.gmail.com with ESMTPSA id p24sm12790444edt.5.2021.03.23.05.21.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Mar 2021 05:21:33 -0700 (PDT) Subject: Re: [PATCH] drm/ttm: stop warning on TT shrinker failure To: Michal Hocko Cc: Matthew Wilcox , dri-devel , Linux MM , amd-gfx list , Dave Chinner , Leo Liu References: <20210322140548.GN1719932@casper.infradead.org> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <75ff80c5-a054-d13d-85c1-0040addb45d2@gmail.com> Date: Tue, 23 Mar 2021 13:21:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Stat-Signature: ymaq4uwsn6kwsz4gszcatoq6dp7dymcm X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: A9A8820001D6 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf28; identity=mailfrom; envelope-from=""; helo=mail-ed1-f51.google.com; client-ip=209.85.208.51 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616502094-661509 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Am 23.03.21 um 13:04 schrieb Michal Hocko: > On Tue 23-03-21 12:48:58, Christian K=C3=B6nig wrote: >> Am 23.03.21 um 12:28 schrieb Daniel Vetter: >>> On Tue, Mar 23, 2021 at 08:38:33AM +0100, Michal Hocko wrote: >>>> On Mon 22-03-21 20:34:25, Christian K=C3=B6nig wrote: > [...] >>>>> My only concern is that if I could rely on memalloc_no* being used = we could >>>>> optimize this quite a bit further. >>>> Yes you can use the scope API and you will be guaranteed that _any_ >>>> allocation from the enclosed context will inherit GFP_NO* semantic. >> The question is if this is also guaranteed the other way around? >> >> In other words if somebody calls get_free_page(GFP_NOFS) are the conte= xt >> flags set as well? > gfp mask is always restricted in the page allocator. So say you have > noio scope context and call get_free_page/kmalloc(GFP_NOFS) then the > scope would restrict the allocation flags to GFP_NOIO (aka drop > __GFP_IO). For further details, have a look at current_gfp_context > and its callers. > > Does this answer your question? But what happens if you don't have noio scope and somebody calls=20 get_free_page(GFP_NOFS)? Is then the noio scope added automatically? And is it possible that the=20 shrinker gets called without noio scope even we would need it? >>>> I think this is where I don't get yet what Christian tries to do: We >>>> really shouldn't do different tricks and calling contexts between di= rect >>>> reclaim and kswapd reclaim. Otherwise very hard to track down bugs a= re >>>> pretty much guaranteed. So whether we use explicit gfp flags or the >>>> context apis, result is exactly the same. >> Ok let us recap what TTMs TT shrinker does here: >> >> 1. We got memory which is not swapable because it might be accessed by= the >> GPU at any time. >> 2. Make sure the memory is not accessed by the GPU and driver need to = grab a >> lock before they can make it accessible again. >> 3. Allocate a shmem file and copy over the not swapable pages. > This is quite tricky because the shrinker operates in the PF_MEMALLOC > context so such an allocation would be allowed to completely deplete > memory unless you explicitly mark that context as __GFP_NOMEMALLOC. Thanks, exactly that was one thing I was absolutely not sure about. And=20 yes I agree that this is really tricky. Ideally I would like to be able to trigger swapping out the shmem page I=20 allocated immediately after doing the copy. This way I would only need a single page for the whole shrink operation=20 at any given time. > Also note that if the allocation cannot succeed it will not trigger rec= laim > again because you are already called from the reclaim context. > >> 4. Free the not swapable/reclaimable pages. >> >> The pages we got from the shmem file are easily swapable to disk after= the >> copy is completed. But only if IO is not already blocked because the >> shrinker was called from an allocation restricted by GFP_NOFS or GFP_N= OIO. > Sorry for being dense here but I still do not follow the actual problem > (well, except for the above mentioned one). Is the sole point of this t= o > emulate a GFP_NO* allocation context and see how shrinker behaves? Please be as dense as you need to be :) I think Daniel and I only have a very rough understanding of the memory=20 management details here, but we need exactly that knowledge to get the=20 GPU memory management into the shape we want it to be. Thanks, Christian. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 113C9C433E0 for ; Tue, 23 Mar 2021 12:21:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1278619B1 for ; Tue, 23 Mar 2021 12:21:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1278619B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EECF06E10E; Tue, 23 Mar 2021 12:21:36 +0000 (UTC) Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by gabe.freedesktop.org (Postfix) with ESMTPS id 845FE6E059; Tue, 23 Mar 2021 12:21:35 +0000 (UTC) Received: by mail-ed1-x536.google.com with SMTP id b16so23220424eds.7; Tue, 23 Mar 2021 05:21:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=+l1FkHneCCxWHd7Lw55HE5rWouIsqHp49qYTvqtcL2k=; b=c8HZ4UuxI4tMpK3bfOLxR2mpo2MYKjvUiQ3fDpVE+daGCpuplamrRZQkT+MrcWUDbE 5fyesazaC9swWYpVAsVh4bjZCtwWMyo/tYRDg8l+MScxBoss1amGb4MNmqBlxAzSsGPY gOG1OA3nzcmgdlOYVNV3GxkgtZojqXbIgReIqXgqpyfywJ5+hzVa7c24OFzgdgVYRkTY X8zseP4vAQZp4vxpZJollDELEll+ZMamuzK23/jJ7yRb7Ifi+XvjIer9ZwRemGYQ315T /DXnwlr8mzNHEe9AYR+J/Jv2FPEsCyxQ60Uf8yJ6Uv1DjSraOu2v18Vtd+YfcHVagmnn UdKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=+l1FkHneCCxWHd7Lw55HE5rWouIsqHp49qYTvqtcL2k=; b=Bn2y193fiD5ieUrv2o9vd5/qFcFlJkQjp4vDDrTa0PB9GUHwF9grJY5YdoYOUTsaJW Y+YiX+IBujcDQTHStRNneIUcT44VbxdIDofNTz/tEUqDnrecEisYyIk8eqkEHCpfPfb9 eUtlPphBS6BrhS7vHmmu2brEbzeyRii5ws+A7T0raiBx/SCO7JaFXbJDXAh51/ur0hG0 6xEnP4ddBNb7U0PkcczDPCAp4vEvcwO5vrAFuChrXltWJyot1mi3CJoSj/GWrm04eLjI U2rbUyGIXqmngk4+HXyJCdHwMbnKPIQl9tJk1x5OPHGh8tY1OlpkyzuWh2o52BZc809q JU2A== X-Gm-Message-State: AOAM530LZjvFFYI3uMRTMn+kGHRrASmK3/55hYzNrwY40fP0h5zq0wvU R3clqD+86+5sA5k4qKmCUuE= X-Google-Smtp-Source: ABdhPJzVRLqp4Hqmn/EMxIcWHlx0cmTl0G2L+0FrDyPfaGc6f7BT8Nm5ZnhhEkfP/NS62yrvo8DYwg== X-Received: by 2002:aa7:c850:: with SMTP id g16mr4274306edt.324.1616502094239; Tue, 23 Mar 2021 05:21:34 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:fdcd:4dd1:a1af:a7ec? ([2a02:908:1252:fb60:fdcd:4dd1:a1af:a7ec]) by smtp.gmail.com with ESMTPSA id p24sm12790444edt.5.2021.03.23.05.21.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Mar 2021 05:21:33 -0700 (PDT) Subject: Re: [PATCH] drm/ttm: stop warning on TT shrinker failure To: Michal Hocko References: <20210322140548.GN1719932@casper.infradead.org> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <75ff80c5-a054-d13d-85c1-0040addb45d2@gmail.com> Date: Tue, 23 Mar 2021 13:21:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matthew Wilcox , amd-gfx list , Linux MM , dri-devel , Dave Chinner , Leo Liu Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" QW0gMjMuMDMuMjEgdW0gMTM6MDQgc2NocmllYiBNaWNoYWwgSG9ja286Cj4gT24gVHVlIDIzLTAz LTIxIDEyOjQ4OjU4LCBDaHJpc3RpYW4gS8O2bmlnIHdyb3RlOgo+PiBBbSAyMy4wMy4yMSB1bSAx MjoyOCBzY2hyaWViIERhbmllbCBWZXR0ZXI6Cj4+PiBPbiBUdWUsIE1hciAyMywgMjAyMSBhdCAw ODozODozM0FNICswMTAwLCBNaWNoYWwgSG9ja28gd3JvdGU6Cj4+Pj4gT24gTW9uIDIyLTAzLTIx IDIwOjM0OjI1LCBDaHJpc3RpYW4gS8O2bmlnIHdyb3RlOgo+IFsuLi5dCj4+Pj4+IE15IG9ubHkg Y29uY2VybiBpcyB0aGF0IGlmIEkgY291bGQgcmVseSBvbiBtZW1hbGxvY19ubyogYmVpbmcgdXNl ZCB3ZSBjb3VsZAo+Pj4+PiBvcHRpbWl6ZSB0aGlzIHF1aXRlIGEgYml0IGZ1cnRoZXIuCj4+Pj4g WWVzIHlvdSBjYW4gdXNlIHRoZSBzY29wZSBBUEkgYW5kIHlvdSB3aWxsIGJlIGd1YXJhbnRlZWQg dGhhdCBfYW55Xwo+Pj4+IGFsbG9jYXRpb24gZnJvbSB0aGUgZW5jbG9zZWQgY29udGV4dCB3aWxs IGluaGVyaXQgR0ZQX05PKiBzZW1hbnRpYy4KPj4gVGhlIHF1ZXN0aW9uIGlzIGlmIHRoaXMgaXMg YWxzbyBndWFyYW50ZWVkIHRoZSBvdGhlciB3YXkgYXJvdW5kPwo+Pgo+PiBJbiBvdGhlciB3b3Jk cyBpZiBzb21lYm9keSBjYWxscyBnZXRfZnJlZV9wYWdlKEdGUF9OT0ZTKSBhcmUgdGhlIGNvbnRl eHQKPj4gZmxhZ3Mgc2V0IGFzIHdlbGw/Cj4gZ2ZwIG1hc2sgaXMgYWx3YXlzIHJlc3RyaWN0ZWQg aW4gdGhlIHBhZ2UgYWxsb2NhdG9yLiBTbyBzYXkgeW91IGhhdmUKPiBub2lvIHNjb3BlIGNvbnRl eHQgYW5kIGNhbGwgZ2V0X2ZyZWVfcGFnZS9rbWFsbG9jKEdGUF9OT0ZTKSB0aGVuIHRoZQo+IHNj b3BlIHdvdWxkIHJlc3RyaWN0IHRoZSBhbGxvY2F0aW9uIGZsYWdzIHRvIEdGUF9OT0lPIChha2Eg ZHJvcAo+IF9fR0ZQX0lPKS4gRm9yIGZ1cnRoZXIgZGV0YWlscywgaGF2ZSBhIGxvb2sgYXQgY3Vy cmVudF9nZnBfY29udGV4dAo+IGFuZCBpdHMgY2FsbGVycy4KPgo+IERvZXMgdGhpcyBhbnN3ZXIg eW91ciBxdWVzdGlvbj8KCkJ1dCB3aGF0IGhhcHBlbnMgaWYgeW91IGRvbid0IGhhdmUgbm9pbyBz Y29wZSBhbmQgc29tZWJvZHkgY2FsbHMgCmdldF9mcmVlX3BhZ2UoR0ZQX05PRlMpPwoKSXMgdGhl biB0aGUgbm9pbyBzY29wZSBhZGRlZCBhdXRvbWF0aWNhbGx5PyBBbmQgaXMgaXQgcG9zc2libGUg dGhhdCB0aGUgCnNocmlua2VyIGdldHMgY2FsbGVkIHdpdGhvdXQgbm9pbyBzY29wZSBldmVuIHdl IHdvdWxkIG5lZWQgaXQ/Cgo+Pj4+IEkgdGhpbmsgdGhpcyBpcyB3aGVyZSBJIGRvbid0IGdldCB5 ZXQgd2hhdCBDaHJpc3RpYW4gdHJpZXMgdG8gZG86IFdlCj4+Pj4gcmVhbGx5IHNob3VsZG4ndCBk byBkaWZmZXJlbnQgdHJpY2tzIGFuZCBjYWxsaW5nIGNvbnRleHRzIGJldHdlZW4gZGlyZWN0Cj4+ Pj4gcmVjbGFpbSBhbmQga3N3YXBkIHJlY2xhaW0uIE90aGVyd2lzZSB2ZXJ5IGhhcmQgdG8gdHJh Y2sgZG93biBidWdzIGFyZQo+Pj4+IHByZXR0eSBtdWNoIGd1YXJhbnRlZWQuIFNvIHdoZXRoZXIg d2UgdXNlIGV4cGxpY2l0IGdmcCBmbGFncyBvciB0aGUKPj4+PiBjb250ZXh0IGFwaXMsIHJlc3Vs dCBpcyBleGFjdGx5IHRoZSBzYW1lLgo+PiBPayBsZXQgdXMgcmVjYXAgd2hhdCBUVE1zIFRUIHNo cmlua2VyIGRvZXMgaGVyZToKPj4KPj4gMS4gV2UgZ290IG1lbW9yeSB3aGljaCBpcyBub3Qgc3dh cGFibGUgYmVjYXVzZSBpdCBtaWdodCBiZSBhY2Nlc3NlZCBieSB0aGUKPj4gR1BVIGF0IGFueSB0 aW1lLgo+PiAyLiBNYWtlIHN1cmUgdGhlIG1lbW9yeSBpcyBub3QgYWNjZXNzZWQgYnkgdGhlIEdQ VSBhbmQgZHJpdmVyIG5lZWQgdG8gZ3JhYiBhCj4+IGxvY2sgYmVmb3JlIHRoZXkgY2FuIG1ha2Ug aXQgYWNjZXNzaWJsZSBhZ2Fpbi4KPj4gMy4gQWxsb2NhdGUgYSBzaG1lbSBmaWxlIGFuZCBjb3B5 IG92ZXIgdGhlIG5vdCBzd2FwYWJsZSBwYWdlcy4KPiBUaGlzIGlzIHF1aXRlIHRyaWNreSBiZWNh dXNlIHRoZSBzaHJpbmtlciBvcGVyYXRlcyBpbiB0aGUgUEZfTUVNQUxMT0MKPiBjb250ZXh0IHNv IHN1Y2ggYW4gYWxsb2NhdGlvbiB3b3VsZCBiZSBhbGxvd2VkIHRvIGNvbXBsZXRlbHkgZGVwbGV0 ZQo+IG1lbW9yeSB1bmxlc3MgeW91IGV4cGxpY2l0bHkgbWFyayB0aGF0IGNvbnRleHQgYXMgX19H RlBfTk9NRU1BTExPQy4KClRoYW5rcywgZXhhY3RseSB0aGF0IHdhcyBvbmUgdGhpbmcgSSB3YXMg YWJzb2x1dGVseSBub3Qgc3VyZSBhYm91dC4gQW5kIAp5ZXMgSSBhZ3JlZSB0aGF0IHRoaXMgaXMg cmVhbGx5IHRyaWNreS4KCklkZWFsbHkgSSB3b3VsZCBsaWtlIHRvIGJlIGFibGUgdG8gdHJpZ2dl ciBzd2FwcGluZyBvdXQgdGhlIHNobWVtIHBhZ2UgSSAKYWxsb2NhdGVkIGltbWVkaWF0ZWx5IGFm dGVyIGRvaW5nIHRoZSBjb3B5LgoKVGhpcyB3YXkgSSB3b3VsZCBvbmx5IG5lZWQgYSBzaW5nbGUg cGFnZSBmb3IgdGhlIHdob2xlIHNocmluayBvcGVyYXRpb24gCmF0IGFueSBnaXZlbiB0aW1lLgoK PiBBbHNvIG5vdGUgdGhhdCBpZiB0aGUgYWxsb2NhdGlvbiBjYW5ub3Qgc3VjY2VlZCBpdCB3aWxs IG5vdCB0cmlnZ2VyIHJlY2xhaW0KPiBhZ2FpbiBiZWNhdXNlIHlvdSBhcmUgYWxyZWFkeSBjYWxs ZWQgZnJvbSB0aGUgcmVjbGFpbSBjb250ZXh0Lgo+Cj4+IDQuIEZyZWUgdGhlIG5vdCBzd2FwYWJs ZS9yZWNsYWltYWJsZSBwYWdlcy4KPj4KPj4gVGhlIHBhZ2VzIHdlIGdvdCBmcm9tIHRoZSBzaG1l bSBmaWxlIGFyZSBlYXNpbHkgc3dhcGFibGUgdG8gZGlzayBhZnRlciB0aGUKPj4gY29weSBpcyBj b21wbGV0ZWQuIEJ1dCBvbmx5IGlmIElPIGlzIG5vdCBhbHJlYWR5IGJsb2NrZWQgYmVjYXVzZSB0 aGUKPj4gc2hyaW5rZXIgd2FzIGNhbGxlZCBmcm9tIGFuIGFsbG9jYXRpb24gcmVzdHJpY3RlZCBi eSBHRlBfTk9GUyBvciBHRlBfTk9JTy4KPiBTb3JyeSBmb3IgYmVpbmcgZGVuc2UgaGVyZSBidXQg SSBzdGlsbCBkbyBub3QgZm9sbG93IHRoZSBhY3R1YWwgcHJvYmxlbQo+ICh3ZWxsLCBleGNlcHQg Zm9yIHRoZSBhYm92ZSBtZW50aW9uZWQgb25lKS4gSXMgdGhlIHNvbGUgcG9pbnQgb2YgdGhpcyB0 bwo+IGVtdWxhdGUgYSBHRlBfTk8qIGFsbG9jYXRpb24gY29udGV4dCBhbmQgc2VlIGhvdyBzaHJp bmtlciBiZWhhdmVzPwoKUGxlYXNlIGJlIGFzIGRlbnNlIGFzIHlvdSBuZWVkIHRvIGJlIDopCgpJ IHRoaW5rIERhbmllbCBhbmQgSSBvbmx5IGhhdmUgYSB2ZXJ5IHJvdWdoIHVuZGVyc3RhbmRpbmcg b2YgdGhlIG1lbW9yeSAKbWFuYWdlbWVudCBkZXRhaWxzIGhlcmUsIGJ1dCB3ZSBuZWVkIGV4YWN0 bHkgdGhhdCBrbm93bGVkZ2UgdG8gZ2V0IHRoZSAKR1BVIG1lbW9yeSBtYW5hZ2VtZW50IGludG8g dGhlIHNoYXBlIHdlIHdhbnQgaXQgdG8gYmUuCgpUaGFua3MsCkNocmlzdGlhbi4KX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2678FC433DB for ; Tue, 23 Mar 2021 12:21:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C69AB619B4 for ; Tue, 23 Mar 2021 12:21:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C69AB619B4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5519B6E059; Tue, 23 Mar 2021 12:21:36 +0000 (UTC) Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by gabe.freedesktop.org (Postfix) with ESMTPS id 845FE6E059; Tue, 23 Mar 2021 12:21:35 +0000 (UTC) Received: by mail-ed1-x536.google.com with SMTP id b16so23220424eds.7; Tue, 23 Mar 2021 05:21:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=+l1FkHneCCxWHd7Lw55HE5rWouIsqHp49qYTvqtcL2k=; b=c8HZ4UuxI4tMpK3bfOLxR2mpo2MYKjvUiQ3fDpVE+daGCpuplamrRZQkT+MrcWUDbE 5fyesazaC9swWYpVAsVh4bjZCtwWMyo/tYRDg8l+MScxBoss1amGb4MNmqBlxAzSsGPY gOG1OA3nzcmgdlOYVNV3GxkgtZojqXbIgReIqXgqpyfywJ5+hzVa7c24OFzgdgVYRkTY X8zseP4vAQZp4vxpZJollDELEll+ZMamuzK23/jJ7yRb7Ifi+XvjIer9ZwRemGYQ315T /DXnwlr8mzNHEe9AYR+J/Jv2FPEsCyxQ60Uf8yJ6Uv1DjSraOu2v18Vtd+YfcHVagmnn UdKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=+l1FkHneCCxWHd7Lw55HE5rWouIsqHp49qYTvqtcL2k=; b=Bn2y193fiD5ieUrv2o9vd5/qFcFlJkQjp4vDDrTa0PB9GUHwF9grJY5YdoYOUTsaJW Y+YiX+IBujcDQTHStRNneIUcT44VbxdIDofNTz/tEUqDnrecEisYyIk8eqkEHCpfPfb9 eUtlPphBS6BrhS7vHmmu2brEbzeyRii5ws+A7T0raiBx/SCO7JaFXbJDXAh51/ur0hG0 6xEnP4ddBNb7U0PkcczDPCAp4vEvcwO5vrAFuChrXltWJyot1mi3CJoSj/GWrm04eLjI U2rbUyGIXqmngk4+HXyJCdHwMbnKPIQl9tJk1x5OPHGh8tY1OlpkyzuWh2o52BZc809q JU2A== X-Gm-Message-State: AOAM530LZjvFFYI3uMRTMn+kGHRrASmK3/55hYzNrwY40fP0h5zq0wvU R3clqD+86+5sA5k4qKmCUuE= X-Google-Smtp-Source: ABdhPJzVRLqp4Hqmn/EMxIcWHlx0cmTl0G2L+0FrDyPfaGc6f7BT8Nm5ZnhhEkfP/NS62yrvo8DYwg== X-Received: by 2002:aa7:c850:: with SMTP id g16mr4274306edt.324.1616502094239; Tue, 23 Mar 2021 05:21:34 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:fdcd:4dd1:a1af:a7ec? ([2a02:908:1252:fb60:fdcd:4dd1:a1af:a7ec]) by smtp.gmail.com with ESMTPSA id p24sm12790444edt.5.2021.03.23.05.21.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Mar 2021 05:21:33 -0700 (PDT) Subject: Re: [PATCH] drm/ttm: stop warning on TT shrinker failure To: Michal Hocko References: <20210322140548.GN1719932@casper.infradead.org> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <75ff80c5-a054-d13d-85c1-0040addb45d2@gmail.com> Date: Tue, 23 Mar 2021 13:21:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matthew Wilcox , amd-gfx list , Linux MM , dri-devel , Dave Chinner , Leo Liu Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" QW0gMjMuMDMuMjEgdW0gMTM6MDQgc2NocmllYiBNaWNoYWwgSG9ja286Cj4gT24gVHVlIDIzLTAz LTIxIDEyOjQ4OjU4LCBDaHJpc3RpYW4gS8O2bmlnIHdyb3RlOgo+PiBBbSAyMy4wMy4yMSB1bSAx MjoyOCBzY2hyaWViIERhbmllbCBWZXR0ZXI6Cj4+PiBPbiBUdWUsIE1hciAyMywgMjAyMSBhdCAw ODozODozM0FNICswMTAwLCBNaWNoYWwgSG9ja28gd3JvdGU6Cj4+Pj4gT24gTW9uIDIyLTAzLTIx IDIwOjM0OjI1LCBDaHJpc3RpYW4gS8O2bmlnIHdyb3RlOgo+IFsuLi5dCj4+Pj4+IE15IG9ubHkg Y29uY2VybiBpcyB0aGF0IGlmIEkgY291bGQgcmVseSBvbiBtZW1hbGxvY19ubyogYmVpbmcgdXNl ZCB3ZSBjb3VsZAo+Pj4+PiBvcHRpbWl6ZSB0aGlzIHF1aXRlIGEgYml0IGZ1cnRoZXIuCj4+Pj4g WWVzIHlvdSBjYW4gdXNlIHRoZSBzY29wZSBBUEkgYW5kIHlvdSB3aWxsIGJlIGd1YXJhbnRlZWQg dGhhdCBfYW55Xwo+Pj4+IGFsbG9jYXRpb24gZnJvbSB0aGUgZW5jbG9zZWQgY29udGV4dCB3aWxs IGluaGVyaXQgR0ZQX05PKiBzZW1hbnRpYy4KPj4gVGhlIHF1ZXN0aW9uIGlzIGlmIHRoaXMgaXMg YWxzbyBndWFyYW50ZWVkIHRoZSBvdGhlciB3YXkgYXJvdW5kPwo+Pgo+PiBJbiBvdGhlciB3b3Jk cyBpZiBzb21lYm9keSBjYWxscyBnZXRfZnJlZV9wYWdlKEdGUF9OT0ZTKSBhcmUgdGhlIGNvbnRl eHQKPj4gZmxhZ3Mgc2V0IGFzIHdlbGw/Cj4gZ2ZwIG1hc2sgaXMgYWx3YXlzIHJlc3RyaWN0ZWQg aW4gdGhlIHBhZ2UgYWxsb2NhdG9yLiBTbyBzYXkgeW91IGhhdmUKPiBub2lvIHNjb3BlIGNvbnRl eHQgYW5kIGNhbGwgZ2V0X2ZyZWVfcGFnZS9rbWFsbG9jKEdGUF9OT0ZTKSB0aGVuIHRoZQo+IHNj b3BlIHdvdWxkIHJlc3RyaWN0IHRoZSBhbGxvY2F0aW9uIGZsYWdzIHRvIEdGUF9OT0lPIChha2Eg ZHJvcAo+IF9fR0ZQX0lPKS4gRm9yIGZ1cnRoZXIgZGV0YWlscywgaGF2ZSBhIGxvb2sgYXQgY3Vy cmVudF9nZnBfY29udGV4dAo+IGFuZCBpdHMgY2FsbGVycy4KPgo+IERvZXMgdGhpcyBhbnN3ZXIg eW91ciBxdWVzdGlvbj8KCkJ1dCB3aGF0IGhhcHBlbnMgaWYgeW91IGRvbid0IGhhdmUgbm9pbyBz Y29wZSBhbmQgc29tZWJvZHkgY2FsbHMgCmdldF9mcmVlX3BhZ2UoR0ZQX05PRlMpPwoKSXMgdGhl biB0aGUgbm9pbyBzY29wZSBhZGRlZCBhdXRvbWF0aWNhbGx5PyBBbmQgaXMgaXQgcG9zc2libGUg dGhhdCB0aGUgCnNocmlua2VyIGdldHMgY2FsbGVkIHdpdGhvdXQgbm9pbyBzY29wZSBldmVuIHdl IHdvdWxkIG5lZWQgaXQ/Cgo+Pj4+IEkgdGhpbmsgdGhpcyBpcyB3aGVyZSBJIGRvbid0IGdldCB5 ZXQgd2hhdCBDaHJpc3RpYW4gdHJpZXMgdG8gZG86IFdlCj4+Pj4gcmVhbGx5IHNob3VsZG4ndCBk byBkaWZmZXJlbnQgdHJpY2tzIGFuZCBjYWxsaW5nIGNvbnRleHRzIGJldHdlZW4gZGlyZWN0Cj4+ Pj4gcmVjbGFpbSBhbmQga3N3YXBkIHJlY2xhaW0uIE90aGVyd2lzZSB2ZXJ5IGhhcmQgdG8gdHJh Y2sgZG93biBidWdzIGFyZQo+Pj4+IHByZXR0eSBtdWNoIGd1YXJhbnRlZWQuIFNvIHdoZXRoZXIg d2UgdXNlIGV4cGxpY2l0IGdmcCBmbGFncyBvciB0aGUKPj4+PiBjb250ZXh0IGFwaXMsIHJlc3Vs dCBpcyBleGFjdGx5IHRoZSBzYW1lLgo+PiBPayBsZXQgdXMgcmVjYXAgd2hhdCBUVE1zIFRUIHNo cmlua2VyIGRvZXMgaGVyZToKPj4KPj4gMS4gV2UgZ290IG1lbW9yeSB3aGljaCBpcyBub3Qgc3dh cGFibGUgYmVjYXVzZSBpdCBtaWdodCBiZSBhY2Nlc3NlZCBieSB0aGUKPj4gR1BVIGF0IGFueSB0 aW1lLgo+PiAyLiBNYWtlIHN1cmUgdGhlIG1lbW9yeSBpcyBub3QgYWNjZXNzZWQgYnkgdGhlIEdQ VSBhbmQgZHJpdmVyIG5lZWQgdG8gZ3JhYiBhCj4+IGxvY2sgYmVmb3JlIHRoZXkgY2FuIG1ha2Ug aXQgYWNjZXNzaWJsZSBhZ2Fpbi4KPj4gMy4gQWxsb2NhdGUgYSBzaG1lbSBmaWxlIGFuZCBjb3B5 IG92ZXIgdGhlIG5vdCBzd2FwYWJsZSBwYWdlcy4KPiBUaGlzIGlzIHF1aXRlIHRyaWNreSBiZWNh dXNlIHRoZSBzaHJpbmtlciBvcGVyYXRlcyBpbiB0aGUgUEZfTUVNQUxMT0MKPiBjb250ZXh0IHNv IHN1Y2ggYW4gYWxsb2NhdGlvbiB3b3VsZCBiZSBhbGxvd2VkIHRvIGNvbXBsZXRlbHkgZGVwbGV0 ZQo+IG1lbW9yeSB1bmxlc3MgeW91IGV4cGxpY2l0bHkgbWFyayB0aGF0IGNvbnRleHQgYXMgX19H RlBfTk9NRU1BTExPQy4KClRoYW5rcywgZXhhY3RseSB0aGF0IHdhcyBvbmUgdGhpbmcgSSB3YXMg YWJzb2x1dGVseSBub3Qgc3VyZSBhYm91dC4gQW5kIAp5ZXMgSSBhZ3JlZSB0aGF0IHRoaXMgaXMg cmVhbGx5IHRyaWNreS4KCklkZWFsbHkgSSB3b3VsZCBsaWtlIHRvIGJlIGFibGUgdG8gdHJpZ2dl ciBzd2FwcGluZyBvdXQgdGhlIHNobWVtIHBhZ2UgSSAKYWxsb2NhdGVkIGltbWVkaWF0ZWx5IGFm dGVyIGRvaW5nIHRoZSBjb3B5LgoKVGhpcyB3YXkgSSB3b3VsZCBvbmx5IG5lZWQgYSBzaW5nbGUg cGFnZSBmb3IgdGhlIHdob2xlIHNocmluayBvcGVyYXRpb24gCmF0IGFueSBnaXZlbiB0aW1lLgoK PiBBbHNvIG5vdGUgdGhhdCBpZiB0aGUgYWxsb2NhdGlvbiBjYW5ub3Qgc3VjY2VlZCBpdCB3aWxs IG5vdCB0cmlnZ2VyIHJlY2xhaW0KPiBhZ2FpbiBiZWNhdXNlIHlvdSBhcmUgYWxyZWFkeSBjYWxs ZWQgZnJvbSB0aGUgcmVjbGFpbSBjb250ZXh0Lgo+Cj4+IDQuIEZyZWUgdGhlIG5vdCBzd2FwYWJs ZS9yZWNsYWltYWJsZSBwYWdlcy4KPj4KPj4gVGhlIHBhZ2VzIHdlIGdvdCBmcm9tIHRoZSBzaG1l bSBmaWxlIGFyZSBlYXNpbHkgc3dhcGFibGUgdG8gZGlzayBhZnRlciB0aGUKPj4gY29weSBpcyBj b21wbGV0ZWQuIEJ1dCBvbmx5IGlmIElPIGlzIG5vdCBhbHJlYWR5IGJsb2NrZWQgYmVjYXVzZSB0 aGUKPj4gc2hyaW5rZXIgd2FzIGNhbGxlZCBmcm9tIGFuIGFsbG9jYXRpb24gcmVzdHJpY3RlZCBi eSBHRlBfTk9GUyBvciBHRlBfTk9JTy4KPiBTb3JyeSBmb3IgYmVpbmcgZGVuc2UgaGVyZSBidXQg SSBzdGlsbCBkbyBub3QgZm9sbG93IHRoZSBhY3R1YWwgcHJvYmxlbQo+ICh3ZWxsLCBleGNlcHQg Zm9yIHRoZSBhYm92ZSBtZW50aW9uZWQgb25lKS4gSXMgdGhlIHNvbGUgcG9pbnQgb2YgdGhpcyB0 bwo+IGVtdWxhdGUgYSBHRlBfTk8qIGFsbG9jYXRpb24gY29udGV4dCBhbmQgc2VlIGhvdyBzaHJp bmtlciBiZWhhdmVzPwoKUGxlYXNlIGJlIGFzIGRlbnNlIGFzIHlvdSBuZWVkIHRvIGJlIDopCgpJ IHRoaW5rIERhbmllbCBhbmQgSSBvbmx5IGhhdmUgYSB2ZXJ5IHJvdWdoIHVuZGVyc3RhbmRpbmcg b2YgdGhlIG1lbW9yeSAKbWFuYWdlbWVudCBkZXRhaWxzIGhlcmUsIGJ1dCB3ZSBuZWVkIGV4YWN0 bHkgdGhhdCBrbm93bGVkZ2UgdG8gZ2V0IHRoZSAKR1BVIG1lbW9yeSBtYW5hZ2VtZW50IGludG8g dGhlIHNoYXBlIHdlIHdhbnQgaXQgdG8gYmUuCgpUaGFua3MsCkNocmlzdGlhbi4KX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxp c3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==