From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fT9PK-0006gs-Il for qemu-devel@nongnu.org; Wed, 13 Jun 2018 13:18:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fT9PH-0004q4-4e for qemu-devel@nongnu.org; Wed, 13 Jun 2018 13:18:06 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:44640) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fT9PG-0004nQ-P5 for qemu-devel@nongnu.org; Wed, 13 Jun 2018 13:18:02 -0400 Received: by mail-qk0-x244.google.com with SMTP id 185-v6so1945433qkk.11 for ; Wed, 13 Jun 2018 10:18:02 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20180313224719.4954-1-pbonzini@redhat.com> <20180313224719.4954-51-pbonzini@redhat.com> <20180601185139.GA25837@flamenco> <323c9978-2d21-cfec-a613-57f0c675531f@amsat.org> Message-ID: <76061b88-b9d5-8095-b60e-cbe53993113c@amsat.org> Date: Wed, 13 Jun 2018 14:17:58 -0300 MIME-Version: 1.0 In-Reply-To: <323c9978-2d21-cfec-a613-57f0c675531f@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PULL 50/69] hw/alpha/dp264: Use the TYPE_SMC37C669_SUPERIO List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , "Emilio G. Cota" , Richard Henderson Cc: qemu-devel@nongnu.org On 06/13/2018 01:35 PM, Philippe Mathieu-Daudé wrote: > On 06/13/2018 01:21 PM, Paolo Bonzini wrote: >> On 01/06/2018 20:51, Emilio G. Cota wrote: >>> On Tue, Mar 13, 2018 at 23:47:00 +0100, Paolo Bonzini wrote: >>>> From: Philippe Mathieu-Daudé >>>> >>>> Signed-off-by: Philippe Mathieu-Daudé >>>> Message-Id: <20180308223946.26784-25-f4bug@amsat.org> >>>> Signed-off-by: Paolo Bonzini >>>> --- >>>> default-configs/alpha-softmmu.mak | 3 +++ >>>> hw/alpha/dp264.c | 10 ++++------ >>>> 2 files changed, 7 insertions(+), 6 deletions(-) >>> >>> This commit breaks alpha-softmmu bootup for me. I get no console >>> output whatsoever -- not even the green "Hello" when invoking >>> the alpha-softmmu binary with no arguments. >>> >>> Did anybody else notice this? >> >> Philippe, are you going to take a look? I tested 2.12 and I get the > > Sure. Sorry I didn't notice earlier, my mail-filter demotes subject with > PULL :/ > >> same result as latest mainline: nothing on the VGA and >> >> PCI: 00:00:0 class 0300 id 1013:00b8 >> PCI: region 0: 10000000 >> PCI: region 1: 12000000 >> PCI: 00:01:0 class 0200 id 8086:100e >> PCI: region 0: 12020000 >> PCI: region 1: 0000c000 >> PCI: 00:02:0 class 0101 id 1095:0646 >> PCI: region 0: 0000c040 >> PCI: region 1: 0000c048 >> PCI: region 3: 0000c04c >> >> on the serial console, respectively for VGA/network/IDE. Creating the Super I/O _before_ the VGA setup fixes this issue... I suppose the problem is some ISA global variable? I'll keep digging. -- >8 -- diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c @@ -83,6 +83,12 @@ static void clipper_init(MachineState *machine) i8254_pit_init(isa_bus, 0x40, 0, NULL); + /* 2 82C37 (dma) */ + isa_create_simple(isa_bus, "i82374"); + + /* Super I/O */ + isa_create_simple(isa_bus, TYPE_SMC37C669_SUPERIO); + /* VGA setup. Don't bother loading the bios. */ pci_vga_init(pci_bus); @@ -91,12 +97,6 @@ static void clipper_init(MachineState *machine) pci_nic_init_nofail(&nd_table[i], pci_bus, "e1000", NULL); } - /* 2 82C37 (dma) */ - isa_create_simple(isa_bus, "i82374"); - - /* Super I/O */ - isa_create_simple(isa_bus, TYPE_SMC37C669_SUPERIO); - /* IDE disk setup. */ { DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; --