From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C69AC4725B for ; Wed, 6 May 2020 08:08:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD14020661 for ; Wed, 6 May 2020 08:08:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728601AbgEFIId (ORCPT ); Wed, 6 May 2020 04:08:33 -0400 Received: from www62.your-server.de ([213.133.104.62]:35208 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728345AbgEFIIc (ORCPT ); Wed, 6 May 2020 04:08:32 -0400 Received: from sslproxy05.your-server.de ([78.46.172.2]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1jWF6Q-0001an-HW; Wed, 06 May 2020 10:08:26 +0200 Received: from [178.195.186.98] (helo=pc-9.home) by sslproxy05.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWF6P-0005kQ-Vt; Wed, 06 May 2020 10:08:26 +0200 Subject: Re: [PATCH bpf-next 0/4] RV64 BPF JIT Optimizations To: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Luke Nelson Cc: bpf , Luke Nelson , Xi Wang , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , Netdev , linux-riscv@lists.infradead.org, LKML References: <20200506000320.28965-1-luke.r.nels@gmail.com> From: Daniel Borkmann Message-ID: <76105702-4f84-ead9-6568-48f718cf85c2@iogearbox.net> Date: Wed, 6 May 2020 10:08:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.2/25803/Tue May 5 14:19:25 2020) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/6/20 9:08 AM, Björn Töpel wrote: > On Wed, 6 May 2020 at 02:03, Luke Nelson wrote: >> >> This patch series introduces a set of optimizations to the BPF JIT >> on RV64. The optimizations are related to the verifier zero-extension >> optimization and BPF_JMP BPF_K. >> >> We tested the optimizations on a QEMU riscv64 virt machine, using >> lib/test_bpf and test_verifier, and formally verified their correctness >> using Serval. >> > > Luke and Xi, > > Thanks a lot for working on this! Very nice series! > > For the series: > Reviewed-by: Björn Töpel > Acked-by: Björn Töpel > >> Luke Nelson (4): >> bpf, riscv: Enable missing verifier_zext optimizations on RV64 >> bpf, riscv: Optimize FROM_LE using verifier_zext on RV64 >> bpf, riscv: Optimize BPF_JMP BPF_K when imm == 0 on RV64 >> bpf, riscv: Optimize BPF_JSET BPF_K using andi on RV64 >> >> arch/riscv/net/bpf_jit_comp64.c | 64 ++++++++++++++++++++++----------- >> 1 file changed, 44 insertions(+), 20 deletions(-) >> >> Cc: Xi Wang Applied, thanks everyone! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25BBEC28CBC for ; Wed, 6 May 2020 08:09:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E85BA20661 for ; Wed, 6 May 2020 08:09:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EBs+ADfU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E85BA20661 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=iogearbox.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NXVaKDz+JVYwyoIHnSRq5UCQ9tuNORjprV4LJpsQmBQ=; b=EBs+ADfUTauxxC r6uK1XC3tBlJ18urcrOl6Ur8G4L/RnRPpzl3TcxtBfn4tfQnRTnhTej7w2ciWyfnXZFYUlUYTlW9y YiX/g17cNj/SDTQymtjnkuZIwhNFE6kIuYB7oKvoecGIPHz3t1RtG8qrS5kSWeVZP3CtyYcdmL6LS zH30PE2HGq0iY2ZxXE5f2e9H2C54qdgDWsWxQlgvIi63nCoRwIPnGWOItH4qvRBD7Z9u4pzeu0qza bFagQTcBGKOLiHBfeU+jCqtmq2ECXhsxEw5qRKG8BObGRWyZaAQpeSlJjVUjhtDS5FPhIa7ET8kUv Ev5UU26KJrtFYaaFQZQA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWF71-0004jh-Pd; Wed, 06 May 2020 08:09:03 +0000 Received: from www62.your-server.de ([213.133.104.62]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWF6l-0004Mu-C2 for linux-riscv@lists.infradead.org; Wed, 06 May 2020 08:08:54 +0000 Received: from sslproxy05.your-server.de ([78.46.172.2]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1jWF6Q-0001an-HW; Wed, 06 May 2020 10:08:26 +0200 Received: from [178.195.186.98] (helo=pc-9.home) by sslproxy05.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jWF6P-0005kQ-Vt; Wed, 06 May 2020 10:08:26 +0200 Subject: Re: [PATCH bpf-next 0/4] RV64 BPF JIT Optimizations To: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Luke Nelson References: <20200506000320.28965-1-luke.r.nels@gmail.com> From: Daniel Borkmann Message-ID: <76105702-4f84-ead9-6568-48f718cf85c2@iogearbox.net> Date: Wed, 6 May 2020 10:08:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.2/25803/Tue May 5 14:19:25 2020) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200506_010847_418926_629A1FA6 X-CRM114-Status: GOOD ( 11.76 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Song Liu , Albert Ou , Luke Nelson , Netdev , John Fastabend , Alexei Starovoitov , linux-riscv@lists.infradead.org, LKML , Palmer Dabbelt , Paul Walmsley , KP Singh , Yonghong Song , bpf , Andrii Nakryiko , Martin KaFai Lau , Xi Wang Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On 5/6/20 9:08 AM, Björn Töpel wrote: > On Wed, 6 May 2020 at 02:03, Luke Nelson wrote: >> >> This patch series introduces a set of optimizations to the BPF JIT >> on RV64. The optimizations are related to the verifier zero-extension >> optimization and BPF_JMP BPF_K. >> >> We tested the optimizations on a QEMU riscv64 virt machine, using >> lib/test_bpf and test_verifier, and formally verified their correctness >> using Serval. >> > > Luke and Xi, > > Thanks a lot for working on this! Very nice series! > > For the series: > Reviewed-by: Björn Töpel > Acked-by: Björn Töpel > >> Luke Nelson (4): >> bpf, riscv: Enable missing verifier_zext optimizations on RV64 >> bpf, riscv: Optimize FROM_LE using verifier_zext on RV64 >> bpf, riscv: Optimize BPF_JMP BPF_K when imm == 0 on RV64 >> bpf, riscv: Optimize BPF_JSET BPF_K using andi on RV64 >> >> arch/riscv/net/bpf_jit_comp64.c | 64 ++++++++++++++++++++++----------- >> 1 file changed, 44 insertions(+), 20 deletions(-) >> >> Cc: Xi Wang Applied, thanks everyone!