From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nEAN5-0004Pz-8x for mharc-grub-devel@gnu.org; Sun, 30 Jan 2022 08:35:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52876) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEAN1-0004Lc-CO for grub-devel@gnu.org; Sun, 30 Jan 2022 08:35:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:60672) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEAMy-0004J2-LX for grub-devel@gnu.org; Sun, 30 Jan 2022 08:35:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643549751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qAaXss4O+nSVFPAGoluwNU0C9/tXHzujdP4rx5HqYCs=; b=b7k2w0CJk7mu+RKvuHBgdgS6G2jnmpHKLAmErAjO3zuyz7aAsPqTouWckIsLReNsb/CbcT LTXeoN2UYc1Ff3szSBZdIgZEtXwuJ8d1ybqE3Qhk5Gj+aWZYqTnSzP9aYHbN+nGh6TjyE7 7yztY1Iivt3ZCPblSIjO/QJlxx2S1IE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-452-HCudx-grPhWNO8WomdZI4g-1; Sun, 30 Jan 2022 08:35:50 -0500 X-MC-Unique: HCudx-grPhWNO8WomdZI4g-1 Received: by mail-wr1-f72.google.com with SMTP id z1-20020adfbbc1000000b001df54394cebso2821757wrg.20 for ; Sun, 30 Jan 2022 05:35:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=qAaXss4O+nSVFPAGoluwNU0C9/tXHzujdP4rx5HqYCs=; b=pcbRrfQDaFELD5XPqQ3QcfAiQj4jCZKINvY2jb7OzwogCaK0+6jw83wkem9DNz6I0f Oc7VdDULgIx2jhBccGMo9DqPaEawOh6Alx4qNpBycZ30A8YnBidyfW+eLhBfEd5MZSKS Z4uNxTwUm0A3/DUXGx7hjzveCBcPVtBrp0KyHF/ACsBu1XbLF3h/beysSekqePcDEKrx YattJYG+addNqPslxOO+fERjp2DPyjl+MZM2nb7gAatbAr+lC0J0VhSIgqBvj6XOwitF w/S/v4af0u852DqHm5fySWao40uZffPKIsURiazVVpdzy43FvJRMrzTtdTTftYRClzCv fl6Q== X-Gm-Message-State: AOAM532vBL5y04OpEDMO6hm4FRuvuCH1ahQOlvh9dVtvon2xavmoNODQ 96fY0KjTvF3Lm4y175iIRdzXjdGmyVkstYz4IMvOpRpNx5P3m5kb401lRFiIkxZsKPmWTqhF8nK 5q+drR/XjDPjDEO7mzb5AjdCmoh34eeyUDuDLFWWx5UdGlJ0p/09p1efF30BGEg== X-Received: by 2002:adf:9dce:: with SMTP id q14mr13448637wre.395.1643549748865; Sun, 30 Jan 2022 05:35:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJxLBq+cQ2xtwJagXEtQuGn46IMRP3wYp7TU6gvKflwj0AW++4f9SJo1kvWu9k7GMAilsruIgQ== X-Received: by 2002:adf:9dce:: with SMTP id q14mr13448621wre.395.1643549748608; Sun, 30 Jan 2022 05:35:48 -0800 (PST) Received: from [192.168.1.102] ([92.176.231.205]) by smtp.gmail.com with ESMTPSA id m28sm3560095wms.34.2022.01.30.05.35.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Jan 2022 05:35:48 -0800 (PST) Message-ID: <761420ab-d5ce-15ee-4ab7-a9e1a2627cd5@redhat.com> Date: Sun, 30 Jan 2022 14:35:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 2/2] EFI: console: Do not set cursor until the first text output To: The development of GNU GRUB , Hans de Goede Cc: Robbie Harwood References: <20220128114349.87480-1-hdegoede@redhat.com> <20220128114349.87480-2-hdegoede@redhat.com> From: Javier Martinez Canillas In-Reply-To: <20220128114349.87480-2-hdegoede@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=javierm@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.098, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jan 2022 13:35:57 -0000 On 1/28/22 12:43, Hans de Goede wrote: > To allow flickerfree boot the EFI console code does not call > grub_efi_set_text_mode (1) until some text is actually output. > > Depending on if the output text is because of an error loading > e.g. the .cfg file; or because of showing the menu the cursor needs > to be on or off when the first text is shown. > > So far the cursor was hardcoded to being on, but this is causing > drawing artifacts + slow drawing of the menu as reported here: > https://bugzilla.redhat.com/show_bug.cgi?id=1946969 > > Handle the cursorstate in the same way as the colorstate to fix this, > when no text has been output yet, just cache the cursorstate and > then use the last set value when the first text is output. > > Fixes: 2d7c3abd871f ("efi/console: Do not set text-mode until we actually need it") > Signed-off-by: Hans de Goede > --- Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Linux Engineering Red Hat