Re: [Buildroot] [PATCH 1/2] toolchain: introduce BR2_TOOLCHAIN_HAS_GCC_BUG_83143

[Arnout Vandecappelle <arnout@mind.be>]

On 28/08/2021 14:39, Giulio Benetti wrote:
> Hi Arnout,
> 
>> Il giorno 28 ago 2021, alle ore 14:06, Arnout Vandecappelle <arnout@mind.be> ha scritto:
>>
>> 
>>
>>> On 28/08/2021 00:34, Giulio Benetti wrote:
>>> ruby package fails to build for the SH4 architecture with optimization
>>> enabled with gcc = 9.3.0:
>>> http://autobuild.buildroot.net/results/f57/f5742e7fb6e8142bcdb53b7f4f5e9c1bea3558cd/
>>>
>>> It's already been reported upstream:
>>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83143
>>>
>>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>>> ---
>>> toolchain/Config.in | 9 +++++++++
>>> 1 file changed, 9 insertions(+)
>>>
>>> diff --git a/toolchain/Config.in b/toolchain/Config.in
>>> index bf2bb3efe4..4419443930 100644
>>> --- a/toolchain/Config.in
>>> +++ b/toolchain/Config.in
>>> @@ -133,6 +133,15 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_68485
>>>    bool
>>>    default y if BR2_microblaze
>>>
>>> +# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83143
>>> +# Error: invalid operands (*UND* and .text sections) for `-' on sh4.
>>> +# This bug no longer exists in gcc 10.x but reappeared on gcc 11.x and
>>> +# it still not been fixed yet.
>>> +config BR2_TOOLCHAIN_HAS_GCC_BUG_83143
>>> +    bool
>>> +    default y if !BR2_TOOLCHAIN_GCC_AT_LEAST_10
>>
>> The condition doesn't correspond to the comment above...
> 
> I’ve tried it and checked .config
> I find it emitted on gcc 9 and 11 while on gcc 10 not as described.

 I don't know what you did differently, but that's not what I have...

With this defconfig:

BR2_sh=y
BR2_GCC_VERSION_11_X=y

grep GCC_BUG_83143 .config

produces no output, while with this defconfig:

BR2_sh=y
BR2_GCC_VERSION_9_X=y

it does show it.


 BTW, I didn't notice before, but: why is this only for sh4, and not any other
SuperH? I mean, are you sure it's only on sh4? sh4 is the only one tested in the
autobuilders, of course, but it's kind of likely that other SuperH suffer from
the same bug...


> It’s always difficult to me to understand how that variable works.

 It's very simple: AT_LEAST_10_X is true for all GCC >= 10.0, so also for GCC
11. If you want exactly one version, it's AT_LEAST_10 && !AT_LEAST_11. In this
case, you want the negative of that, so !AT_LEAST_10 || AT_LEAST_11.

 Regards,
 Arnout

> 
> Giulio
> 
>>
>>
>> Regards,
>> Arnout
>>
>>> +    depends on BR2_sh4
>>> +
>>> # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180. This bug no
>>> # longer exists in gcc 8.x.
>>> config BR2_TOOLCHAIN_HAS_GCC_BUG_85180
>>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> 
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot