From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N6Tmq-0004IR-QV
	for qemu-devel@nongnu.org; Fri, 06 Nov 2009 13:43:52 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N6Tmq-0004HN-0w
	for qemu-devel@nongnu.org; Fri, 06 Nov 2009 13:43:52 -0500
Received: from [199.232.76.173] (port=32957 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N6Tmp-0004HC-T6
	for qemu-devel@nongnu.org; Fri, 06 Nov 2009 13:43:51 -0500
Received: from fg-out-1718.google.com ([72.14.220.155]:8244)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1N6Tmp-0004Rr-0Z
	for qemu-devel@nongnu.org; Fri, 06 Nov 2009 13:43:51 -0500
Received: by fg-out-1718.google.com with SMTP id d23so668441fga.10
	for <qemu-devel@nongnu.org>; Fri, 06 Nov 2009 10:43:49 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <20091106181153.GB12533@mothafucka.localdomain>
References: <1257437115-22725-1-git-send-email-glommer@redhat.com>
	<f43fc5580911061005l3fa4b23i17b52f7b9fc0f7fe@mail.gmail.com>
	<20091106181153.GB12533@mothafucka.localdomain>
Date: Fri, 6 Nov 2009 19:43:48 +0100
Message-ID: <761ea48b0911061043i5dbaaab5td2e0d34cc4ed68a9@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] v3: don't call reset functions on cpu
	initialization
From: Laurent Desnogues <laurent.desnogues@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, aliguori@us.ibm.com, qemu-devel@nongnu.org

On Fri, Nov 6, 2009 at 7:11 PM, Glauber Costa <glommer@redhat.com> wrote:
> On Fri, Nov 06, 2009 at 08:05:40PM +0200, Blue Swirl wrote:
>> On Thu, Nov 5, 2009 at 6:05 PM, Glauber Costa <glommer@redhat.com> wrote=
:
[...]
>> > --- a/target-i386/helper.c
>> > +++ b/target-i386/helper.c
>> > @@ -1885,7 +1885,9 @@ CPUX86State *cpu_x86_init(const char *cpu_model)
>> > =A0 =A0 =A0 =A0 return NULL;
>> > =A0 =A0 }
>> > =A0 =A0 mce_init(env);
>> > +#ifdef CONFIG_USER_ONLY
>> > =A0 =A0 cpu_reset(env);
>> > +#endif
>>
>> Please push the call to *-user/main.c, just after call to cpu_init().
> I'd prefer it that way too. But cpu_reset is also called in some other pl=
aces,
> and Laurent suggested me to to this way.

Yes, you'd have to remove all calls to cpu_reset from all CPUs.
And also add a call to cpu_reset to cpu_copy.

> I don't really know much about -user, so I'm fine with whatever you guys =
agree on.

I honestly don't care that much as long as all targets still work
in user mode :-)

The aim was to make Glauber's patch less intrusive.


Laurent