From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N6UFN-00050I-Nf
	for qemu-devel@nongnu.org; Fri, 06 Nov 2009 14:13:21 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N6UFM-0004zA-UQ
	for qemu-devel@nongnu.org; Fri, 06 Nov 2009 14:13:21 -0500
Received: from [199.232.76.173] (port=42717 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N6UFM-0004yz-PK
	for qemu-devel@nongnu.org; Fri, 06 Nov 2009 14:13:20 -0500
Received: from fg-out-1718.google.com ([72.14.220.154]:58325)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <laurent.desnogues@gmail.com>) id 1N6UFM-0000q4-D5
	for qemu-devel@nongnu.org; Fri, 06 Nov 2009 14:13:20 -0500
Received: by fg-out-1718.google.com with SMTP id 19so375522fgg.10
	for <qemu-devel@nongnu.org>; Fri, 06 Nov 2009 11:13:19 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <f43fc5580911061101w6334864exa57a81d182df7bdc@mail.gmail.com>
References: <1257437115-22725-1-git-send-email-glommer@redhat.com>
	<f43fc5580911061005l3fa4b23i17b52f7b9fc0f7fe@mail.gmail.com>
	<20091106181153.GB12533@mothafucka.localdomain>
	<761ea48b0911061043i5dbaaab5td2e0d34cc4ed68a9@mail.gmail.com>
	<f43fc5580911061101w6334864exa57a81d182df7bdc@mail.gmail.com>
Date: Fri, 6 Nov 2009 20:13:19 +0100
Message-ID: <761ea48b0911061113n7f254ac4wd1d9f994abe0f53a@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] v3: don't call reset functions on cpu
	initialization
From: Laurent Desnogues <laurent.desnogues@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Glauber Costa <glommer@redhat.com>, aliguori@us.ibm.com, qemu-devel@nongnu.org

On Fri, Nov 6, 2009 at 8:01 PM, Blue Swirl <blauwirbel@gmail.com> wrote:
> On Fri, Nov 6, 2009 at 8:43 PM, Laurent Desnogues
> <laurent.desnogues@gmail.com> wrote:
[...]
>> I honestly don't care that much as long as all targets still work
>> in user mode :-)
>>
>> The aim was to make Glauber's patch less intrusive.
>
> Given that only the new calls to cpu_reset are important and the
> removals are much less so (double reset shouldn't be a problem), the
> least intrusive version would be to just add the new calls and do the
> clean up later.

Multiple resets would result in memory leaks for MIPS for instance.
So I don't think they are that innocuous.  Though that probably is
more a problem of the MIPS reset than anything else :-)


Laurent