Re: [Qemu-devel] [PATCH] v3: don't call reset functions on cpu initialization

From: Laurent Desnogues <laurent.desnogues@gmail.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Glauber Costa <glommer@redhat.com>,
	aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] v3: don't call reset functions on cpu initialization
Date: Fri, 6 Nov 2009 20:50:28 +0100	[thread overview]
Message-ID: <761ea48b0911061150s74c9b145kaf7b25df973210c@mail.gmail.com> (raw)
In-Reply-To: <f43fc5580911061136u69c06151x58114bf106c8cae7@mail.gmail.com>

On Fri, Nov 6, 2009 at 8:36 PM, Blue Swirl <blauwirbel@gmail.com> wrote:
> On Fri, Nov 6, 2009 at 9:13 PM, Laurent Desnogues
> <laurent.desnogues@gmail.com> wrote:
>> On Fri, Nov 6, 2009 at 8:01 PM, Blue Swirl <blauwirbel@gmail.com> wrote:
>>> On Fri, Nov 6, 2009 at 8:43 PM, Laurent Desnogues
>>> <laurent.desnogues@gmail.com> wrote:
>> [...]
>>>> I honestly don't care that much as long as all targets still work
>>>> in user mode :-)
>>>>
>>>> The aim was to make Glauber's patch less intrusive.
>>>
>>> Given that only the new calls to cpu_reset are important and the
>>> removals are much less so (double reset shouldn't be a problem), the
>>> least intrusive version would be to just add the new calls and do the
>>> clean up later.
>>
>> Multiple resets would result in memory leaks for MIPS for instance.
>> So I don't think they are that innocuous.  Though that probably is
>> more a problem of the MIPS reset than anything else :-)
>
> You are hinting at target-mips/translate_init.c: mmu_init()? Right, it
> shouldn't do the allocation.

No, I was talking about mvp_init.

Laurent