All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH v2 10/10] accel/tcg: Encode breakpoint info into tb->cflags
Date: Sat, 17 Jul 2021 12:20:42 -0700	[thread overview]
Message-ID: <762ce4c8-a0c2-b5bf-3eac-4ae4421d1ff8@linaro.org> (raw)
In-Reply-To: <CAFEAcA_HdOyPdbrQ+EeGYAP88-0L_RQEbB10-7KmMqpUASzYbA@mail.gmail.com>

On 7/17/21 10:58 AM, Peter Maydell wrote:
>> +static uint32_t cflags_for_breakpoints(CPUState *cpu, target_ulong pc,
>> +                                       uint32_t cflags)
>> +{
>> +    uint32_t bflags = 0;
>> +
>> +    if (unlikely(cpu->singlestep_enabled)) {
>> +        bflags = CF_BP_SSTEP;
>> +    } else {
> 
> Won't this ignore breakpoints when singlestepping ?

Single-step already has priority over other breakpoints:

>          /* Pass breakpoint hits to target for further processing */
> -        if (!db->singlestep_enabled
> -            && unlikely(!QTAILQ_EMPTY(&cpu->breakpoints))) {


r~


  reply	other threads:[~2021-07-17 19:22 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-12 15:39 [PATCH v2 00/10] tcg: breakpoint reorg Richard Henderson
2021-07-12 15:39 ` [PATCH v2 01/10] accel/tcg: Reduce CF_COUNT_MASK to match TCG_MAX_INSNS Richard Henderson
2021-07-17 17:30   ` Peter Maydell
2021-07-17 18:31     ` Richard Henderson
2021-07-17 17:33   ` Alex Bennée
2021-07-12 15:39 ` [PATCH v2 02/10] accel/tcg: Move curr_cflags into cpu-exec.c Richard Henderson
2021-07-17 17:32   ` Peter Maydell
2021-07-17 17:34   ` Alex Bennée
2021-07-12 15:39 ` [PATCH v2 03/10] accel/tcg: Add CF_NO_GOTO_TB and CF_NO_GOTO_PTR Richard Henderson
2021-07-17 17:36   ` Alex Bennée
2021-07-17 17:36   ` Peter Maydell
2021-07-12 15:39 ` [PATCH v2 04/10] accel/tcg: Drop CF_NO_GOTO_PTR from -d nochain Richard Henderson
2021-07-17 17:39   ` Peter Maydell
2021-07-17 17:39   ` Alex Bennée
2021-07-17 18:38     ` Richard Henderson
2021-07-17 19:48       ` Alex Bennée
2021-07-12 15:39 ` [PATCH v2 05/10] accel/tcg: Handle -singlestep in curr_cflags Richard Henderson
2021-07-17 17:41   ` Peter Maydell
2021-07-17 17:42   ` Alex Bennée
2021-07-17 18:42     ` Richard Henderson
2021-07-17 19:51       ` Peter Maydell
2021-07-12 15:40 ` [PATCH v2 06/10] accel/tcg: Use CF_NO_GOTO_{TB, PTR} in cpu_exec_step_atomic Richard Henderson
2021-07-17 17:43   ` Peter Maydell
2021-07-17 19:03     ` Richard Henderson
2021-07-17 17:47   ` [PATCH v2 06/10] accel/tcg: Use CF_NO_GOTO_{TB,PTR} " Alex Bennée
2021-07-12 15:40 ` [PATCH v2 07/10] accel/tcg: Move cflags lookup into tb_find Richard Henderson
2021-07-17 17:45   ` Peter Maydell
2021-07-12 15:40 ` [PATCH v2 08/10] accel/tcg: Adjust interface of TranslatorOps.breakpoint_check Richard Henderson
2021-07-17 17:52   ` Peter Maydell
2021-07-17 19:41     ` Richard Henderson
2021-07-12 15:40 ` [PATCH v2 09/10] accel/tcg: Hoist tb_cflags to a local in translator_loop Richard Henderson
2021-07-17 17:50   ` Alex Bennée
2021-07-12 15:40 ` [PATCH v2 10/10] accel/tcg: Encode breakpoint info into tb->cflags Richard Henderson
2021-07-17 17:58   ` Peter Maydell
2021-07-17 19:20     ` Richard Henderson [this message]
2021-07-12 18:20 ` [PATCH v2 00/10] tcg: breakpoint reorg Mark Cave-Ayland
2021-07-17 17:16 ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=762ce4c8-a0c2-b5bf-3eac-4ae4421d1ff8@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.