From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BEE2C43460 for ; Fri, 2 Apr 2021 16:02:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CDC76115A for ; Fri, 2 Apr 2021 16:02:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235649AbhDBQCj (ORCPT ); Fri, 2 Apr 2021 12:02:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235650AbhDBQCi (ORCPT ); Fri, 2 Apr 2021 12:02:38 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96F95C0613E6 for ; Fri, 2 Apr 2021 09:02:35 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id y1so6016479ljm.10 for ; Fri, 02 Apr 2021 09:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7LS9QMZtPYDSC3+ItKIFHS8bZQT3Z+oEzlDTiKOG5UU=; b=LJsfj5596jju+lIm1cpaVNsyCnnUvNtPfrsphvCWDG9WKXhAQE6dJvQiLXmWTQfEr2 xgmY0WIl6O+zQy1ZqqrDWZyZxIrNP//9i6WhZ9TJ25ywiiE7o+BxWSnNDXfvrCi7LYHP jURQzWKFGkWQEvXMP1kdICj5dxzaZ6mWt1KJSpo2E6LBqWY42li6wAWCe4eJc75fEpVf Q7UJYNHwnZaNavhYuVyvSzMplwPTaz6+QCBRoJKOwz7lhy+tosMg4edQLW9FuneISqtI NwL1kmvTCIu3LBShypgTyXVcv5Kc3fHggOxHL4W/0wBo6qCduNhqfuFzQcKDCjFl1jiQ 0nug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7LS9QMZtPYDSC3+ItKIFHS8bZQT3Z+oEzlDTiKOG5UU=; b=SUfdl/+TBzW3IheNBggJbZGoHUoHn05qHAtLKeIaMyxlY+WWeirx1x8Yqs86NIthLO XeyU5l9EtAPGp37hyWxFncffOmJi/mBBtG/EbUgx7J6zEV9ASZCPmuifbYVdJcMN15uG hzlpmkeBYbGif13J8h6Tt5BAUtyvgraHU3rDeq4Th0kAKvtbcLFmvSyRhbv3dzLKezq8 7Ah24qQ6HIoxbEE48RX4yX/jLRdm8hb3UPcwQ5alpQJVW8Qjv7hq3NZU78uLfkDTdmIn 7mr+2X8k8L9d5ed+yDMBkZXUcunddMZJGU8ovFRYWo0Qhxky1afuqZL71dO0gk32IgdD 8Jiw== X-Gm-Message-State: AOAM531fFLKTL+EuGOOHf1y3pa7HV51x04DCd6ThhHP25i2ukr2f4+Ld Yu8QEol6mywtYMw1IDh89J8= X-Google-Smtp-Source: ABdhPJwFNWKRiTRgqWKMz0vNmB+o4wQzBgwHAYdkKEiQHbkbjtnJ34ZorbBoUyodH7Mer97dYyU/9Q== X-Received: by 2002:a2e:9855:: with SMTP id e21mr8396252ljj.26.1617379354145; Fri, 02 Apr 2021 09:02:34 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-85.dynamic.spd-mgts.ru. [109.252.193.85]) by smtp.googlemail.com with ESMTPSA id x4sm962500ljj.91.2021.04.02.09.02.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Apr 2021 09:02:33 -0700 (PDT) Subject: Re: [PATCH v5 03/21] gpu: host1x: Show number of pending waiters in debugfs To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Mikko Perttunen Cc: Thierry Reding , Mikko Perttunen , jonathanh@nvidia.com, airlied@linux.ie, daniel@ffwll.ch, linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, talho@nvidia.com, bhuntsman@nvidia.com References: <20210111130019.3515669-1-mperttunen@nvidia.com> <20210111130019.3515669-4-mperttunen@nvidia.com> <1010683e-56c9-4b06-1540-d8c60a632c70@kapsi.fi> <20210401211949.GA25223@qmqm.qmqm.pl> From: Dmitry Osipenko Message-ID: <7636618d-72f7-ee0f-df23-1f2ec96973b4@gmail.com> Date: Fri, 2 Apr 2021 19:02:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210401211949.GA25223@qmqm.qmqm.pl> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 02.04.2021 00:19, Michał Mirosław пишет: > On Fri, Mar 26, 2021 at 04:34:13PM +0200, Mikko Perttunen wrote: >> On 3/23/21 12:16 PM, Thierry Reding wrote: >>> On Mon, Jan 11, 2021 at 03:00:01PM +0200, Mikko Perttunen wrote: >>>> Show the number of pending waiters in the debugfs status file. >>>> This is useful for testing to verify that waiters do not leak >>>> or accumulate incorrectly. >>>> >>>> Signed-off-by: Mikko Perttunen >>>> --- >>>> drivers/gpu/host1x/debug.c | 14 +++++++++++--- >>>> 1 file changed, 11 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/drivers/gpu/host1x/debug.c b/drivers/gpu/host1x/debug.c >>>> index 1b4997bda1c7..8a14880c61bb 100644 >>>> --- a/drivers/gpu/host1x/debug.c >>>> +++ b/drivers/gpu/host1x/debug.c >>>> @@ -69,6 +69,7 @@ static int show_channel(struct host1x_channel *ch, void *data, bool show_fifo) >>>> static void show_syncpts(struct host1x *m, struct output *o) >>>> { >>>> + struct list_head *pos; >>>> unsigned int i; >>>> host1x_debug_output(o, "---- syncpts ----\n"); >>>> @@ -76,12 +77,19 @@ static void show_syncpts(struct host1x *m, struct output *o) >>>> for (i = 0; i < host1x_syncpt_nb_pts(m); i++) { >>>> u32 max = host1x_syncpt_read_max(m->syncpt + i); >>>> u32 min = host1x_syncpt_load(m->syncpt + i); >>>> + unsigned int waiters = 0; >>>> - if (!min && !max) >>>> + spin_lock(&m->syncpt[i].intr.lock); >>>> + list_for_each(pos, &m->syncpt[i].intr.wait_head) >>>> + waiters++; >>>> + spin_unlock(&m->syncpt[i].intr.lock); >>> >>> Would it make sense to keep a running count so that we don't have to >>> compute it here? >> >> Considering this is just a debug facility, I think I prefer not adding a new >> field just for it. > > This looks like IRQ-disabled region, so unless only root can trigger > this code, maybe the additional field could save a potential headache? > How many waiters can there be in the worst case? The host1x's IRQ handler runs in a workqueue, so it should be okay. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51D6FC433B4 for ; Fri, 2 Apr 2021 16:02:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0888960C3E for ; Fri, 2 Apr 2021 16:02:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0888960C3E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 731C66EE89; Fri, 2 Apr 2021 16:02:36 +0000 (UTC) Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD1016EE8B for ; Fri, 2 Apr 2021 16:02:35 +0000 (UTC) Received: by mail-lj1-x234.google.com with SMTP id 184so6033082ljf.9 for ; Fri, 02 Apr 2021 09:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7LS9QMZtPYDSC3+ItKIFHS8bZQT3Z+oEzlDTiKOG5UU=; b=LJsfj5596jju+lIm1cpaVNsyCnnUvNtPfrsphvCWDG9WKXhAQE6dJvQiLXmWTQfEr2 xgmY0WIl6O+zQy1ZqqrDWZyZxIrNP//9i6WhZ9TJ25ywiiE7o+BxWSnNDXfvrCi7LYHP jURQzWKFGkWQEvXMP1kdICj5dxzaZ6mWt1KJSpo2E6LBqWY42li6wAWCe4eJc75fEpVf Q7UJYNHwnZaNavhYuVyvSzMplwPTaz6+QCBRoJKOwz7lhy+tosMg4edQLW9FuneISqtI NwL1kmvTCIu3LBShypgTyXVcv5Kc3fHggOxHL4W/0wBo6qCduNhqfuFzQcKDCjFl1jiQ 0nug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7LS9QMZtPYDSC3+ItKIFHS8bZQT3Z+oEzlDTiKOG5UU=; b=K4zlTKSUKwwyggEHNlDyHaQ7x2WtfoSGaOJjvyqnfUnbngXaAhoxIWU/2UYDaekO/7 66CDuZVy+QiLOBFvtMtj9rrM/60sNsTnQ+aKSqRZYHGyVfepHmzW/uzkq9r+pDYrX+6M Fvmk+18/SEvoBB9z89QxQP+BtYHffZ5x07kywoaFXip6DNOZ9fmyWu/U27GeF86oF82f cjvRoM2OOJRoHJrzk6MzXj5IItbEoRB12Gb0THxunlmIGZz4hPahAULCQBaNLZf5no4f kfdKraeezIw01MxgoW/wz1NUVnKcygd2qK4RLUaeaE7Jgbb1VZNVhhqZSAt8w0ttF6sH /xrw== X-Gm-Message-State: AOAM5323WKR/zGGefp/FSRdcerYu9rD4LhHE4x+ckG6PQBzISuBRzt2X IXIQ6fvHguSuE67leKPeZvQ= X-Google-Smtp-Source: ABdhPJwFNWKRiTRgqWKMz0vNmB+o4wQzBgwHAYdkKEiQHbkbjtnJ34ZorbBoUyodH7Mer97dYyU/9Q== X-Received: by 2002:a2e:9855:: with SMTP id e21mr8396252ljj.26.1617379354145; Fri, 02 Apr 2021 09:02:34 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-85.dynamic.spd-mgts.ru. [109.252.193.85]) by smtp.googlemail.com with ESMTPSA id x4sm962500ljj.91.2021.04.02.09.02.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Apr 2021 09:02:33 -0700 (PDT) Subject: Re: [PATCH v5 03/21] gpu: host1x: Show number of pending waiters in debugfs To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Mikko Perttunen References: <20210111130019.3515669-1-mperttunen@nvidia.com> <20210111130019.3515669-4-mperttunen@nvidia.com> <1010683e-56c9-4b06-1540-d8c60a632c70@kapsi.fi> <20210401211949.GA25223@qmqm.qmqm.pl> From: Dmitry Osipenko Message-ID: <7636618d-72f7-ee0f-df23-1f2ec96973b4@gmail.com> Date: Fri, 2 Apr 2021 19:02:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210401211949.GA25223@qmqm.qmqm.pl> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, jonathanh@nvidia.com, talho@nvidia.com, bhuntsman@nvidia.com, Thierry Reding , linux-tegra@vger.kernel.org, Mikko Perttunen Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" MDIuMDQuMjAyMSAwMDoxOSwgTWljaGHFgiBNaXJvc8WCYXcg0L/QuNGI0LXRgjoKPiBPbiBGcmks IE1hciAyNiwgMjAyMSBhdCAwNDozNDoxM1BNICswMjAwLCBNaWtrbyBQZXJ0dHVuZW4gd3JvdGU6 Cj4+IE9uIDMvMjMvMjEgMTI6MTYgUE0sIFRoaWVycnkgUmVkaW5nIHdyb3RlOgo+Pj4gT24gTW9u LCBKYW4gMTEsIDIwMjEgYXQgMDM6MDA6MDFQTSArMDIwMCwgTWlra28gUGVydHR1bmVuIHdyb3Rl Ogo+Pj4+IFNob3cgdGhlIG51bWJlciBvZiBwZW5kaW5nIHdhaXRlcnMgaW4gdGhlIGRlYnVnZnMg c3RhdHVzIGZpbGUuCj4+Pj4gVGhpcyBpcyB1c2VmdWwgZm9yIHRlc3RpbmcgdG8gdmVyaWZ5IHRo YXQgd2FpdGVycyBkbyBub3QgbGVhawo+Pj4+IG9yIGFjY3VtdWxhdGUgaW5jb3JyZWN0bHkuCj4+ Pj4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBNaWtrbyBQZXJ0dHVuZW4gPG1wZXJ0dHVuZW5AbnZpZGlh LmNvbT4KPj4+PiAtLS0KPj4+PiAgIGRyaXZlcnMvZ3B1L2hvc3QxeC9kZWJ1Zy5jIHwgMTQgKysr KysrKysrKystLS0KPj4+PiAgIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAzIGRl bGV0aW9ucygtKQo+Pj4+Cj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2hvc3QxeC9kZWJ1 Zy5jIGIvZHJpdmVycy9ncHUvaG9zdDF4L2RlYnVnLmMKPj4+PiBpbmRleCAxYjQ5OTdiZGExYzcu LjhhMTQ4ODBjNjFiYiAxMDA2NDQKPj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9ob3N0MXgvZGVidWcu Ywo+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2hvc3QxeC9kZWJ1Zy5jCj4+Pj4gQEAgLTY5LDYgKzY5 LDcgQEAgc3RhdGljIGludCBzaG93X2NoYW5uZWwoc3RydWN0IGhvc3QxeF9jaGFubmVsICpjaCwg dm9pZCAqZGF0YSwgYm9vbCBzaG93X2ZpZm8pCj4+Pj4gICBzdGF0aWMgdm9pZCBzaG93X3N5bmNw dHMoc3RydWN0IGhvc3QxeCAqbSwgc3RydWN0IG91dHB1dCAqbykKPj4+PiAgIHsKPj4+PiArCXN0 cnVjdCBsaXN0X2hlYWQgKnBvczsKPj4+PiAgIAl1bnNpZ25lZCBpbnQgaTsKPj4+PiAgIAlob3N0 MXhfZGVidWdfb3V0cHV0KG8sICItLS0tIHN5bmNwdHMgLS0tLVxuIik7Cj4+Pj4gQEAgLTc2LDEy ICs3NywxOSBAQCBzdGF0aWMgdm9pZCBzaG93X3N5bmNwdHMoc3RydWN0IGhvc3QxeCAqbSwgc3Ry dWN0IG91dHB1dCAqbykKPj4+PiAgIAlmb3IgKGkgPSAwOyBpIDwgaG9zdDF4X3N5bmNwdF9uYl9w dHMobSk7IGkrKykgewo+Pj4+ICAgCQl1MzIgbWF4ID0gaG9zdDF4X3N5bmNwdF9yZWFkX21heCht LT5zeW5jcHQgKyBpKTsKPj4+PiAgIAkJdTMyIG1pbiA9IGhvc3QxeF9zeW5jcHRfbG9hZChtLT5z eW5jcHQgKyBpKTsKPj4+PiArCQl1bnNpZ25lZCBpbnQgd2FpdGVycyA9IDA7Cj4+Pj4gLQkJaWYg KCFtaW4gJiYgIW1heCkKPj4+PiArCQlzcGluX2xvY2soJm0tPnN5bmNwdFtpXS5pbnRyLmxvY2sp Owo+Pj4+ICsJCWxpc3RfZm9yX2VhY2gocG9zLCAmbS0+c3luY3B0W2ldLmludHIud2FpdF9oZWFk KQo+Pj4+ICsJCQl3YWl0ZXJzKys7Cj4+Pj4gKwkJc3Bpbl91bmxvY2soJm0tPnN5bmNwdFtpXS5p bnRyLmxvY2spOwo+Pj4KPj4+IFdvdWxkIGl0IG1ha2Ugc2Vuc2UgdG8ga2VlcCBhIHJ1bm5pbmcg Y291bnQgc28gdGhhdCB3ZSBkb24ndCBoYXZlIHRvCj4+PiBjb21wdXRlIGl0IGhlcmU/Cj4+Cj4+ IENvbnNpZGVyaW5nIHRoaXMgaXMganVzdCBhIGRlYnVnIGZhY2lsaXR5LCBJIHRoaW5rIEkgcHJl ZmVyIG5vdCBhZGRpbmcgYSBuZXcKPj4gZmllbGQganVzdCBmb3IgaXQuCj4gCj4gVGhpcyBsb29r cyBsaWtlIElSUS1kaXNhYmxlZCByZWdpb24sIHNvIHVubGVzcyBvbmx5IHJvb3QgY2FuIHRyaWdn ZXIKPiB0aGlzIGNvZGUsIG1heWJlIHRoZSBhZGRpdGlvbmFsIGZpZWxkIGNvdWxkIHNhdmUgYSBw b3RlbnRpYWwgaGVhZGFjaGU/Cj4gSG93IG1hbnkgd2FpdGVycyBjYW4gdGhlcmUgYmUgaW4gdGhl IHdvcnN0IGNhc2U/CgpUaGUgaG9zdDF4J3MgSVJRIGhhbmRsZXIgcnVucyBpbiBhIHdvcmtxdWV1 ZSwgc28gaXQgc2hvdWxkIGJlIG9rYXkuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK