From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Subject: Re: [Qemu-devel] [PATCH v3 3/5] mc146818rtc: ensure LOST_TICK_POLICY_SLEW is only enabled on TARGET_I386 Date: Sat, 13 May 2017 19:13:03 -0300 Message-ID: <7644bdee-2e57-958e-ecd1-abbac0009a18@amsat.org> References: <20170510083259.3900-1-xiaoguangrong@tencent.com> <20170510083259.3900-4-xiaoguangrong@tencent.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Cc: Xiao Guangrong , yunfangtai@tencent.com, qemu-devel@nongnu.org, kvm@vger.kernel.org To: guangrong.xiao@gmail.com, pbonzini@redhat.com, mst@redhat.com, mtosatti@redhat.com Return-path: Received: from mail-qk0-f195.google.com ([209.85.220.195]:35968 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755828AbdEMWNI (ORCPT ); Sat, 13 May 2017 18:13:08 -0400 Received: by mail-qk0-f195.google.com with SMTP id y128so12396263qka.3 for ; Sat, 13 May 2017 15:13:07 -0700 (PDT) In-Reply-To: <20170510083259.3900-4-xiaoguangrong@tencent.com> Sender: kvm-owner@vger.kernel.org List-ID: On 05/10/2017 05:32 AM, guangrong.xiao@gmail.com wrote: > From: Xiao Guangrong > > Any tick policy specified on other platforms rather on TARGET_I386 > will fall back to LOST_TICK_POLICY_DISCARD silently, this patch makes > sure only TARGET_I386 can enable LOST_TICK_POLICY_SLEW > > After that, we can enable LOST_TICK_POLICY_SLEW in the common code > which need not use '#ifdef TARGET_I386' to make these code be x86 > specific anymore > > Signed-off-by: Xiao Guangrong Reviewed-by: Philippe Mathieu-Daudé > --- > hw/timer/mc146818rtc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c > index dac6744..9810bd5 100644 > --- a/hw/timer/mc146818rtc.c > +++ b/hw/timer/mc146818rtc.c > @@ -980,19 +980,19 @@ static void rtc_realizefn(DeviceState *dev, Error **errp) > > rtc_set_date_from_host(isadev); > > -#ifdef TARGET_I386 > switch (s->lost_tick_policy) { > +#ifdef TARGET_I386 > case LOST_TICK_POLICY_SLEW: > s->coalesced_timer = > timer_new_ns(rtc_clock, rtc_coalesced_timer, s); > break; > +#endif > case LOST_TICK_POLICY_DISCARD: > break; > default: > error_setg(errp, "Invalid lost tick policy."); > return; > } > -#endif > > s->periodic_timer = timer_new_ns(rtc_clock, rtc_periodic_timer, s); > s->update_timer = timer_new_ns(rtc_clock, rtc_update_timer, s); >