From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kever Yang Subject: Re: [PATCH 1/3] ram: rk3399: Drop debug stride in driver Date: Sat, 18 Jul 2020 20:14:03 +0800 Message-ID: <7656abeb-35d4-1553-c0d7-8566323d7cb0@rock-chips.com> References: <20200713200635.651032-1-jagan@amarulasolutions.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200713200635.651032-1-jagan@amarulasolutions.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" To: Jagan Teki , Philipp Tomsich , Simon Glass Cc: Suniel Mahesh , U-Boot-Denx , linux-rockchip@lists.infradead.org, linux-amarula List-Id: linux-rockchip.vger.kernel.org On 2020/7/14 上午4:06, Jagan Teki wrote: > stride debug is already present in sdram_common.c via > RAM_ROCKCHIP_DEBUG. > > So, drop the redundant debug stride code in rk3399 driver. > > Signed-off-by: Jagan Teki Reviewed-by: Kever Yang Thanks, - Kever > --- > drivers/ram/rockchip/sdram_rk3399.c | 25 ------------------------- > 1 file changed, 25 deletions(-) > > diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c > index 60a1ab8b51..d2f3fde236 100644 > --- a/drivers/ram/rockchip/sdram_rk3399.c > +++ b/drivers/ram/rockchip/sdram_rk3399.c > @@ -2875,31 +2875,6 @@ static unsigned char calculate_stride(struct rk3399_sdram_params *params) > if (stride == (-1)) > goto error; > } > - switch (stride) { > - case 0xc: > - printf("128B stride\n"); > - break; > - case 5: > - case 9: > - case 0xd: > - case 0x11: > - case 0x19: > - printf("256B stride\n"); > - break; > - case 0xa: > - case 0xe: > - case 0x12: > - printf("512B stride\n"); > - break; > - case 0xf: > - printf("4K stride\n"); > - break; > - case 0x1f: > - printf("32MB + 256B stride\n"); > - break; > - default: > - printf("no stride\n"); > - } > > sdram_print_stride(stride); > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kever Yang Date: Sat, 18 Jul 2020 20:14:03 +0800 Subject: [PATCH 1/3] ram: rk3399: Drop debug stride in driver In-Reply-To: <20200713200635.651032-1-jagan@amarulasolutions.com> References: <20200713200635.651032-1-jagan@amarulasolutions.com> Message-ID: <7656abeb-35d4-1553-c0d7-8566323d7cb0@rock-chips.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 2020/7/14 ??4:06, Jagan Teki wrote: > stride debug is already present in sdram_common.c via > RAM_ROCKCHIP_DEBUG. > > So, drop the redundant debug stride code in rk3399 driver. > > Signed-off-by: Jagan Teki Reviewed-by: Kever Yang Thanks, - Kever > --- > drivers/ram/rockchip/sdram_rk3399.c | 25 ------------------------- > 1 file changed, 25 deletions(-) > > diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c > index 60a1ab8b51..d2f3fde236 100644 > --- a/drivers/ram/rockchip/sdram_rk3399.c > +++ b/drivers/ram/rockchip/sdram_rk3399.c > @@ -2875,31 +2875,6 @@ static unsigned char calculate_stride(struct rk3399_sdram_params *params) > if (stride == (-1)) > goto error; > } > - switch (stride) { > - case 0xc: > - printf("128B stride\n"); > - break; > - case 5: > - case 9: > - case 0xd: > - case 0x11: > - case 0x19: > - printf("256B stride\n"); > - break; > - case 0xa: > - case 0xe: > - case 0x12: > - printf("512B stride\n"); > - break; > - case 0xf: > - printf("4K stride\n"); > - break; > - case 0x1f: > - printf("32MB + 256B stride\n"); > - break; > - default: > - printf("no stride\n"); > - } > > sdram_print_stride(stride); >