All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>,
	davem@davemloft.net, netdev@vger.kernel.org
Cc: andrew@lunn.ch, hkallweit1@gmail.com
Subject: Re: [PATCH] net: phy: bcm54xx: Encode link speed and activity into LEDs
Date: Sat, 23 Mar 2019 18:27:14 -0700	[thread overview]
Message-ID: <765ba7b1-6130-4c36-ed0c-a04a190d15fa@gmail.com> (raw)
In-Reply-To: <20190323221846.1905-1-olteanv@gmail.com>



On 3/23/2019 3:18 PM, Vladimir Oltean wrote:
> Previously the green and amber LEDs on this quad PHY were solid, to
> indicate an encoding of the link speed (10/100/1000).
> 
> This keeps the LEDs always on just as before, but now they flash on
> Rx/Tx activity.
> 

We should probably revamp the whole way the PHY drivers configure LEDs
and come up with a number of standard LED encoding properties in Device
Tree to describe the different possible scenarios, but until we get there:

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

  reply	other threads:[~2019-03-24  1:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-23 22:18 [PATCH] net: phy: bcm54xx: Encode link speed and activity into LEDs Vladimir Oltean
2019-03-24  1:27 ` Florian Fainelli [this message]
2019-03-26 18:24 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=765ba7b1-6130-4c36-ed0c-a04a190d15fa@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.