All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <yujie.liu@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 2/9] Remove bdi_congested() and wb_congested() and related functions
Date: Fri, 28 Jan 2022 14:48:09 +0800	[thread overview]
Message-ID: <7666fc07-58aa-41d5-a7ef-6c371c6acd3a@intel.com> (raw)
In-Reply-To: <202201272132.s3GTQRtU-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 3844 bytes --]

Hi NeilBrown,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on jaegeuk-f2fs/dev-test]
[also build test WARNING on trondmy-nfs/linux-next linus/master hnaz-mm/master v5.17-rc1 next-20220127]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/NeilBrown/Remove-remaining-parts-of-congestions-tracking-code/20220127-105051
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
config: alpha-randconfig-s031-20220125 (https://download.01.org/0day-ci/archive/20220127/202201272132.s3GTQRtU-lkp(a)intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce:
         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
         chmod +x ~/bin/make.cross
         # apt-get install sparse
         # sparse version: v0.6.4-dirty
         # https://github.com/0day-ci/linux/commit/4e63f49027815bc4037227b6d091210c86009e7a
         git remote add linux-review https://github.com/0day-ci/linux
         git fetch --no-tags linux-review NeilBrown/Remove-remaining-parts-of-congestions-tracking-code/20220127-105051
         git checkout 4e63f49027815bc4037227b6d091210c86009e7a
         # save the config file to linux build tree
         mkdir build_dir
         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=alpha SHELL=/bin/bash fs/nilfs2/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <yujie.liu@intel.com>


sparse warnings: (new ones prefixed by >>)
 >> fs/nilfs2/segbuf.c:358:2: sparse: sparse: unused label 'failed'

vim +/failed +358 fs/nilfs2/segbuf.c

64b5a32e0b3680 Ryusuke Konishi    2009-04-06  338
9284ad2a9016ad Ryusuke Konishi    2009-11-25  339  static int nilfs_segbuf_submit_bio(struct nilfs_segment_buffer *segbuf,
b2d4586627ad26 Mike Christie      2016-06-05  340  				   struct nilfs_write_info *wi, int mode,
b2d4586627ad26 Mike Christie      2016-06-05  341  				   int mode_flags)
64b5a32e0b3680 Ryusuke Konishi    2009-04-06  342  {
64b5a32e0b3680 Ryusuke Konishi    2009-04-06  343  	struct bio *bio = wi->bio;
64b5a32e0b3680 Ryusuke Konishi    2009-04-06  344  	int err;
64b5a32e0b3680 Ryusuke Konishi    2009-04-06  345
64b5a32e0b3680 Ryusuke Konishi    2009-04-06  346  	bio->bi_end_io = nilfs_end_bio_write;
9284ad2a9016ad Ryusuke Konishi    2009-11-25  347  	bio->bi_private = segbuf;
b2d4586627ad26 Mike Christie      2016-06-05  348  	bio_set_op_attrs(bio, mode, mode_flags);
4e49ea4a3d2763 Mike Christie      2016-06-05  349  	submit_bio(bio);
4bf93b50fd0411 Vyacheslav Dubeyko 2013-08-22  350  	segbuf->sb_nbio++;
64b5a32e0b3680 Ryusuke Konishi    2009-04-06  351
64b5a32e0b3680 Ryusuke Konishi    2009-04-06  352  	wi->bio = NULL;
64b5a32e0b3680 Ryusuke Konishi    2009-04-06  353  	wi->rest_blocks -= wi->end - wi->start;
64b5a32e0b3680 Ryusuke Konishi    2009-04-06  354  	wi->nr_vecs = min(wi->max_pages, wi->rest_blocks);
64b5a32e0b3680 Ryusuke Konishi    2009-04-06  355  	wi->start = wi->end;
64b5a32e0b3680 Ryusuke Konishi    2009-04-06  356  	return 0;
64b5a32e0b3680 Ryusuke Konishi    2009-04-06  357
64b5a32e0b3680 Ryusuke Konishi    2009-04-06 @358   failed:
64b5a32e0b3680 Ryusuke Konishi    2009-04-06  359  	wi->bio = NULL;
64b5a32e0b3680 Ryusuke Konishi    2009-04-06  360  	return err;
64b5a32e0b3680 Ryusuke Konishi    2009-04-06  361  }
64b5a32e0b3680 Ryusuke Konishi    2009-04-06  362

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

  reply	other threads:[~2022-01-28  6:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-27 14:00 [PATCH 2/9] Remove bdi_congested() and wb_congested() and related functions kernel test robot
2022-01-28  6:48 ` kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-01-27 19:08 kernel test robot
2022-01-27  2:46 [PATCH 0/9] Remove remaining parts of congestions tracking code NeilBrown
2022-01-27  2:46 ` [PATCH 2/9] Remove bdi_congested() and wb_congested() and related functions NeilBrown
2022-01-27  9:54   ` kernel test robot
2022-01-27  9:54     ` kernel test robot
2022-01-27 22:10   ` Ryusuke Konishi
2022-01-27 22:10     ` Ryusuke Konishi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7666fc07-58aa-41d5-a7ef-6c371c6acd3a@intel.com \
    --to=yujie.liu@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.