Re: [PATCH RFT] hwmon: (nct6755) Add support for NCT6799D

[Sebastian Arnhold <sebastian.arnhold@posteo.de>]

Hello Guenter & friends,

I'm such an idiot! The patch works, of course. I did everything 
correctly and then simply forgot to load the module. :D

Adding "acpi_enforce_resources=lax" is necessary for my system, but then 
it works! Other people on the lm-sensors project report that, too. So 
the driver seems to be working for a first release.

Watching my fanspeeds with the "Vitals" GNOME extension and generating 
fancurves with pwmconfig/fanspeed as we speak! Awesome!

Now we should get it into the Linux kernel for the next release asap. 
I've heard on Phoronix that the driver additions queque for Kernel 6.3 
has now begun. I don't think there would be any negative side effects, 
since the module was based on the datasheet. Some values seem to be off, 
though - I'll attach my "sensors" output.

Thank you all very much! :)
Sebastian


nct6799-isa-0290
Adapter: ISA adapter
in0:                      840.00 mV (min =  +0.00 V, max =  +1.74 V)
in1:                      1000.00 mV (min =  +0.00 V, max =  +0.00 V)  ALARM
in2:                        3.41 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
in3:                        3.33 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
in4:                      992.00 mV (min =  +0.00 V, max =  +0.00 V)  ALARM
in5:                        1.04 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
in6:                      472.00 mV (min =  +0.00 V, max =  +0.00 V)  ALARM
in7:                        3.39 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
in8:                        3.30 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
in9:                        1.66 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
in10:                     560.00 mV (min =  +0.00 V, max =  +0.00 V)  ALARM
in11:                     552.00 mV (min =  +0.00 V, max =  +0.00 V)  ALARM
in12:                       1.05 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
in13:                     216.00 mV (min =  +0.00 V, max =  +0.00 V)  ALARM
in14:                       2.04 V  (min =  +0.00 V, max =  +0.00 V)  ALARM
fan1:                      607 RPM  (min =    0 RPM)
fan2:                        0 RPM  (min =    0 RPM)
fan3:                        0 RPM  (min =    0 RPM)
fan4:                      910 RPM  (min =    0 RPM)
fan5:                      625 RPM  (min =    0 RPM)
fan6:                        0 RPM  (min =    0 RPM)
fan7:                        0 RPM  (min =    0 RPM)
SYSTIN:                    +34.0°C  (high = +80.0°C, hyst = +75.0°C)  
sensor = thermistor
CPUTIN:                    +40.5°C  (high = +80.0°C, hyst = +75.0°C)  
sensor = thermistor
AUXTIN0:                   +61.0°C    sensor = thermistor
AUXTIN1:                   +19.0°C    sensor = thermistor
AUXTIN2:                   +20.0°C    sensor = thermistor
AUXTIN3:                   -62.0°C    sensor = thermistor
PECI Agent 0 Calibration:  +40.5°C
PCH_CHIP_CPU_MAX_TEMP:      +0.0°C
PCH_CHIP_TEMP:              +0.0°C
PCH_CPU_TEMP:               +0.0°C
TSI0_TEMP:                 +50.6°C
intrusion0:               ALARM
intrusion1:               OK
beep_enable:              disabled


Am 04.01.23 um 04:41 schrieb Guenter Roeck:
> On Sat, Dec 31, 2022 at 11:42:57PM +0000, Sebastian Arnhold wrote:
>> I tried to add acpi_enforce_resources=lax, but sadly, it does not solve the
>> problem.
>>
> What do you see in the kernel log after adding that ?
>
> Thanks,
> Guenter
>
>> Maybe Ahmad can help add support for the board?
>>
>> Thanks,
>> Sebastian
>>
>> Am 30.12.22 um 23:58 schrieb Christian Lamparter:
>>> Hi Sebastian,
>>>
>>> On 12/30/22 23:13, Sebastian Arnhold wrote:
>>>> Thank you very much for the patch, Guenter Roeck!
>>>>
>>>> I just compiled it using the mainline Kernel as a basis, but
>>>> "sensors-detect" still claims there are no sensors detected on my
>>>> ASUS TUF GAMING X670E-PLUS WIFI.
>>> Unfortunately, this might be because ASUS has some "new" ideas :/.
>>> See this RFC from Ahmad back from October (Author is in Cc)
>>> for an in-depth view why this is happening:
>>>
>>> https://patchwork.kernel.org/project/linux-hwmon/patch/20221018173428.71080-1-ahmad@khalifa.ws/
>>>
>>>
>>> Regards,
>>> Christian
>>>