Re: [PATCH 1/2] pinctrl: sh-pfc: r8a77990: Add SDHI pins, groups and functions

From: Marek Vasut <marek.vasut@gmail.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-gpio@vger.kernel.org,
	Takeshi Kihara <takeshi.kihara.df@renesas.com>,
	Marek Vasut <marek.vasut+renesas@gmail.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Simon Horman <horms+renesas@verge.net.au>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] pinctrl: sh-pfc: r8a77990: Add SDHI pins, groups and functions
Date: Tue, 6 Nov 2018 12:35:25 +0100	[thread overview]
Message-ID: <76819f63-39fa-3371-9551-fd76faf8baf2@gmail.com> (raw)
In-Reply-To: <20181106111448.5rc3yzfdzuv7w562@ninjato>

On 11/06/2018 12:14 PM, Wolfram Sang wrote:
> 
>>  static const struct {
>> -	struct sh_pfc_pin_group common[123];
>> +	struct sh_pfc_pin_group common[140];
>>  	struct sh_pfc_pin_group automotive[0];
>>  } pinmux_groups = {
> 
> ...
> 
>>  static const struct {
>> -	struct sh_pfc_function common[29];
>> +	struct sh_pfc_function common[32];
>>  	struct sh_pfc_function automotive[0];
>>  } pinmux_functions = {
> 
> 
> It is Geert's call, but maybe those are a seperate patch?

These must be part of this patch, since adding
+		SH_PFC_PIN_GROUP(sdhi0_data1),
entries grows the size of the array. If you were to split this patch,
the PFC driver would break, as the size of the array won't match the
size of the content.

-- 
Best regards,
Marek Vasut