Re: [PATCH] atmodem: add LTE state for AT+CREG

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1426 bytes --]

Hi Slava,

On 09/10/2018 01:26 PM, Slava Monich wrote:
> Hi Anirudh, Denis at al.
> 
>> @@ -669,6 +669,10 @@ const char *registration_status_to_string(int 
>> status)
>>>           return "unknown";
>>>       case NETWORK_REGISTRATION_STATUS_ROAMING:
>>>           return "roaming";
>>> +    case NETWORK_REGISTRATION_STATUS_REGISTERED_EUTRAN:
>>> +        return "registered lte";
>>> +    case NETWORK_REGISTRATION_STATUS_ROAMING_EUTRAN:
>>> +        return "roaming lte";
> 
> What's would be the difference between "roaming lte" and "roaming" (or 
> "registered lte" vs "registered") from the viewpoint of D-Bus API 
> clients? In other words, what would e.g. dialer do differently depending 
> on whether registration status is "registered lte" or just "registered"? 
> Is it worth the API break? The existing clients won't know how to handle 
> the new values until they (clients) get updated.
> 

I agree.  That is why I suggested a separate Property for this (and the 
CSFB case from 27.007) instead of modifying the Status property directly.

E.g. REGISTERED_SMS_EUTRAN would map to Status="registered" and 
SmsOnly=False.  ROAMING_SMS_EUTRAN would map to Status="roaming" and 
SmsOnly=True.

I assume that the Dialer can ignore this as the modem will fall back to 
3G in case of a call?  Someone feel free to educate me.

Regards,
-Denis