All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca@lucaceresoli.net>
To: u-boot@lists.denx.de
Subject: [PATCH] arm64: zynqmp: Support converting pm_cfg_obj.c
Date: Tue, 23 Jun 2020 17:17:52 +0200	[thread overview]
Message-ID: <768855ce-6ed4-8272-dc20-48003e50ad70@lucaceresoli.net> (raw)
In-Reply-To: <20200622204531.11301-1-brandon.maier@rockwellcollins.com>

Hi Brandon,

On 22/06/20 22:45, Brandon Maier wrote:
> To use CONFIG_ZYNQMP_SPL_PM_CFG_OBJ_FILE, a developer must pull down the
> U-Boot source and run ./tools/zynqmp_pm_cfg_obj_convert.py to convert
> their pm_cfg_obj.c into U-Boot's PMU loader format, then feed that file
> back to U-Boot during build.
>
> Instead, by doing the conversion in U-Boot during the build, we can
> simplify the developer's build system. And it ensures that if
> zynqmp_pm_cfg_obj_convert.py is updated, the pm_cfg_obj will stay in
> sync with U-Boot.

In the workflows I have used so far U-Boot tools are extracted in a
different step w.r.t. U-Boot cross-compilation, so I never felt the need
for this feature. But I understand this feature can be handy.

The code looks OK too.

Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>

-- 
Luca

  reply	other threads:[~2020-06-23 15:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-22 20:45 [PATCH] arm64: zynqmp: Support converting pm_cfg_obj.c Brandon Maier
2020-06-23 15:17 ` Luca Ceresoli [this message]
     [not found]   ` <CA+fik50_-6oRQTY0MdXacg=LHoKtjkBTQ+MYgK4VptDy5Njygg@mail.gmail.com>
2020-06-23 21:22     ` Fwd: " Brandon Maier
2020-06-23 21:23     ` Luca Ceresoli
2020-06-23 21:31       ` Luca Ceresoli
2020-06-23 21:46         ` [External] " Brandon Maier
2020-06-24  6:49           ` Michal Simek
2020-06-23 16:08 ` Michal Simek
     [not found]   ` <CA+fik51z3vVQDs23Yu7i164vzCQfJz_4jOa_k4nsY58edDHYYw@mail.gmail.com>
2020-06-23 21:23     ` Fwd: " Brandon Maier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=768855ce-6ed4-8272-dc20-48003e50ad70@lucaceresoli.net \
    --to=luca@lucaceresoli.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.