Re: [PATCH][kvm-unit-test VMX]: Use #define for bit# 1 in GUEST_RFLAGS

From: Paolo Bonzini <pbonzini@redhat.com>
To: Krish Sadhukhan <krish.sadhukhan@oracle.com>, kvm@vger.kernel.org
Cc: rkrcmar@redhat.com
Subject: Re: [PATCH][kvm-unit-test VMX]: Use #define for bit# 1 in GUEST_RFLAGS
Date: Tue, 10 Dec 2019 18:12:12 +0100	[thread overview]
Message-ID: <7688f358-c8e9-4ef0-cf6a-12be85155616@redhat.com> (raw)
In-Reply-To: <20190328023246.12087-1-krish.sadhukhan@oracle.com>

On 28/03/19 03:32, Krish Sadhukhan wrote:
> Signed-off-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
> Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
> 
> ---
>  x86/vmx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/x86/vmx.c b/x86/vmx.c
> index 6ba56bc..d1a0da8 100644
> --- a/x86/vmx.c
> +++ b/x86/vmx.c
> @@ -1193,7 +1193,7 @@ static void init_vmcs_guest(void)
>  	/* 26.3.1.4 */
>  	vmcs_write(GUEST_RIP, (u64)(&guest_entry));
>  	vmcs_write(GUEST_RSP, (u64)(guest_stack + PAGE_SIZE - 1));
> -	vmcs_write(GUEST_RFLAGS, 0x2);
> +	vmcs_write(GUEST_RFLAGS, X86_EFLAGS_FIXED);
>  
>  	/* 26.3.1.5 */
>  	vmcs_write(GUEST_ACTV_STATE, ACTV_ACTIVE);
> @@ -1705,7 +1705,7 @@ static int test_run(struct vmx_test *test)
>  	test->exits = 0;
>  	current = test;
>  	regs = test->guest_regs;
> -	vmcs_write(GUEST_RFLAGS, regs.rflags | 0x2);
> +	vmcs_write(GUEST_RFLAGS, regs.rflags | X86_EFLAGS_FIXED);
>  	launched = 0;
>  	guest_finished = 0;
>  	printf("\nTest suite: %s\n", test->name);
> 

Applied, better late than never...

Paolo