From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90967C48BE6 for ; Wed, 16 Jun 2021 18:52:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E99F613B4 for ; Wed, 16 Jun 2021 18:52:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E99F613B4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ltaeT-0003pa-HB for qemu-devel@archiver.kernel.org; Wed, 16 Jun 2021 14:52:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45606) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltacN-0001yw-NS for qemu-devel@nongnu.org; Wed, 16 Jun 2021 14:50:27 -0400 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]:39782) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ltacK-0000n0-Oo for qemu-devel@nongnu.org; Wed, 16 Jun 2021 14:50:27 -0400 Received: by mail-pj1-x1034.google.com with SMTP id o88-20020a17090a0a61b029016eeb2adf66so4366473pjo.4 for ; Wed, 16 Jun 2021 11:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4mE13WGFzO6pilOTGTWR0QI3ypfChUaCFHC9H69ijbg=; b=e7itFNAS8N3wA4GoPxakgBSTslq6BUsxS76aDq84HsvK+uioWX1Wb8YZvf2ZJYoSFL 0Gzi4p8p1SGj7qTIGZ6yk0Wl8HbNqWFxPNeaxj6Cce7K6iOXt4YeOOrOSZyCHXbDTA4w Tv0ar1giyLgD+WxKVS8Etv59tFlb+vUOpbn/Ojl3Snr3UFyCXGoxJnhygA+zXUCDjS89 K5gji7NvDp5olhLYR7xfiosgtz/srfaOd/zyGZm0U7/Pc/WkwY55I3NgmSh9CJzMSrT+ acFcF2R49XkHgZIGy0nZqLVRMaXdbSVs1w8jtLu9pMc04pWS+bo/2vLKfNOHVzEKfmfQ NkvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4mE13WGFzO6pilOTGTWR0QI3ypfChUaCFHC9H69ijbg=; b=aaMVxFt2NxnBFKm4XiOcwT+v/mDC3MnNGOWGSzEz7gDgTLFz2NQ7zGWVNspt2u8AdU vtHK9ReI+XlvT7vMQs6OGgVPmxrfzkvUp2LbV/Bff7AAnN1hDwZ+JL66+2wEyfeII0+f iyAIO5myM9ofjofwPKMFSvMXclBD33G1oZcq9EC8FO4bjnBVuV5yjwUvK39OPr45kMrq E3bzA+NQE1wVi290v9cx7Ltr/Lc6tTfv7nG9//KjRKfkR79m7klNmebXa9GG754vfHNf kPVOXXlXR8hPjy/OvvwVmC3dRPmfvZwznqeBD4TVGOWs5VP27Y1rbHZzi4jZwNzDU0wy A1Hw== X-Gm-Message-State: AOAM531JadgItP7GL66GSa5IwSfX8Kk1khX5abJAxh1x0i/oUZF0GV77 GBUsFLCzdOZ2gG52RdXLLFvtzA== X-Google-Smtp-Source: ABdhPJy5k95AQSOlZIuTumhYkJ5+2zfl+RCQmRpOiBBj2u72rTOR62iyugw9eNfKPBC9QElASO7DLg== X-Received: by 2002:a17:902:b218:b029:11a:bf7b:1a80 with SMTP id t24-20020a170902b218b029011abf7b1a80mr878623plr.82.1623869423251; Wed, 16 Jun 2021 11:50:23 -0700 (PDT) Received: from [192.168.1.11] (174-21-70-228.tukw.qwest.net. [174.21.70.228]) by smtp.gmail.com with ESMTPSA id v8sm2810676pff.34.2021.06.16.11.50.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jun 2021 11:50:22 -0700 (PDT) Subject: Re: [PATCH v3 12/13] hw/i2c: Rename i2c_set_slave_address() -> i2c_slave_set_address() To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210616161418.2514095-1-f4bug@amsat.org> <20210616161418.2514095-13-f4bug@amsat.org> From: Richard Henderson Message-ID: <7691838b-df33-2179-0c5c-4209312426e4@linaro.org> Date: Wed, 16 Jun 2021 11:50:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210616161418.2514095-13-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1034; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1034.google.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.17, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , "Signed-off-by : Frederic Konrad" , qemu-arm@nongnu.org, qemu-ppc@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/16/21 9:14 AM, Philippe Mathieu-Daudé wrote: > Other functions from I2C slave API are named "i2c_slave_XXX()". > Follow that pattern with set_address(). Add docstring along. > No logical change. > > Patch created mechanically using: > > $ sed -i s/i2c_set_slave_address/i2c_slave_set_address/ \ > $(git grep -l i2c_set_slave_address) > > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-by: Richard Henderson r~