Re: [PATCH 1/5] mm: Initialize lowmem virq when boot-time scrubbing is disabled

From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: tim@xen.org, sstabellini@kernel.org, wei.liu2@citrix.com,
	George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
	ian.jackson@eu.citrix.com, xen-devel@lists.xen.org,
	Julien Grall <julien.grall@arm.com>
Subject: Re: [PATCH 1/5] mm: Initialize lowmem virq when boot-time scrubbing is disabled
Date: Wed, 30 Aug 2017 09:02:12 -0400	[thread overview]
Message-ID: <7691a136-bee9-9198-173f-0cbe52bd8aa0@oracle.com> (raw)
In-Reply-To: <59A6989102000078001756C7@prv-mh.provo.novell.com>

On 08/30/2017 04:50 AM, Jan Beulich wrote:
>>>> On 29.08.17 at 19:09, <boris.ostrovsky@oracle.com> wrote:
>> @@ -1970,12 +1970,15 @@ void __init scrub_heap_pages(void)
>>  #ifdef CONFIG_SCRUB_DEBUG
>>      boot_scrub_done = true;
>>  #endif
>> +}
>>  
>> -    /* Now that the heap is initialized, run checks and set bounds
>> -     * for the low mem virq algorithm. */
>> +void __init heap_init_late(void)
>> +{
>>      setup_low_mem_virq();
>> -}
>>  
>> +    if ( opt_bootscrub )
>> +        scrub_heap_pages();
>> +}
> Any reason you fully remove that comment? I think the "run checks"
> part is stale (if it was ever valid in the first place), but the rest
> could more or less stay.

I thought it was pretty clear from the routine's name what it is about
to do so I dropped it. I can put it back if you feel it is still needed.

-boris

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel