From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Cleber Rosa <crosa@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH v6 7/9] iotests: ignore import warnings from pylint
Date: Wed, 4 Mar 2020 01:02:58 +0100 [thread overview]
Message-ID: <76a0567c-9f96-7b55-8a25-ee0933d796a0@redhat.com> (raw)
In-Reply-To: <590ac875-bf9d-afbc-e029-f66050d33344@redhat.com>
On 3/3/20 8:57 PM, John Snow wrote:
> On 2/27/20 9:14 AM, Philippe Mathieu-Daudé wrote:
>> On 2/27/20 1:06 AM, John Snow wrote:
>>> The right way to solve this is to come up with a virtual environment
>>> infrastructure that sets all the paths correctly, and/or to create
>>> installable python modules that can be imported normally.
>>>
>>> That's hard, so just silence this error for now.
>>
>> I'm tempted to NAck this and require an "installable python module"...
>>
>> Let's discuss why it is that hard!
>>
>
> I've been tricked into this before. It's not work I am interested in
> doing right now; it's WAY beyond the scope of what I am doing here.
>
> It involves properly factoring all of our python code, deciding which
> portions are meant to be installed separately from QEMU itself, coming
> up with a versioning scheme, packaging code, and moving code around in
> many places.
>
> Then it involves coming up with tooling and infrastructure for creating
> virtual environments, installing the right packages to it, and using it
> to run our python tests.
>
> No, that's way too invasive. I'm not doing it and I will scream loudly
> if you make me.
>
> A less invasive hack involves setting the python import path in a
> consolidated spot so that python knows where it can import from. This
> works, but might break the ability to run such tests as one-offs without
> executing the environment setup.
>
> Again, not work I care to do right now and so I won't. The benefit of
> these patches is to provide some minimum viable CI CQA for Python where
> we had none before, NOT fix every possible Python problem in one shot.
OK I guess we misunderstood each other :)
I didn't understood your comment as personal to you for this patch, but
generic. It makes sense it is not your priority and it is obvious this
task will take a single developer a lot of time resources. I am
certainly NOT asking you to do it.
My question was rather community-oriented.
(Cc'ing Eduardo because we talked about this after the last KVM forum).
>
> --js
>
>>>
>>> Signed-off-by: John Snow <jsnow@redhat.com>
>>> ---
>>> tests/qemu-iotests/iotests.py | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/tests/qemu-iotests/iotests.py
>>> b/tests/qemu-iotests/iotests.py
>>> index 60c4c7f736..214f59995e 100644
>>> --- a/tests/qemu-iotests/iotests.py
>>> +++ b/tests/qemu-iotests/iotests.py
>>> @@ -30,6 +30,7 @@
>>> from collections import OrderedDict
>>> from typing import Collection
>>> +# pylint: disable=import-error, wrong-import-position
>>> sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..',
>>> 'python'))
>>> from qemu import qtest
>>>
>>
>
next prev parent reply other threads:[~2020-03-04 0:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 0:06 [PATCH v6 0/9] iotests: use python logging John Snow
2020-02-27 0:06 ` [PATCH v6 1/9] iotests: do a light delinting John Snow
2020-02-27 12:59 ` Max Reitz
2020-03-03 21:25 ` John Snow
2020-03-04 11:12 ` Kevin Wolf
2020-03-04 18:35 ` John Snow
2020-02-27 0:06 ` [PATCH v6 2/9] iotests: add script_initialize John Snow
2020-02-27 13:47 ` Max Reitz
2020-03-03 21:12 ` John Snow
2020-02-27 0:06 ` [PATCH v6 3/9] iotests: replace mutable list default args John Snow
2020-02-27 13:50 ` Max Reitz
2020-02-27 0:06 ` [PATCH v6 4/9] iotest 258: use script_main John Snow
2020-02-27 13:55 ` Max Reitz
2020-02-27 14:10 ` Philippe Mathieu-Daudé
2020-02-27 0:06 ` [PATCH v6 5/9] iotests: Mark verify functions as private John Snow
2020-02-27 13:59 ` Max Reitz
2020-02-27 0:06 ` [PATCH v6 6/9] iotests: use python logging for iotests.log() John Snow
2020-02-27 14:21 ` Max Reitz
2020-03-03 20:00 ` John Snow
2020-02-27 0:06 ` [PATCH v6 7/9] iotests: ignore import warnings from pylint John Snow
2020-02-27 14:14 ` Philippe Mathieu-Daudé
2020-03-03 19:57 ` John Snow
2020-03-04 0:02 ` Philippe Mathieu-Daudé [this message]
2020-03-04 18:59 ` John Snow
2020-02-27 0:06 ` [PATCH v6 8/9] iotests: don't use 'format' for drive_add John Snow
2020-02-27 14:12 ` Philippe Mathieu-Daudé
2020-02-27 14:26 ` Max Reitz
2020-02-27 0:06 ` [PATCH v6 9/9] iotests: add pylintrc file John Snow
2020-02-27 1:57 ` Eric Blake
2020-02-27 14:11 ` Philippe Mathieu-Daudé
2020-03-03 19:52 ` John Snow
2020-03-04 7:22 ` Markus Armbruster
2020-03-04 19:17 ` John Snow
2020-03-05 5:49 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76a0567c-9f96-7b55-8a25-ee0933d796a0@redhat.com \
--to=philmd@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.