[PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

The following changes since commit 05943fb4ca41f626078014c0327781815c6584c5:

  ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)

are available in the Git repository at:

  git@github.com:aik/qemu.git tags/qemu-slof-20200217

for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:

  pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)

----------------------------------------------------------------
Alexey Kardashevskiy (1):
      pseries: Update SLOF firmware image

 pc-bios/README   |   2 +-
 pc-bios/slof.bin | Bin 931032 -> 968560 bytes
 roms/SLOF        |   2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)


*** Note: this is not for master, this is for pseries

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]

On Mon, Feb 17, 2020 at 01:12:17PM +1100, Alexey Kardashevskiy wrote:
> The following changes since commit 05943fb4ca41f626078014c0327781815c6584c5:
> 
>   ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)
> 
> are available in the Git repository at:
> 
>   git@github.com:aik/qemu.git tags/qemu-slof-20200217
> 
> for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:
> 
>   pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
> 
> ----------------------------------------------------------------
> Alexey Kardashevskiy (1):
>       pseries: Update SLOF firmware image
> 
>  pc-bios/README   |   2 +-
>  pc-bios/slof.bin | Bin 931032 -> 968560 bytes
>  roms/SLOF        |   2 +-
>  3 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> *** Note: this is not for master, this is for pseries

Merged to ppc-for-5.0, thanks.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Philippe Mathieu-Daudé]

Hi Alexey,

On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
> The following changes since commit 05943fb4ca41f626078014c0327781815c6584c5:
> 
>    ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)
> 
> are available in the Git repository at:
> 
>    git@github.com:aik/qemu.git tags/qemu-slof-20200217
> 
> for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:
> 
>    pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
> 
> ----------------------------------------------------------------
> Alexey Kardashevskiy (1):
>        pseries: Update SLOF firmware image
> 
>   pc-bios/README   |   2 +-
>   pc-bios/slof.bin | Bin 931032 -> 968560 bytes
>   roms/SLOF        |   2 +-
>   3 files changed, 2 insertions(+), 2 deletions(-)

I only received the cover, not the patch, have you posted it?

I noticed on your repository you included a 'git shortlog' output in the 
commit description, thanks for that detail, much appreciated!

Regards,

Phil.

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Cédric Le Goater]

On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
> The following changes since commit 05943fb4ca41f626078014c0327781815c6584c5:
> 
>   ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)
> 
> are available in the Git repository at:
> 
>   git@github.com:aik/qemu.git tags/qemu-slof-20200217
> 
> for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:
> 
>   pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
> 
> ----------------------------------------------------------------
> Alexey Kardashevskiy (1):
>       pseries: Update SLOF firmware image
> 
>  pc-bios/README   |   2 +-
>  pc-bios/slof.bin | Bin 931032 -> 968560 bytes
>  roms/SLOF        |   2 +-
>  3 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> *** Note: this is not for master, this is for pseries
> 

Hello Alexey,

QEMU fails to boot from disk. See below.

Thanks,

C.


QEMU Starting
 Build Date = Feb 17 2020 13:06:47
 FW Version = git-42228d763f1fdb7b
 Press "s" to enter Open Firmware.

Populating /vdevice methods
Populating /vdevice/vty@71000000
Populating /vdevice/nvram@71000001
Populating /pci@800000020000000
                     00 0800 (D) : 1af4 1004    virtio [ scsi ]
Populating /pci@800000020000000/scsi@1
       SCSI: Looking for devices
          100000000000000 DISK     : "QEMU     QEMU HARDDISK    2.5+"
                     00 1000 (D) : 1af4 1000    virtio [ net ]
                     00 2000 (D) : 1b36 000d    serial bus [ usb-xhci ]
No NVRAM common partition, re-initializing...
Scanning USB 
  XHCI: Initializing
Using default console: /vdevice/vty@71000000
     
  Welcome to Open Firmware

  Copyright (c) 2004, 2017 IBM Corporation All rights reserved.
  This program and the accompanying materials are made available
  under the terms of the BSD License available at
  http://www.opensource.org/licenses/bsd-license.php


Trying to load:  from: /pci@800000020000000/scsi@1/disk@100000000000000 ...  slash SCSI-DISK: Access beyond end of device ! 

Out of internal memory.
SCSI-DISK: Access beyond end of device ! 
SCSI-DISK: Access beyond end of device ! 
SCSI-DISK: Access beyond end of device ! 
SCSI-DISK: Access beyond end of device ! 
SCSI-DISK: Access beyond end of device ! 

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Philippe Mathieu-Daudé]

On 2/17/20 10:26 AM, Philippe Mathieu-Daudé wrote:
> Hi Alexey,
> 
> On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
>> The following changes since commit 
>> 05943fb4ca41f626078014c0327781815c6584c5:
>>
>>    ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)
>>
>> are available in the Git repository at:
>>
>>    git@github.com:aik/qemu.git tags/qemu-slof-20200217
>>
>> for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:
>>
>>    pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
>>
>> ----------------------------------------------------------------
>> Alexey Kardashevskiy (1):
>>        pseries: Update SLOF firmware image
>>
>>   pc-bios/README   |   2 +-
>>   pc-bios/slof.bin | Bin 931032 -> 968560 bytes
>>   roms/SLOF        |   2 +-
>>   3 files changed, 2 insertions(+), 2 deletions(-)
> 
> I only received the cover, not the patch, have you posted it?

OK I see the SLOF binary is almost 1MB. Maybe this got blocked by spam 
filter. FYI you can use 'git-format-patch --no-binary' to emit the patch 
with the commit description but without the content.

> 
> I noticed on your repository you included a 'git shortlog' output in the 
> commit description, thanks for that detail, much appreciated!
> 
> Regards,
> 
> Phil.

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1681 bytes --]

On Mon, Feb 17, 2020 at 11:24:11AM +0100, Philippe Mathieu-Daudé wrote:
> On 2/17/20 10:26 AM, Philippe Mathieu-Daudé wrote:
> > Hi Alexey,
> > 
> > On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
> > > The following changes since commit
> > > 05943fb4ca41f626078014c0327781815c6584c5:
> > > 
> > >    ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)
> > > 
> > > are available in the Git repository at:
> > > 
> > >    git@github.com:aik/qemu.git tags/qemu-slof-20200217
> > > 
> > > for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:
> > > 
> > >    pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
> > > 
> > > ----------------------------------------------------------------
> > > Alexey Kardashevskiy (1):
> > >        pseries: Update SLOF firmware image
> > > 
> > >   pc-bios/README   |   2 +-
> > >   pc-bios/slof.bin | Bin 931032 -> 968560 bytes
> > >   roms/SLOF        |   2 +-
> > >   3 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > I only received the cover, not the patch, have you posted it?
> 
> OK I see the SLOF binary is almost 1MB. Maybe this got blocked by spam
> filter. FYI you can use 'git-format-patch --no-binary' to emit the patch
> with the commit description but without the content.

Generally Alexey sends SLOF updates to me just as pull requests
without patches in full, because a huge slab of base64 encoded
firmware isn't particularly illuminating.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

On 17/02/2020 20:48, Cédric Le Goater wrote:
> On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
>> The following changes since commit 05943fb4ca41f626078014c0327781815c6584c5:
>>
>>   ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)
>>
>> are available in the Git repository at:
>>
>>   git@github.com:aik/qemu.git tags/qemu-slof-20200217
>>
>> for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:
>>
>>   pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
>>
>> ----------------------------------------------------------------
>> Alexey Kardashevskiy (1):
>>       pseries: Update SLOF firmware image
>>
>>  pc-bios/README   |   2 +-
>>  pc-bios/slof.bin | Bin 931032 -> 968560 bytes
>>  roms/SLOF        |   2 +-
>>  3 files changed, 2 insertions(+), 2 deletions(-)
>>
>>
>> *** Note: this is not for master, this is for pseries
>>
> 
> Hello Alexey,
> 
> QEMU fails to boot from disk. See below.


It does boot mine (fedora 30, ubuntu 18.04), see below. I believe I
could have broken something but I need more detail. Thanks,




SLOF **********************************************************************
QEMU Starting
 Build Date = Feb 17 2020 13:06:47
 FW Version = git-42228d763f1fdb7b
 Press "s" to enter Open Firmware.

Populating /vdevice methods
Populating /vdevice/nvram@71000000
Populating /vdevice/vty@71000110
Populating /pci@800000020000000
                     00 0000 (D) : 1af4 1000    virtio [ net ]
                     00 0800 (D) : 1af4 1004    virtio [ scsi ]
Populating /pci@800000020000000/scsi@1
       SCSI: Looking for devices
          100000000000000 DISK     : "QEMU     QEMU HARDDISK    2.5+"
No NVRAM common partition, re-initializing...
Scanning USB
Using default console: /vdevice/vty@71000110

  Welcome to Open Firmware

  Copyright (c) 2004, 2017 IBM Corporation All rights reserved.
  This program and the accompanying materials are made available
  under the terms of the BSD License available at
  http://www.opensource.org/licenses/bsd-license.php


Trying to load:  from: /pci@800000020000000/scsi@1/disk@100000000000000
...   Successfully loaded






      Fedora (5.5.0-rc5-le-guest_v5.5-rc5_a+fstn1) 30 (Thirty)

      Fedora (5.0.9-301.fc30.ppc64le) 30 (Thirty)

      Fedora (0-rescue-8f8bbec520a44fd09da6af8e0d2c6571) 30 (Thirty)




> 
> Thanks,
> 
> C.
> 
> 
> QEMU Starting
>  Build Date = Feb 17 2020 13:06:47
>  FW Version = git-42228d763f1fdb7b
>  Press "s" to enter Open Firmware.
> 
> Populating /vdevice methods
> Populating /vdevice/vty@71000000
> Populating /vdevice/nvram@71000001
> Populating /pci@800000020000000
>                      00 0800 (D) : 1af4 1004    virtio [ scsi ]
> Populating /pci@800000020000000/scsi@1
>        SCSI: Looking for devices
>           100000000000000 DISK     : "QEMU     QEMU HARDDISK    2.5+"
>                      00 1000 (D) : 1af4 1000    virtio [ net ]
>                      00 2000 (D) : 1b36 000d    serial bus [ usb-xhci ]
> No NVRAM common partition, re-initializing...
> Scanning USB 
>   XHCI: Initializing
> Using default console: /vdevice/vty@71000000
>      
>   Welcome to Open Firmware
> 
>   Copyright (c) 2004, 2017 IBM Corporation All rights reserved.
>   This program and the accompanying materials are made available
>   under the terms of the BSD License available at
>   http://www.opensource.org/licenses/bsd-license.php
> 
> 
> Trying to load:  from: /pci@800000020000000/scsi@1/disk@100000000000000 ...  slash SCSI-DISK: Access beyond end of device ! 
> 
> Out of internal memory.
> SCSI-DISK: Access beyond end of device ! 
> SCSI-DISK: Access beyond end of device ! 
> SCSI-DISK: Access beyond end of device ! 
> SCSI-DISK: Access beyond end of device ! 
> SCSI-DISK: Access beyond end of device ! 
> 

-- 
Alexey

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

On 17/02/2020 20:26, Philippe Mathieu-Daudé wrote:
> Hi Alexey,
> 
> On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
>> The following changes since commit
>> 05943fb4ca41f626078014c0327781815c6584c5:
>>
>>    ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)
>>
>> are available in the Git repository at:
>>
>>    git@github.com:aik/qemu.git tags/qemu-slof-20200217
>>
>> for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:
>>
>>    pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
>>
>> ----------------------------------------------------------------
>> Alexey Kardashevskiy (1):
>>        pseries: Update SLOF firmware image
>>
>>   pc-bios/README   |   2 +-
>>   pc-bios/slof.bin | Bin 931032 -> 968560 bytes
>>   roms/SLOF        |   2 +-
>>   3 files changed, 2 insertions(+), 2 deletions(-)
> 
> I only received the cover, not the patch, have you posted it?

No, for quite some time now - it is too big and does not pass some
filters somewhere so rather than fixing filters, I simply send pull
requests instead.


> 
> I noticed on your repository you included a 'git shortlog' output in the
> commit description, thanks for that detail, much appreciated!

I was asked nicely to do so :)

> 
> Regards,
> 
> Phil.
> 

-- 
Alexey

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Philippe Mathieu-Daudé]

On 2/17/20 11:46 PM, David Gibson wrote:
> On Mon, Feb 17, 2020 at 11:24:11AM +0100, Philippe Mathieu-Daudé wrote:
>> On 2/17/20 10:26 AM, Philippe Mathieu-Daudé wrote:
>>> Hi Alexey,
>>>
>>> On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
>>>> The following changes since commit
>>>> 05943fb4ca41f626078014c0327781815c6584c5:
>>>>
>>>>     ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>>     git@github.com:aik/qemu.git tags/qemu-slof-20200217
>>>>
>>>> for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:
>>>>
>>>>     pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
>>>>
>>>> ----------------------------------------------------------------
>>>> Alexey Kardashevskiy (1):
>>>>         pseries: Update SLOF firmware image
>>>>
>>>>    pc-bios/README   |   2 +-
>>>>    pc-bios/slof.bin | Bin 931032 -> 968560 bytes
>>>>    roms/SLOF        |   2 +-
>>>>    3 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> I only received the cover, not the patch, have you posted it?
>>
>> OK I see the SLOF binary is almost 1MB. Maybe this got blocked by spam
>> filter. FYI you can use 'git-format-patch --no-binary' to emit the patch
>> with the commit description but without the content.
> 
> Generally Alexey sends SLOF updates to me just as pull requests
> without patches in full, because a huge slab of base64 encoded
> firmware isn't particularly illuminating.

I understand, this is why I later suggested Alexey to use 
'git-format-patch --no-binary', because Laszlo uses it for EDK2 
submodule, this allow to quickly review the change on the list (without 
posting the base64), see:

https://www.mail-archive.com/qemu-devel@nongnu.org/msg624429.html
(pull-request cover)

https://www.mail-archive.com/qemu-devel@nongnu.org/msg624432.html
"roms/edk2: update submodule"

https://www.mail-archive.com/qemu-devel@nongnu.org/msg624435.html
"pc-bios: refresh edk2 build artifacts"

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Cédric Le Goater]

On 2/18/20 1:30 AM, Alexey Kardashevskiy wrote:
> 
> 
> On 17/02/2020 20:48, Cédric Le Goater wrote:
>> On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
>>> The following changes since commit 05943fb4ca41f626078014c0327781815c6584c5:
>>>
>>>   ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)
>>>
>>> are available in the Git repository at:
>>>
>>>   git@github.com:aik/qemu.git tags/qemu-slof-20200217
>>>
>>> for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:
>>>
>>>   pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
>>>
>>> ----------------------------------------------------------------
>>> Alexey Kardashevskiy (1):
>>>       pseries: Update SLOF firmware image
>>>
>>>  pc-bios/README   |   2 +-
>>>  pc-bios/slof.bin | Bin 931032 -> 968560 bytes
>>>  roms/SLOF        |   2 +-
>>>  3 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>>
>>> *** Note: this is not for master, this is for pseries
>>>
>>
>> Hello Alexey,
>>
>> QEMU fails to boot from disk. See below.
> 
> 
> It does boot mine (fedora 30, ubuntu 18.04), see below. I believe I
> could have broken something but I need more detail. Thanks,

fedora31 boots but not ubuntu 19.10. Could it be GRUB version 2.04 ? 

C.


> 
> 
> 
> 
> SLOF **********************************************************************
> QEMU Starting
>  Build Date = Feb 17 2020 13:06:47
>  FW Version = git-42228d763f1fdb7b
>  Press "s" to enter Open Firmware.
> 
> Populating /vdevice methods
> Populating /vdevice/nvram@71000000
> Populating /vdevice/vty@71000110
> Populating /pci@800000020000000
>                      00 0000 (D) : 1af4 1000    virtio [ net ]
>                      00 0800 (D) : 1af4 1004    virtio [ scsi ]
> Populating /pci@800000020000000/scsi@1
>        SCSI: Looking for devices
>           100000000000000 DISK     : "QEMU     QEMU HARDDISK    2.5+"
> No NVRAM common partition, re-initializing...
> Scanning USB
> Using default console: /vdevice/vty@71000110
> 
>   Welcome to Open Firmware
> 
>   Copyright (c) 2004, 2017 IBM Corporation All rights reserved.
>   This program and the accompanying materials are made available
>   under the terms of the BSD License available at
>   http://www.opensource.org/licenses/bsd-license.php
> 
> 
> Trying to load:  from: /pci@800000020000000/scsi@1/disk@100000000000000
> ...   Successfully loaded
> 
> 
> 
> 
> 
> 
>       Fedora (5.5.0-rc5-le-guest_v5.5-rc5_a+fstn1) 30 (Thirty)
> 
>       Fedora (5.0.9-301.fc30.ppc64le) 30 (Thirty)
> 
>       Fedora (0-rescue-8f8bbec520a44fd09da6af8e0d2c6571) 30 (Thirty)
> 
> 
> 
> 
>>
>> Thanks,
>>
>> C.
>>
>>
>> QEMU Starting
>>  Build Date = Feb 17 2020 13:06:47
>>  FW Version = git-42228d763f1fdb7b
>>  Press "s" to enter Open Firmware.
>>
>> Populating /vdevice methods
>> Populating /vdevice/vty@71000000
>> Populating /vdevice/nvram@71000001
>> Populating /pci@800000020000000
>>                      00 0800 (D) : 1af4 1004    virtio [ scsi ]
>> Populating /pci@800000020000000/scsi@1
>>        SCSI: Looking for devices
>>           100000000000000 DISK     : "QEMU     QEMU HARDDISK    2.5+"
>>                      00 1000 (D) : 1af4 1000    virtio [ net ]
>>                      00 2000 (D) : 1b36 000d    serial bus [ usb-xhci ]
>> No NVRAM common partition, re-initializing...
>> Scanning USB 
>>   XHCI: Initializing
>> Using default console: /vdevice/vty@71000000
>>      
>>   Welcome to Open Firmware
>>
>>   Copyright (c) 2004, 2017 IBM Corporation All rights reserved.
>>   This program and the accompanying materials are made available
>>   under the terms of the BSD License available at
>>   http://www.opensource.org/licenses/bsd-license.php
>>
>>
>> Trying to load:  from: /pci@800000020000000/scsi@1/disk@100000000000000 ...  slash SCSI-DISK: Access beyond end of device ! 
>>
>> Out of internal memory.
>> SCSI-DISK: Access beyond end of device ! 
>> SCSI-DISK: Access beyond end of device ! 
>> SCSI-DISK: Access beyond end of device ! 
>> SCSI-DISK: Access beyond end of device ! 
>> SCSI-DISK: Access beyond end of device ! 
>>
> 

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

On 18/02/2020 18:12, Cédric Le Goater wrote:
> On 2/18/20 1:30 AM, Alexey Kardashevskiy wrote:
>>
>>
>> On 17/02/2020 20:48, Cédric Le Goater wrote:
>>> On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
>>>> The following changes since commit 05943fb4ca41f626078014c0327781815c6584c5:
>>>>
>>>>   ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>>   git@github.com:aik/qemu.git tags/qemu-slof-20200217
>>>>
>>>> for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:
>>>>
>>>>   pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
>>>>
>>>> ----------------------------------------------------------------
>>>> Alexey Kardashevskiy (1):
>>>>       pseries: Update SLOF firmware image
>>>>
>>>>  pc-bios/README   |   2 +-
>>>>  pc-bios/slof.bin | Bin 931032 -> 968560 bytes
>>>>  roms/SLOF        |   2 +-
>>>>  3 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>>
>>>> *** Note: this is not for master, this is for pseries
>>>>
>>>
>>> Hello Alexey,
>>>
>>> QEMU fails to boot from disk. See below.
>>
>>
>> It does boot mine (fedora 30, ubuntu 18.04), see below. I believe I
>> could have broken something but I need more detail. Thanks,
> 
> fedora31 boots but not ubuntu 19.10. Could it be GRUB version 2.04 ? 


No, not that either:

SLOF
**********************************************************************

QEMU Starting

 Build Date = Feb 17 2020 13:06:47

 FW Version = git-42228d763f1fdb7b

 Press "s" to enter Open Firmware.



Populating /vdevice methods

Populating /vdevice/nvram@71000000

Populating /vdevice/vty@71000110

Populating /pci@800000020000000

                     00 0000 (B) : 1b36 0001    pci*

                     01 0000 (D) : 1af4 1002    legacy-device*

                     00 0800 (D) : 1af4 1001    virtio [ block ]

No NVRAM common partition, re-initializing...

Scanning USB

Using default console: /vdevice/vty@71000110



  Welcome to Open Firmware



  Copyright (c) 2004, 2017 IBM Corporation All rights reserved.

  This program and the accompanying materials are made available

  under the terms of the BSD License available at

  http://www.opensource.org/licenses/bsd-license.php





Trying to load:  from: /pci@800000020000000/scsi@1 ...  slash  not found
  Successfully loaded
Welcome to GRUB!



error: no suitable video mode found.



                             GNU GRUB  version 2.04



[...]


Ubuntu 19.10 aiku1910le hvc0

aiku1910le login: aik
Password:
Last login: Tue Feb 18 19:57:46 AEDT 2020 from 10.61.161.111 on pts/0
Welcome to Ubuntu 19.10 (GNU/Linux 5.3.0-40-generic ppc64le)




> 
> C.
> 
> 
>>
>>
>>
>>
>> SLOF **********************************************************************
>> QEMU Starting
>>  Build Date = Feb 17 2020 13:06:47
>>  FW Version = git-42228d763f1fdb7b
>>  Press "s" to enter Open Firmware.
>>
>> Populating /vdevice methods
>> Populating /vdevice/nvram@71000000
>> Populating /vdevice/vty@71000110
>> Populating /pci@800000020000000
>>                      00 0000 (D) : 1af4 1000    virtio [ net ]
>>                      00 0800 (D) : 1af4 1004    virtio [ scsi ]
>> Populating /pci@800000020000000/scsi@1
>>        SCSI: Looking for devices
>>           100000000000000 DISK     : "QEMU     QEMU HARDDISK    2.5+"
>> No NVRAM common partition, re-initializing...
>> Scanning USB
>> Using default console: /vdevice/vty@71000110
>>
>>   Welcome to Open Firmware
>>
>>   Copyright (c) 2004, 2017 IBM Corporation All rights reserved.
>>   This program and the accompanying materials are made available
>>   under the terms of the BSD License available at
>>   http://www.opensource.org/licenses/bsd-license.php
>>
>>
>> Trying to load:  from: /pci@800000020000000/scsi@1/disk@100000000000000
>> ...   Successfully loaded
>>
>>
>>
>>
>>
>>
>>       Fedora (5.5.0-rc5-le-guest_v5.5-rc5_a+fstn1) 30 (Thirty)
>>
>>       Fedora (5.0.9-301.fc30.ppc64le) 30 (Thirty)
>>
>>       Fedora (0-rescue-8f8bbec520a44fd09da6af8e0d2c6571) 30 (Thirty)
>>
>>
>>
>>
>>>
>>> Thanks,
>>>
>>> C.
>>>
>>>
>>> QEMU Starting
>>>  Build Date = Feb 17 2020 13:06:47
>>>  FW Version = git-42228d763f1fdb7b
>>>  Press "s" to enter Open Firmware.
>>>
>>> Populating /vdevice methods
>>> Populating /vdevice/vty@71000000
>>> Populating /vdevice/nvram@71000001
>>> Populating /pci@800000020000000
>>>                      00 0800 (D) : 1af4 1004    virtio [ scsi ]
>>> Populating /pci@800000020000000/scsi@1
>>>        SCSI: Looking for devices
>>>           100000000000000 DISK     : "QEMU     QEMU HARDDISK    2.5+"
>>>                      00 1000 (D) : 1af4 1000    virtio [ net ]
>>>                      00 2000 (D) : 1b36 000d    serial bus [ usb-xhci ]
>>> No NVRAM common partition, re-initializing...
>>> Scanning USB 
>>>   XHCI: Initializing
>>> Using default console: /vdevice/vty@71000000
>>>      
>>>   Welcome to Open Firmware
>>>
>>>   Copyright (c) 2004, 2017 IBM Corporation All rights reserved.
>>>   This program and the accompanying materials are made available
>>>   under the terms of the BSD License available at
>>>   http://www.opensource.org/licenses/bsd-license.php
>>>
>>>
>>> Trying to load:  from: /pci@800000020000000/scsi@1/disk@100000000000000 ...  slash SCSI-DISK: Access beyond end of device ! 
>>>
>>> Out of internal memory.
>>> SCSI-DISK: Access beyond end of device ! 
>>> SCSI-DISK: Access beyond end of device ! 
>>> SCSI-DISK: Access beyond end of device ! 
>>> SCSI-DISK: Access beyond end of device ! 
>>> SCSI-DISK: Access beyond end of device ! 
>>>
>>
> 

-- 
Alexey

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

On 18/02/2020 20:05, Alexey Kardashevskiy wrote:
> 
> 
> On 18/02/2020 18:12, Cédric Le Goater wrote:
>> On 2/18/20 1:30 AM, Alexey Kardashevskiy wrote:
>>>
>>>
>>> On 17/02/2020 20:48, Cédric Le Goater wrote:
>>>> On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
>>>>> The following changes since commit 05943fb4ca41f626078014c0327781815c6584c5:
>>>>>
>>>>>   ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)
>>>>>
>>>>> are available in the Git repository at:
>>>>>
>>>>>   git@github.com:aik/qemu.git tags/qemu-slof-20200217
>>>>>
>>>>> for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:
>>>>>
>>>>>   pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
>>>>>
>>>>> ----------------------------------------------------------------
>>>>> Alexey Kardashevskiy (1):
>>>>>       pseries: Update SLOF firmware image
>>>>>
>>>>>  pc-bios/README   |   2 +-
>>>>>  pc-bios/slof.bin | Bin 931032 -> 968560 bytes
>>>>>  roms/SLOF        |   2 +-
>>>>>  3 files changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>>
>>>>> *** Note: this is not for master, this is for pseries
>>>>>
>>>>
>>>> Hello Alexey,
>>>>
>>>> QEMU fails to boot from disk. See below.
>>>
>>>
>>> It does boot mine (fedora 30, ubuntu 18.04), see below. I believe I
>>> could have broken something but I need more detail. Thanks,
>>
>> fedora31 boots but not ubuntu 19.10. Could it be GRUB version 2.04 ? 
> 
> 
> No, not that either:


but it might be because of power9 - I only tried power8, rsyncing the
image to a p9 machine now...


-- 
Alexey

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Cédric Le Goater]

On 2/18/20 10:10 AM, Alexey Kardashevskiy wrote:
> 
> 
> On 18/02/2020 20:05, Alexey Kardashevskiy wrote:
>>
>>
>> On 18/02/2020 18:12, Cédric Le Goater wrote:
>>> On 2/18/20 1:30 AM, Alexey Kardashevskiy wrote:
>>>>
>>>>
>>>> On 17/02/2020 20:48, Cédric Le Goater wrote:
>>>>> On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
>>>>>> The following changes since commit 05943fb4ca41f626078014c0327781815c6584c5:
>>>>>>
>>>>>>   ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)
>>>>>>
>>>>>> are available in the Git repository at:
>>>>>>
>>>>>>   git@github.com:aik/qemu.git tags/qemu-slof-20200217
>>>>>>
>>>>>> for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:
>>>>>>
>>>>>>   pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
>>>>>>
>>>>>> ----------------------------------------------------------------
>>>>>> Alexey Kardashevskiy (1):
>>>>>>       pseries: Update SLOF firmware image
>>>>>>
>>>>>>  pc-bios/README   |   2 +-
>>>>>>  pc-bios/slof.bin | Bin 931032 -> 968560 bytes
>>>>>>  roms/SLOF        |   2 +-
>>>>>>  3 files changed, 2 insertions(+), 2 deletions(-)
>>>>>>
>>>>>>
>>>>>> *** Note: this is not for master, this is for pseries
>>>>>>
>>>>>
>>>>> Hello Alexey,
>>>>>
>>>>> QEMU fails to boot from disk. See below.
>>>>
>>>>
>>>> It does boot mine (fedora 30, ubuntu 18.04), see below. I believe I
>>>> could have broken something but I need more detail. Thanks,
>>>
>>> fedora31 boots but not ubuntu 19.10. Could it be GRUB version 2.04 ? 
>>
>>
>> No, not that either:
> 
> 
> but it might be because of power9 - I only tried power8, rsyncing the
> image to a p9 machine now...

Here is the disk : 

Disk /dev/sda: 50 GiB, 53687091200 bytes, 104857600 sectors
Disk model: QEMU HARDDISK   
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: gpt
Disk identifier: 27DCE458-231A-4981-9FF1-983F87C2902D

Device         Start       End   Sectors Size Type
/dev/sda1       2048     16383     14336   7M PowerPC PReP boot
/dev/sda2      16384 100679679 100663296  48G Linux filesystem
/dev/sda3  100679680 104857566   4177887   2G Linux swap


GPT ? 

C.

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Cédric Le Goater]

On 2/18/20 10:40 AM, Cédric Le Goater wrote:
> On 2/18/20 10:10 AM, Alexey Kardashevskiy wrote:
>>
>>
>> On 18/02/2020 20:05, Alexey Kardashevskiy wrote:
>>>
>>>
>>> On 18/02/2020 18:12, Cédric Le Goater wrote:
>>>> On 2/18/20 1:30 AM, Alexey Kardashevskiy wrote:
>>>>>
>>>>>
>>>>> On 17/02/2020 20:48, Cédric Le Goater wrote:
>>>>>> On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
>>>>>>> The following changes since commit 05943fb4ca41f626078014c0327781815c6584c5:
>>>>>>>
>>>>>>>   ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)
>>>>>>>
>>>>>>> are available in the Git repository at:
>>>>>>>
>>>>>>>   git@github.com:aik/qemu.git tags/qemu-slof-20200217
>>>>>>>
>>>>>>> for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:
>>>>>>>
>>>>>>>   pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
>>>>>>>
>>>>>>> ----------------------------------------------------------------
>>>>>>> Alexey Kardashevskiy (1):
>>>>>>>       pseries: Update SLOF firmware image
>>>>>>>
>>>>>>>  pc-bios/README   |   2 +-
>>>>>>>  pc-bios/slof.bin | Bin 931032 -> 968560 bytes
>>>>>>>  roms/SLOF        |   2 +-
>>>>>>>  3 files changed, 2 insertions(+), 2 deletions(-)
>>>>>>>
>>>>>>>
>>>>>>> *** Note: this is not for master, this is for pseries
>>>>>>>
>>>>>>
>>>>>> Hello Alexey,
>>>>>>
>>>>>> QEMU fails to boot from disk. See below.
>>>>>
>>>>>
>>>>> It does boot mine (fedora 30, ubuntu 18.04), see below. I believe I
>>>>> could have broken something but I need more detail. Thanks,
>>>>
>>>> fedora31 boots but not ubuntu 19.10. Could it be GRUB version 2.04 ? 
>>>
>>>
>>> No, not that either:
>>
>>
>> but it might be because of power9 - I only tried power8, rsyncing the
>> image to a p9 machine now...
> 
> Here is the disk : 
> 
> Disk /dev/sda: 50 GiB, 53687091200 bytes, 104857600 sectors
> Disk model: QEMU HARDDISK   
> Units: sectors of 1 * 512 = 512 bytes
> Sector size (logical/physical): 512 bytes / 512 bytes
> I/O size (minimum/optimal): 512 bytes / 512 bytes
> Disklabel type: gpt
> Disk identifier: 27DCE458-231A-4981-9FF1-983F87C2902D
> 
> Device         Start       End   Sectors Size Type
> /dev/sda1       2048     16383     14336   7M PowerPC PReP boot
> /dev/sda2      16384 100679679 100663296  48G Linux filesystem
> /dev/sda3  100679680 104857566   4177887   2G Linux swap
> 
>
> GPT ? 

For the failure, I bisected up to :

f12149908705 ("ext2: Read all 64bit of inode number")

Also, commit e05b681b32df ("disk-label: Try ext2 filesystem when
booting from GPT partition") adds a weird "slash not found"
message :

Trying to load:  from: /pci@800000020000000/scsi@1/disk@100000000000000 ...  slash  not found   Successfully loaded

Thanks,

C.

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Cédric Le Goater]

On 2/18/20 1:48 PM, Cédric Le Goater wrote:
> On 2/18/20 10:40 AM, Cédric Le Goater wrote:
>> On 2/18/20 10:10 AM, Alexey Kardashevskiy wrote:
>>>
>>>
>>> On 18/02/2020 20:05, Alexey Kardashevskiy wrote:
>>>>
>>>>
>>>> On 18/02/2020 18:12, Cédric Le Goater wrote:
>>>>> On 2/18/20 1:30 AM, Alexey Kardashevskiy wrote:
>>>>>>
>>>>>>
>>>>>> On 17/02/2020 20:48, Cédric Le Goater wrote:
>>>>>>> On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
>>>>>>>> The following changes since commit 05943fb4ca41f626078014c0327781815c6584c5:
>>>>>>>>
>>>>>>>>   ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)
>>>>>>>>
>>>>>>>> are available in the Git repository at:
>>>>>>>>
>>>>>>>>   git@github.com:aik/qemu.git tags/qemu-slof-20200217
>>>>>>>>
>>>>>>>> for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:
>>>>>>>>
>>>>>>>>   pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
>>>>>>>>
>>>>>>>> ----------------------------------------------------------------
>>>>>>>> Alexey Kardashevskiy (1):
>>>>>>>>       pseries: Update SLOF firmware image
>>>>>>>>
>>>>>>>>  pc-bios/README   |   2 +-
>>>>>>>>  pc-bios/slof.bin | Bin 931032 -> 968560 bytes
>>>>>>>>  roms/SLOF        |   2 +-
>>>>>>>>  3 files changed, 2 insertions(+), 2 deletions(-)
>>>>>>>>
>>>>>>>>
>>>>>>>> *** Note: this is not for master, this is for pseries
>>>>>>>>
>>>>>>>
>>>>>>> Hello Alexey,
>>>>>>>
>>>>>>> QEMU fails to boot from disk. See below.
>>>>>>
>>>>>>
>>>>>> It does boot mine (fedora 30, ubuntu 18.04), see below. I believe I
>>>>>> could have broken something but I need more detail. Thanks,
>>>>>
>>>>> fedora31 boots but not ubuntu 19.10. Could it be GRUB version 2.04 ? 
>>>>
>>>>
>>>> No, not that either:
>>>
>>>
>>> but it might be because of power9 - I only tried power8, rsyncing the
>>> image to a p9 machine now...
>>
>> Here is the disk : 
>>
>> Disk /dev/sda: 50 GiB, 53687091200 bytes, 104857600 sectors
>> Disk model: QEMU HARDDISK   
>> Units: sectors of 1 * 512 = 512 bytes
>> Sector size (logical/physical): 512 bytes / 512 bytes
>> I/O size (minimum/optimal): 512 bytes / 512 bytes
>> Disklabel type: gpt
>> Disk identifier: 27DCE458-231A-4981-9FF1-983F87C2902D
>>
>> Device         Start       End   Sectors Size Type
>> /dev/sda1       2048     16383     14336   7M PowerPC PReP boot
>> /dev/sda2      16384 100679679 100663296  48G Linux filesystem
>> /dev/sda3  100679680 104857566   4177887   2G Linux swap
>>
>>
>> GPT ? 
> 
> For the failure, I bisected up to :
> 
> f12149908705 ("ext2: Read all 64bit of inode number")

Here is a possible fix for it. I did some RPN on my hp28s in the past 
but I am not forth fluent.

"slash not found" is still there though. 

Cheers,

C.


From 92dc9f6dc7c6434419306d5a382adb42169b712a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= <clg@kaod.org>
Date: Tue, 18 Feb 2020 13:54:54 +0100
Subject: [PATCH] ext2: Fix 64bit inode number
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fixes: f12149908705 ("ext2: Read all 64bit of inode number")
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 slof/fs/packages/ext2-files.fs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/slof/fs/packages/ext2-files.fs b/slof/fs/packages/ext2-files.fs
index b6a7880bd88e..f1d9fdfd67e2 100644
--- a/slof/fs/packages/ext2-files.fs
+++ b/slof/fs/packages/ext2-files.fs
@@ -152,7 +152,7 @@ CONSTANT /ext4-ee
   dup
   8 + l@-le               \ reads bg_inode_table_lo
   swap 28 + l@-le         \ reads bg_inode_table_hi
-  32 lshift or
+  32 rshift or
   block-size @ *          \ # in group, inode table
   swap inode-size @ * + xlsplit seek drop  inode @ inode-size @ read drop
 ;
-- 
2.21.1

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 2318 bytes --]

On Tue, Feb 18, 2020 at 06:48:43AM +0100, Philippe Mathieu-Daudé wrote:
> On 2/17/20 11:46 PM, David Gibson wrote:
> > On Mon, Feb 17, 2020 at 11:24:11AM +0100, Philippe Mathieu-Daudé wrote:
> > > On 2/17/20 10:26 AM, Philippe Mathieu-Daudé wrote:
> > > > Hi Alexey,
> > > > 
> > > > On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
> > > > > The following changes since commit
> > > > > 05943fb4ca41f626078014c0327781815c6584c5:
> > > > > 
> > > > >     ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)
> > > > > 
> > > > > are available in the Git repository at:
> > > > > 
> > > > >     git@github.com:aik/qemu.git tags/qemu-slof-20200217
> > > > > 
> > > > > for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:
> > > > > 
> > > > >     pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
> > > > > 
> > > > > ----------------------------------------------------------------
> > > > > Alexey Kardashevskiy (1):
> > > > >         pseries: Update SLOF firmware image
> > > > > 
> > > > >    pc-bios/README   |   2 +-
> > > > >    pc-bios/slof.bin | Bin 931032 -> 968560 bytes
> > > > >    roms/SLOF        |   2 +-
> > > > >    3 files changed, 2 insertions(+), 2 deletions(-)
> > > > 
> > > > I only received the cover, not the patch, have you posted it?
> > > 
> > > OK I see the SLOF binary is almost 1MB. Maybe this got blocked by spam
> > > filter. FYI you can use 'git-format-patch --no-binary' to emit the patch
> > > with the commit description but without the content.
> > 
> > Generally Alexey sends SLOF updates to me just as pull requests
> > without patches in full, because a huge slab of base64 encoded
> > firmware isn't particularly illuminating.
> 
> I understand, this is why I later suggested Alexey to use 'git-format-patch
> --no-binary', because Laszlo uses it for EDK2 submodule, this allow to
> quickly review the change on the list (without posting the base64), see:

Hm.  What's to review?  The only change apart from the binary blob and
the submodule tag is the version numbers in pc-bios/README.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 3334 bytes --]

On Tue, Feb 18, 2020 at 01:59:44PM +0100, Cédric Le Goater wrote:
> On 2/18/20 1:48 PM, Cédric Le Goater wrote:
> > On 2/18/20 10:40 AM, Cédric Le Goater wrote:
> >> On 2/18/20 10:10 AM, Alexey Kardashevskiy wrote:
> >>>
> >>>
> >>> On 18/02/2020 20:05, Alexey Kardashevskiy wrote:
> >>>>
> >>>>
> >>>> On 18/02/2020 18:12, Cédric Le Goater wrote:
> >>>>> On 2/18/20 1:30 AM, Alexey Kardashevskiy wrote:
> >>>>>>
> >>>>>>
> >>>>>> On 17/02/2020 20:48, Cédric Le Goater wrote:
> >>>>>>> On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
> >>>>>>>> The following changes since commit 05943fb4ca41f626078014c0327781815c6584c5:
> >>>>>>>>
> >>>>>>>>   ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)
> >>>>>>>>
> >>>>>>>> are available in the Git repository at:
> >>>>>>>>
> >>>>>>>>   git@github.com:aik/qemu.git tags/qemu-slof-20200217
> >>>>>>>>
> >>>>>>>> for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:
> >>>>>>>>
> >>>>>>>>   pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
> >>>>>>>>
> >>>>>>>> ----------------------------------------------------------------
> >>>>>>>> Alexey Kardashevskiy (1):
> >>>>>>>>       pseries: Update SLOF firmware image
> >>>>>>>>
> >>>>>>>>  pc-bios/README   |   2 +-
> >>>>>>>>  pc-bios/slof.bin | Bin 931032 -> 968560 bytes
> >>>>>>>>  roms/SLOF        |   2 +-
> >>>>>>>>  3 files changed, 2 insertions(+), 2 deletions(-)
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> *** Note: this is not for master, this is for pseries
> >>>>>>>>
> >>>>>>>
> >>>>>>> Hello Alexey,
> >>>>>>>
> >>>>>>> QEMU fails to boot from disk. See below.
> >>>>>>
> >>>>>>
> >>>>>> It does boot mine (fedora 30, ubuntu 18.04), see below. I believe I
> >>>>>> could have broken something but I need more detail. Thanks,
> >>>>>
> >>>>> fedora31 boots but not ubuntu 19.10. Could it be GRUB version 2.04 ? 
> >>>>
> >>>>
> >>>> No, not that either:
> >>>
> >>>
> >>> but it might be because of power9 - I only tried power8, rsyncing the
> >>> image to a p9 machine now...
> >>
> >> Here is the disk : 
> >>
> >> Disk /dev/sda: 50 GiB, 53687091200 bytes, 104857600 sectors
> >> Disk model: QEMU HARDDISK   
> >> Units: sectors of 1 * 512 = 512 bytes
> >> Sector size (logical/physical): 512 bytes / 512 bytes
> >> I/O size (minimum/optimal): 512 bytes / 512 bytes
> >> Disklabel type: gpt
> >> Disk identifier: 27DCE458-231A-4981-9FF1-983F87C2902D
> >>
> >> Device         Start       End   Sectors Size Type
> >> /dev/sda1       2048     16383     14336   7M PowerPC PReP boot
> >> /dev/sda2      16384 100679679 100663296  48G Linux filesystem
> >> /dev/sda3  100679680 104857566   4177887   2G Linux swap
> >>
> >>
> >> GPT ? 
> > 
> > For the failure, I bisected up to :
> > 
> > f12149908705 ("ext2: Read all 64bit of inode number")
> 
> Here is a possible fix for it. I did some RPN on my hp28s in the past 
> but I am not forth fluent.
> 
> "slash not found" is still there though. 

I've removed this SLOF update from my ppc-for-5.0 staging tree until
we figure out what's going wrong here.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

On 18/02/2020 23:59, Cédric Le Goater wrote:
> On 2/18/20 1:48 PM, Cédric Le Goater wrote:
>> On 2/18/20 10:40 AM, Cédric Le Goater wrote:
>>> On 2/18/20 10:10 AM, Alexey Kardashevskiy wrote:
>>>>
>>>>
>>>> On 18/02/2020 20:05, Alexey Kardashevskiy wrote:
>>>>>
>>>>>
>>>>> On 18/02/2020 18:12, Cédric Le Goater wrote:
>>>>>> On 2/18/20 1:30 AM, Alexey Kardashevskiy wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 17/02/2020 20:48, Cédric Le Goater wrote:
>>>>>>>> On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
>>>>>>>>> The following changes since commit 05943fb4ca41f626078014c0327781815c6584c5:
>>>>>>>>>
>>>>>>>>>   ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)
>>>>>>>>>
>>>>>>>>> are available in the Git repository at:
>>>>>>>>>
>>>>>>>>>   git@github.com:aik/qemu.git tags/qemu-slof-20200217
>>>>>>>>>
>>>>>>>>> for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:
>>>>>>>>>
>>>>>>>>>   pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
>>>>>>>>>
>>>>>>>>> ----------------------------------------------------------------
>>>>>>>>> Alexey Kardashevskiy (1):
>>>>>>>>>       pseries: Update SLOF firmware image
>>>>>>>>>
>>>>>>>>>  pc-bios/README   |   2 +-
>>>>>>>>>  pc-bios/slof.bin | Bin 931032 -> 968560 bytes
>>>>>>>>>  roms/SLOF        |   2 +-
>>>>>>>>>  3 files changed, 2 insertions(+), 2 deletions(-)
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> *** Note: this is not for master, this is for pseries
>>>>>>>>>
>>>>>>>>
>>>>>>>> Hello Alexey,
>>>>>>>>
>>>>>>>> QEMU fails to boot from disk. See below.
>>>>>>>
>>>>>>>
>>>>>>> It does boot mine (fedora 30, ubuntu 18.04), see below. I believe I
>>>>>>> could have broken something but I need more detail. Thanks,
>>>>>>
>>>>>> fedora31 boots but not ubuntu 19.10. Could it be GRUB version 2.04 ? 
>>>>>
>>>>>
>>>>> No, not that either:
>>>>
>>>>
>>>> but it might be because of power9 - I only tried power8, rsyncing the
>>>> image to a p9 machine now...
>>>
>>> Here is the disk : 
>>>
>>> Disk /dev/sda: 50 GiB, 53687091200 bytes, 104857600 sectors
>>> Disk model: QEMU HARDDISK   
>>> Units: sectors of 1 * 512 = 512 bytes
>>> Sector size (logical/physical): 512 bytes / 512 bytes
>>> I/O size (minimum/optimal): 512 bytes / 512 bytes
>>> Disklabel type: gpt
>>> Disk identifier: 27DCE458-231A-4981-9FF1-983F87C2902D
>>>
>>> Device         Start       End   Sectors Size Type
>>> /dev/sda1       2048     16383     14336   7M PowerPC PReP boot
>>> /dev/sda2      16384 100679679 100663296  48G Linux filesystem
>>> /dev/sda3  100679680 104857566   4177887   2G Linux swap
>>>
>>>
>>> GPT ? 
>>
>> For the failure, I bisected up to :
>>
>> f12149908705 ("ext2: Read all 64bit of inode number")
> 
> Here is a possible fix for it. I did some RPN on my hp28s in the past 
> but I am not forth fluent.


you basically zeroed the top bits by shifting them too far right :)

The proper fix I think is:

-  32 lshift or
+  20 lshift or

I keep forgetting it is all in hex. Can you please give it a try? My
128GB disk does not expose this problem somehow. Thanks,


> 
> "slash not found" is still there though. 
> 
> Cheers,
> 
> C.
> 
> 
> From 92dc9f6dc7c6434419306d5a382adb42169b712a Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= <clg@kaod.org>
> Date: Tue, 18 Feb 2020 13:54:54 +0100
> Subject: [PATCH] ext2: Fix 64bit inode number
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> Fixes: f12149908705 ("ext2: Read all 64bit of inode number")
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>  slof/fs/packages/ext2-files.fs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/slof/fs/packages/ext2-files.fs b/slof/fs/packages/ext2-files.fs
> index b6a7880bd88e..f1d9fdfd67e2 100644
> --- a/slof/fs/packages/ext2-files.fs
> +++ b/slof/fs/packages/ext2-files.fs
> @@ -152,7 +152,7 @@ CONSTANT /ext4-ee
>    dup
>    8 + l@-le               \ reads bg_inode_table_lo
>    swap 28 + l@-le         \ reads bg_inode_table_hi
> -  32 lshift or
> +  32 rshift or
>    block-size @ *          \ # in group, inode table
>    swap inode-size @ * + xlsplit seek drop  inode @ inode-size @ read drop
>  ;
> 

-- 
Alexey

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

On 19/02/2020 12:20, Alexey Kardashevskiy wrote:
> 
> 
> On 18/02/2020 23:59, Cédric Le Goater wrote:
>> On 2/18/20 1:48 PM, Cédric Le Goater wrote:
>>> On 2/18/20 10:40 AM, Cédric Le Goater wrote:
>>>> On 2/18/20 10:10 AM, Alexey Kardashevskiy wrote:
>>>>>
>>>>>
>>>>> On 18/02/2020 20:05, Alexey Kardashevskiy wrote:
>>>>>>
>>>>>>
>>>>>> On 18/02/2020 18:12, Cédric Le Goater wrote:
>>>>>>> On 2/18/20 1:30 AM, Alexey Kardashevskiy wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> On 17/02/2020 20:48, Cédric Le Goater wrote:
>>>>>>>>> On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
>>>>>>>>>> The following changes since commit 05943fb4ca41f626078014c0327781815c6584c5:
>>>>>>>>>>
>>>>>>>>>>   ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)
>>>>>>>>>>
>>>>>>>>>> are available in the Git repository at:
>>>>>>>>>>
>>>>>>>>>>   git@github.com:aik/qemu.git tags/qemu-slof-20200217
>>>>>>>>>>
>>>>>>>>>> for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:
>>>>>>>>>>
>>>>>>>>>>   pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
>>>>>>>>>>
>>>>>>>>>> ----------------------------------------------------------------
>>>>>>>>>> Alexey Kardashevskiy (1):
>>>>>>>>>>       pseries: Update SLOF firmware image
>>>>>>>>>>
>>>>>>>>>>  pc-bios/README   |   2 +-
>>>>>>>>>>  pc-bios/slof.bin | Bin 931032 -> 968560 bytes
>>>>>>>>>>  roms/SLOF        |   2 +-
>>>>>>>>>>  3 files changed, 2 insertions(+), 2 deletions(-)
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> *** Note: this is not for master, this is for pseries
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Hello Alexey,
>>>>>>>>>
>>>>>>>>> QEMU fails to boot from disk. See below.
>>>>>>>>
>>>>>>>>
>>>>>>>> It does boot mine (fedora 30, ubuntu 18.04), see below. I believe I
>>>>>>>> could have broken something but I need more detail. Thanks,
>>>>>>>
>>>>>>> fedora31 boots but not ubuntu 19.10. Could it be GRUB version 2.04 ? 
>>>>>>
>>>>>>
>>>>>> No, not that either:
>>>>>
>>>>>
>>>>> but it might be because of power9 - I only tried power8, rsyncing the
>>>>> image to a p9 machine now...
>>>>
>>>> Here is the disk : 
>>>>
>>>> Disk /dev/sda: 50 GiB, 53687091200 bytes, 104857600 sectors
>>>> Disk model: QEMU HARDDISK   
>>>> Units: sectors of 1 * 512 = 512 bytes
>>>> Sector size (logical/physical): 512 bytes / 512 bytes
>>>> I/O size (minimum/optimal): 512 bytes / 512 bytes
>>>> Disklabel type: gpt
>>>> Disk identifier: 27DCE458-231A-4981-9FF1-983F87C2902D
>>>>
>>>> Device         Start       End   Sectors Size Type
>>>> /dev/sda1       2048     16383     14336   7M PowerPC PReP boot
>>>> /dev/sda2      16384 100679679 100663296  48G Linux filesystem
>>>> /dev/sda3  100679680 104857566   4177887   2G Linux swap
>>>>
>>>>
>>>> GPT ? 
>>>
>>> For the failure, I bisected up to :
>>>
>>> f12149908705 ("ext2: Read all 64bit of inode number")
>>
>> Here is a possible fix for it. I did some RPN on my hp28s in the past 
>> but I am not forth fluent.
> 
> 
> you basically zeroed the top bits by shifting them too far right :)
> 
> The proper fix I think is:
> 
> -  32 lshift or
> +  20 lshift or
> 
> I keep forgetting it is all in hex. Can you please give it a try? My
> 128GB disk does not expose this problem somehow. Thanks,

Better try this one please:

https://github.com/aik/SLOF/tree/ext4

What I still do not understand is why GRUB is using ext2 from SLOF, it
should parse ext4 itself :-/


> 
> 
>>
>> "slash not found" is still there though. 


Yeah I see these but they are harmless as far as I can tell.



>>
>> Cheers,
>>
>> C.
>>
>>
>> From 92dc9f6dc7c6434419306d5a382adb42169b712a Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= <clg@kaod.org>
>> Date: Tue, 18 Feb 2020 13:54:54 +0100
>> Subject: [PATCH] ext2: Fix 64bit inode number
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
>> Fixes: f12149908705 ("ext2: Read all 64bit of inode number")
>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>> ---
>>  slof/fs/packages/ext2-files.fs | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/slof/fs/packages/ext2-files.fs b/slof/fs/packages/ext2-files.fs
>> index b6a7880bd88e..f1d9fdfd67e2 100644
>> --- a/slof/fs/packages/ext2-files.fs
>> +++ b/slof/fs/packages/ext2-files.fs
>> @@ -152,7 +152,7 @@ CONSTANT /ext4-ee
>>    dup
>>    8 + l@-le               \ reads bg_inode_table_lo
>>    swap 28 + l@-le         \ reads bg_inode_table_hi
>> -  32 lshift or
>> +  32 rshift or
>>    block-size @ *          \ # in group, inode table
>>    swap inode-size @ * + xlsplit seek drop  inode @ inode-size @ read drop
>>  ;
>>
> 

-- 
Alexey

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Cédric Le Goater]

On 2/19/20 7:44 AM, Alexey Kardashevskiy wrote:
> 
> 
> On 19/02/2020 12:20, Alexey Kardashevskiy wrote:
>>
>>
>> On 18/02/2020 23:59, Cédric Le Goater wrote:
>>> On 2/18/20 1:48 PM, Cédric Le Goater wrote:
>>>> On 2/18/20 10:40 AM, Cédric Le Goater wrote:
>>>>> On 2/18/20 10:10 AM, Alexey Kardashevskiy wrote:
>>>>>>
>>>>>>
>>>>>> On 18/02/2020 20:05, Alexey Kardashevskiy wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 18/02/2020 18:12, Cédric Le Goater wrote:
>>>>>>>> On 2/18/20 1:30 AM, Alexey Kardashevskiy wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On 17/02/2020 20:48, Cédric Le Goater wrote:
>>>>>>>>>> On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
>>>>>>>>>>> The following changes since commit 05943fb4ca41f626078014c0327781815c6584c5:
>>>>>>>>>>>
>>>>>>>>>>>   ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)
>>>>>>>>>>>
>>>>>>>>>>> are available in the Git repository at:
>>>>>>>>>>>
>>>>>>>>>>>   git@github.com:aik/qemu.git tags/qemu-slof-20200217
>>>>>>>>>>>
>>>>>>>>>>> for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:
>>>>>>>>>>>
>>>>>>>>>>>   pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
>>>>>>>>>>>
>>>>>>>>>>> ----------------------------------------------------------------
>>>>>>>>>>> Alexey Kardashevskiy (1):
>>>>>>>>>>>       pseries: Update SLOF firmware image
>>>>>>>>>>>
>>>>>>>>>>>  pc-bios/README   |   2 +-
>>>>>>>>>>>  pc-bios/slof.bin | Bin 931032 -> 968560 bytes
>>>>>>>>>>>  roms/SLOF        |   2 +-
>>>>>>>>>>>  3 files changed, 2 insertions(+), 2 deletions(-)
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> *** Note: this is not for master, this is for pseries
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Hello Alexey,
>>>>>>>>>>
>>>>>>>>>> QEMU fails to boot from disk. See below.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> It does boot mine (fedora 30, ubuntu 18.04), see below. I believe I
>>>>>>>>> could have broken something but I need more detail. Thanks,
>>>>>>>>
>>>>>>>> fedora31 boots but not ubuntu 19.10. Could it be GRUB version 2.04 ? 
>>>>>>>
>>>>>>>
>>>>>>> No, not that either:
>>>>>>
>>>>>>
>>>>>> but it might be because of power9 - I only tried power8, rsyncing the
>>>>>> image to a p9 machine now...
>>>>>
>>>>> Here is the disk : 
>>>>>
>>>>> Disk /dev/sda: 50 GiB, 53687091200 bytes, 104857600 sectors
>>>>> Disk model: QEMU HARDDISK   
>>>>> Units: sectors of 1 * 512 = 512 bytes
>>>>> Sector size (logical/physical): 512 bytes / 512 bytes
>>>>> I/O size (minimum/optimal): 512 bytes / 512 bytes
>>>>> Disklabel type: gpt
>>>>> Disk identifier: 27DCE458-231A-4981-9FF1-983F87C2902D
>>>>>
>>>>> Device         Start       End   Sectors Size Type
>>>>> /dev/sda1       2048     16383     14336   7M PowerPC PReP boot
>>>>> /dev/sda2      16384 100679679 100663296  48G Linux filesystem
>>>>> /dev/sda3  100679680 104857566   4177887   2G Linux swap
>>>>>
>>>>>
>>>>> GPT ? 
>>>>
>>>> For the failure, I bisected up to :
>>>>
>>>> f12149908705 ("ext2: Read all 64bit of inode number")
>>>
>>> Here is a possible fix for it. I did some RPN on my hp28s in the past 
>>> but I am not forth fluent.
>>
>>
>> you basically zeroed the top bits by shifting them too far right :)
>>
>> The proper fix I think is:
>>
>> -  32 lshift or
>> +  20 lshift or
>>
>> I keep forgetting it is all in hex. Can you please give it a try? My
>> 128GB disk does not expose this problem somehow. Thanks,
> 
> Better try this one please:
> 
> https://github.com/aik/SLOF/tree/ext4
Tested with the same image. Looks good. 
 
> What I still do not understand is why GRUB is using ext2 from SLOF, it
> should parse ext4 itself :-/

Here is the fs information.


Filesystem volume name:   <none>
Last mounted on:          /
Filesystem UUID:          8d53f6b4-ffc2-4d8f-bd09-67ac97d7b0c5
Filesystem magic number:  0xEF53
Filesystem revision #:    1 (dynamic)
Filesystem features:      has_journal ext_attr resize_inode dir_index filetype needs_recovery extent flex_bg sparse_super large_file huge_file uninit_bg dir_nlink extra_isize
Filesystem flags:         unsigned_directory_hash 
Default mount options:    user_xattr acl
Filesystem state:         clean
Errors behavior:          Continue
Filesystem OS type:       Linux
Inode count:              3127296
Block count:              12582912
Reserved block count:     552210
Free blocks:              7907437
Free inodes:              2863361
First block:              0
Block size:               4096
Fragment size:            4096
Reserved GDT blocks:      1021
Blocks per group:         32768
Fragments per group:      32768
Inodes per group:         8144
Inode blocks per group:   509
Flex block group size:    16
Filesystem created:       Wed Dec 14 15:40:55 2016
Last mount time:          Wed Feb 19 08:06:52 2020
Last write time:          Wed Feb 19 08:06:46 2020
Mount count:              1863
Maximum mount count:      -1
Last checked:             Fri Nov 23 19:09:13 2018
Check interval:           0 (<none>)
Lifetime writes:          883 GB
Reserved blocks uid:      0 (user root)
Reserved blocks gid:      0 (group root)
First inode:              11
Inode size:	          256
Required extra isize:     28
Desired extra isize:      28
Journal inode:            8
Default directory hash:   half_md4
Directory Hash Seed:      f7cb5863-4885-47b6-b24b-369df6a3b1a4
Journal backup:           inode blocks
Journal features:         journal_incompat_revoke
Journal size:             128M
Journal length:           32768
Journal sequence:         0x0004beb2

Thanks,

C.

> 
>>
>>
>>>
>>> "slash not found" is still there though. 
> 
> 
> Yeah I see these but they are harmless as far as I can tell.
> 
> 
> 
>>>
>>> Cheers,
>>>
>>> C.
>>>
>>>
>>> From 92dc9f6dc7c6434419306d5a382adb42169b712a Mon Sep 17 00:00:00 2001
>>> From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= <clg@kaod.org>
>>> Date: Tue, 18 Feb 2020 13:54:54 +0100
>>> Subject: [PATCH] ext2: Fix 64bit inode number
>>> MIME-Version: 1.0
>>> Content-Type: text/plain; charset=UTF-8
>>> Content-Transfer-Encoding: 8bit
>>>
>>> Fixes: f12149908705 ("ext2: Read all 64bit of inode number")
>>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>>> ---
>>>  slof/fs/packages/ext2-files.fs | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/slof/fs/packages/ext2-files.fs b/slof/fs/packages/ext2-files.fs
>>> index b6a7880bd88e..f1d9fdfd67e2 100644
>>> --- a/slof/fs/packages/ext2-files.fs
>>> +++ b/slof/fs/packages/ext2-files.fs
>>> @@ -152,7 +152,7 @@ CONSTANT /ext4-ee
>>>    dup
>>>    8 + l@-le               \ reads bg_inode_table_lo
>>>    swap 28 + l@-le         \ reads bg_inode_table_hi
>>> -  32 lshift or
>>> +  32 rshift or
>>>    block-size @ *          \ # in group, inode table
>>>    swap inode-size @ * + xlsplit seek drop  inode @ inode-size @ read drop
>>>  ;
>>>
>>
> 

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

On 19/02/2020 18:18, Cédric Le Goater wrote:
> On 2/19/20 7:44 AM, Alexey Kardashevskiy wrote:
>>
>>
>> On 19/02/2020 12:20, Alexey Kardashevskiy wrote:
>>>
>>>
>>> On 18/02/2020 23:59, Cédric Le Goater wrote:
>>>> On 2/18/20 1:48 PM, Cédric Le Goater wrote:
>>>>> On 2/18/20 10:40 AM, Cédric Le Goater wrote:
>>>>>> On 2/18/20 10:10 AM, Alexey Kardashevskiy wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 18/02/2020 20:05, Alexey Kardashevskiy wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> On 18/02/2020 18:12, Cédric Le Goater wrote:
>>>>>>>>> On 2/18/20 1:30 AM, Alexey Kardashevskiy wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On 17/02/2020 20:48, Cédric Le Goater wrote:
>>>>>>>>>>> On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
>>>>>>>>>>>> The following changes since commit 05943fb4ca41f626078014c0327781815c6584c5:
>>>>>>>>>>>>
>>>>>>>>>>>>   ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)
>>>>>>>>>>>>
>>>>>>>>>>>> are available in the Git repository at:
>>>>>>>>>>>>
>>>>>>>>>>>>   git@github.com:aik/qemu.git tags/qemu-slof-20200217
>>>>>>>>>>>>
>>>>>>>>>>>> for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:
>>>>>>>>>>>>
>>>>>>>>>>>>   pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
>>>>>>>>>>>>
>>>>>>>>>>>> ----------------------------------------------------------------
>>>>>>>>>>>> Alexey Kardashevskiy (1):
>>>>>>>>>>>>       pseries: Update SLOF firmware image
>>>>>>>>>>>>
>>>>>>>>>>>>  pc-bios/README   |   2 +-
>>>>>>>>>>>>  pc-bios/slof.bin | Bin 931032 -> 968560 bytes
>>>>>>>>>>>>  roms/SLOF        |   2 +-
>>>>>>>>>>>>  3 files changed, 2 insertions(+), 2 deletions(-)
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> *** Note: this is not for master, this is for pseries
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Hello Alexey,
>>>>>>>>>>>
>>>>>>>>>>> QEMU fails to boot from disk. See below.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> It does boot mine (fedora 30, ubuntu 18.04), see below. I believe I
>>>>>>>>>> could have broken something but I need more detail. Thanks,
>>>>>>>>>
>>>>>>>>> fedora31 boots but not ubuntu 19.10. Could it be GRUB version 2.04 ? 
>>>>>>>>
>>>>>>>>
>>>>>>>> No, not that either:
>>>>>>>
>>>>>>>
>>>>>>> but it might be because of power9 - I only tried power8, rsyncing the
>>>>>>> image to a p9 machine now...
>>>>>>
>>>>>> Here is the disk : 
>>>>>>
>>>>>> Disk /dev/sda: 50 GiB, 53687091200 bytes, 104857600 sectors
>>>>>> Disk model: QEMU HARDDISK   
>>>>>> Units: sectors of 1 * 512 = 512 bytes
>>>>>> Sector size (logical/physical): 512 bytes / 512 bytes
>>>>>> I/O size (minimum/optimal): 512 bytes / 512 bytes
>>>>>> Disklabel type: gpt
>>>>>> Disk identifier: 27DCE458-231A-4981-9FF1-983F87C2902D
>>>>>>
>>>>>> Device         Start       End   Sectors Size Type
>>>>>> /dev/sda1       2048     16383     14336   7M PowerPC PReP boot
>>>>>> /dev/sda2      16384 100679679 100663296  48G Linux filesystem
>>>>>> /dev/sda3  100679680 104857566   4177887   2G Linux swap
>>>>>>
>>>>>>
>>>>>> GPT ? 
>>>>>
>>>>> For the failure, I bisected up to :
>>>>>
>>>>> f12149908705 ("ext2: Read all 64bit of inode number")
>>>>
>>>> Here is a possible fix for it. I did some RPN on my hp28s in the past 
>>>> but I am not forth fluent.
>>>
>>>
>>> you basically zeroed the top bits by shifting them too far right :)
>>>
>>> The proper fix I think is:
>>>
>>> -  32 lshift or
>>> +  20 lshift or
>>>
>>> I keep forgetting it is all in hex. Can you please give it a try? My
>>> 128GB disk does not expose this problem somehow. Thanks,
>>
>> Better try this one please:
>>
>> https://github.com/aik/SLOF/tree/ext4
> Tested with the same image. Looks good. 


Thanks for testing. But it is still bizarre behaviour, why do we end up
there anyway...


>> What I still do not understand is why GRUB is using ext2 from SLOF, it
>> should parse ext4 itself :-/
> 
> Here is the fs information.
> 
> 
> Filesystem volume name:   <none>
> Last mounted on:          /
> Filesystem UUID:          8d53f6b4-ffc2-4d8f-bd09-67ac97d7b0c5
> Filesystem magic number:  0xEF53
> Filesystem revision #:    1 (dynamic)
> Filesystem features:      has_journal ext_attr resize_inode dir_index filetype needs_recovery extent flex_bg sparse_super large_file huge_file uninit_bg dir_nlink extra_isize


huh, this one does not have 64bit like mine, I blindly assumed that by
2020 everything would be using that. Well that explains the bug. And
yours also has uninit_bg (the whole idea of this flag is not obvious but
ok).


> Filesystem flags:         unsigned_directory_hash 
> Default mount options:    user_xattr acl
> Filesystem state:         clean
> Errors behavior:          Continue
> Filesystem OS type:       Linux
> Inode count:              3127296
> Block count:              12582912
> Reserved block count:     552210
> Free blocks:              7907437
> Free inodes:              2863361
> First block:              0
> Block size:               4096
> Fragment size:            4096


Mine here has:
Group descriptor size:    64

so there is no "hi" part and this is what my fix now handles (0x32 vs.
0x20 was not the problem actually).

Did you do this on purpose or the installer did it? :)

Anyway, I'd like to get this particular disk image to understand why on
earth it is using the ext2 package from SLOF. Thanks,


> Reserved GDT blocks:      1021
> Blocks per group:         32768
> Fragments per group:      32768
> Inodes per group:         8144
> Inode blocks per group:   509
> Flex block group size:    16
> Filesystem created:       Wed Dec 14 15:40:55 2016
> Last mount time:          Wed Feb 19 08:06:52 2020
> Last write time:          Wed Feb 19 08:06:46 2020
> Mount count:              1863
> Maximum mount count:      -1
> Last checked:             Fri Nov 23 19:09:13 2018
> Check interval:           0 (<none>)
> Lifetime writes:          883 GB
> Reserved blocks uid:      0 (user root)
> Reserved blocks gid:      0 (group root)
> First inode:              11
> Inode size:	          256
> Required extra isize:     28
> Desired extra isize:      28
> Journal inode:            8
> Default directory hash:   half_md4
> Directory Hash Seed:      f7cb5863-4885-47b6-b24b-369df6a3b1a4
> Journal backup:           inode blocks
> Journal features:         journal_incompat_revoke
> Journal size:             128M
> Journal length:           32768
> Journal sequence:         0x0004beb2
> 
> Thanks,
> 
> C.
> 
>>
>>>
>>>
>>>>
>>>> "slash not found" is still there though. 
>>
>>
>> Yeah I see these but they are harmless as far as I can tell.
>>
>>
>>
>>>>
>>>> Cheers,
>>>>
>>>> C.
>>>>
>>>>
>>>> From 92dc9f6dc7c6434419306d5a382adb42169b712a Mon Sep 17 00:00:00 2001
>>>> From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= <clg@kaod.org>
>>>> Date: Tue, 18 Feb 2020 13:54:54 +0100
>>>> Subject: [PATCH] ext2: Fix 64bit inode number
>>>> MIME-Version: 1.0
>>>> Content-Type: text/plain; charset=UTF-8
>>>> Content-Transfer-Encoding: 8bit
>>>>
>>>> Fixes: f12149908705 ("ext2: Read all 64bit of inode number")
>>>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>>>> ---
>>>>  slof/fs/packages/ext2-files.fs | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/slof/fs/packages/ext2-files.fs b/slof/fs/packages/ext2-files.fs
>>>> index b6a7880bd88e..f1d9fdfd67e2 100644
>>>> --- a/slof/fs/packages/ext2-files.fs
>>>> +++ b/slof/fs/packages/ext2-files.fs
>>>> @@ -152,7 +152,7 @@ CONSTANT /ext4-ee
>>>>    dup
>>>>    8 + l@-le               \ reads bg_inode_table_lo
>>>>    swap 28 + l@-le         \ reads bg_inode_table_hi
>>>> -  32 lshift or
>>>> +  32 rshift or
>>>>    block-size @ *          \ # in group, inode table
>>>>    swap inode-size @ * + xlsplit seek drop  inode @ inode-size @ read drop
>>>>  ;
>>>>
>>>
>>
> 

-- 
Alexey

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Cédric Le Goater]

On 2/20/20 2:50 AM, Alexey Kardashevskiy wrote:
> 
> 
> On 19/02/2020 18:18, Cédric Le Goater wrote:
>> On 2/19/20 7:44 AM, Alexey Kardashevskiy wrote:
>>>
>>>
>>> On 19/02/2020 12:20, Alexey Kardashevskiy wrote:
>>>>
>>>>
>>>> On 18/02/2020 23:59, Cédric Le Goater wrote:
>>>>> On 2/18/20 1:48 PM, Cédric Le Goater wrote:
>>>>>> On 2/18/20 10:40 AM, Cédric Le Goater wrote:
>>>>>>> On 2/18/20 10:10 AM, Alexey Kardashevskiy wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> On 18/02/2020 20:05, Alexey Kardashevskiy wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On 18/02/2020 18:12, Cédric Le Goater wrote:
>>>>>>>>>> On 2/18/20 1:30 AM, Alexey Kardashevskiy wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On 17/02/2020 20:48, Cédric Le Goater wrote:
>>>>>>>>>>>> On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
>>>>>>>>>>>>> The following changes since commit 05943fb4ca41f626078014c0327781815c6584c5:
>>>>>>>>>>>>>
>>>>>>>>>>>>>   ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23 +1100)
>>>>>>>>>>>>>
>>>>>>>>>>>>> are available in the Git repository at:
>>>>>>>>>>>>>
>>>>>>>>>>>>>   git@github.com:aik/qemu.git tags/qemu-slof-20200217
>>>>>>>>>>>>>
>>>>>>>>>>>>> for you to fetch changes up to ea9a03e5aa023c5391bab5259898475d0298aac2:
>>>>>>>>>>>>>
>>>>>>>>>>>>>   pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
>>>>>>>>>>>>>
>>>>>>>>>>>>> ----------------------------------------------------------------
>>>>>>>>>>>>> Alexey Kardashevskiy (1):
>>>>>>>>>>>>>       pseries: Update SLOF firmware image
>>>>>>>>>>>>>
>>>>>>>>>>>>>  pc-bios/README   |   2 +-
>>>>>>>>>>>>>  pc-bios/slof.bin | Bin 931032 -> 968560 bytes
>>>>>>>>>>>>>  roms/SLOF        |   2 +-
>>>>>>>>>>>>>  3 files changed, 2 insertions(+), 2 deletions(-)
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> *** Note: this is not for master, this is for pseries
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Hello Alexey,
>>>>>>>>>>>>
>>>>>>>>>>>> QEMU fails to boot from disk. See below.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> It does boot mine (fedora 30, ubuntu 18.04), see below. I believe I
>>>>>>>>>>> could have broken something but I need more detail. Thanks,
>>>>>>>>>>
>>>>>>>>>> fedora31 boots but not ubuntu 19.10. Could it be GRUB version 2.04 ? 
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> No, not that either:
>>>>>>>>
>>>>>>>>
>>>>>>>> but it might be because of power9 - I only tried power8, rsyncing the
>>>>>>>> image to a p9 machine now...
>>>>>>>
>>>>>>> Here is the disk : 
>>>>>>>
>>>>>>> Disk /dev/sda: 50 GiB, 53687091200 bytes, 104857600 sectors
>>>>>>> Disk model: QEMU HARDDISK   
>>>>>>> Units: sectors of 1 * 512 = 512 bytes
>>>>>>> Sector size (logical/physical): 512 bytes / 512 bytes
>>>>>>> I/O size (minimum/optimal): 512 bytes / 512 bytes
>>>>>>> Disklabel type: gpt
>>>>>>> Disk identifier: 27DCE458-231A-4981-9FF1-983F87C2902D
>>>>>>>
>>>>>>> Device         Start       End   Sectors Size Type
>>>>>>> /dev/sda1       2048     16383     14336   7M PowerPC PReP boot
>>>>>>> /dev/sda2      16384 100679679 100663296  48G Linux filesystem
>>>>>>> /dev/sda3  100679680 104857566   4177887   2G Linux swap
>>>>>>>
>>>>>>>
>>>>>>> GPT ? 
>>>>>>
>>>>>> For the failure, I bisected up to :
>>>>>>
>>>>>> f12149908705 ("ext2: Read all 64bit of inode number")
>>>>>
>>>>> Here is a possible fix for it. I did some RPN on my hp28s in the past 
>>>>> but I am not forth fluent.
>>>>
>>>>
>>>> you basically zeroed the top bits by shifting them too far right :)
>>>>
>>>> The proper fix I think is:
>>>>
>>>> -  32 lshift or
>>>> +  20 lshift or
>>>>
>>>> I keep forgetting it is all in hex. Can you please give it a try? My
>>>> 128GB disk does not expose this problem somehow. Thanks,
>>>
>>> Better try this one please:
>>>
>>> https://github.com/aik/SLOF/tree/ext4
>> Tested with the same image. Looks good. 
> 
> 
> Thanks for testing. But it is still bizarre behaviour, why do we end up
> there anyway...
> 
> 
>>> What I still do not understand is why GRUB is using ext2 from SLOF, it
>>> should parse ext4 itself :-/
>>
>> Here is the fs information.
>>
>>
>> Filesystem volume name:   <none>
>> Last mounted on:          /
>> Filesystem UUID:          8d53f6b4-ffc2-4d8f-bd09-67ac97d7b0c5
>> Filesystem magic number:  0xEF53
>> Filesystem revision #:    1 (dynamic)
>> Filesystem features:      has_journal ext_attr resize_inode dir_index filetype needs_recovery extent flex_bg sparse_super large_file huge_file uninit_bg dir_nlink extra_isize
> 
> 
> huh, this one does not have 64bit like mine, I blindly assumed that by
> 2020 everything would be using that. Well that explains the bug. And
> yours also has uninit_bg (the whole idea of this flag is not obvious but
> ok).
> 
> 
>> Filesystem flags:         unsigned_directory_hash 
>> Default mount options:    user_xattr acl
>> Filesystem state:         clean
>> Errors behavior:          Continue
>> Filesystem OS type:       Linux
>> Inode count:              3127296
>> Block count:              12582912
>> Reserved block count:     552210
>> Free blocks:              7907437
>> Free inodes:              2863361
>> First block:              0
>> Block size:               4096
>> Fragment size:            4096
> 
> 
> Mine here has:
> Group descriptor size:    64
> 
> so there is no "hi" part and this is what my fix now handles (0x32 vs.
> 0x20 was not the problem actually).
> 
> Did you do this on purpose or the installer did it? :)

I don't remember. I think I have kept the same disk image since 14.04 
and did some fs resize.

> Anyway, I'd like to get this particular disk image to understand why on
> earth it is using the ext2 package from SLOF. Thanks,

Sure.

Thanks,

C.

> 
>> Reserved GDT blocks:      1021
>> Blocks per group:         32768
>> Fragments per group:      32768
>> Inodes per group:         8144
>> Inode blocks per group:   509
>> Flex block group size:    16
>> Filesystem created:       Wed Dec 14 15:40:55 2016
>> Last mount time:          Wed Feb 19 08:06:52 2020
>> Last write time:          Wed Feb 19 08:06:46 2020
>> Mount count:              1863
>> Maximum mount count:      -1
>> Last checked:             Fri Nov 23 19:09:13 2018
>> Check interval:           0 (<none>)
>> Lifetime writes:          883 GB
>> Reserved blocks uid:      0 (user root)
>> Reserved blocks gid:      0 (group root)
>> First inode:              11
>> Inode size:	          256
>> Required extra isize:     28
>> Desired extra isize:      28
>> Journal inode:            8
>> Default directory hash:   half_md4
>> Directory Hash Seed:      f7cb5863-4885-47b6-b24b-369df6a3b1a4
>> Journal backup:           inode blocks
>> Journal features:         journal_incompat_revoke
>> Journal size:             128M
>> Journal length:           32768
>> Journal sequence:         0x0004beb2
>>
>> Thanks,
>>
>> C.
>>
>>>
>>>>
>>>>
>>>>>
>>>>> "slash not found" is still there though. 
>>>
>>>
>>> Yeah I see these but they are harmless as far as I can tell.
>>>
>>>
>>>
>>>>>
>>>>> Cheers,
>>>>>
>>>>> C.
>>>>>
>>>>>
>>>>> From 92dc9f6dc7c6434419306d5a382adb42169b712a Mon Sep 17 00:00:00 2001
>>>>> From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= <clg@kaod.org>
>>>>> Date: Tue, 18 Feb 2020 13:54:54 +0100
>>>>> Subject: [PATCH] ext2: Fix 64bit inode number
>>>>> MIME-Version: 1.0
>>>>> Content-Type: text/plain; charset=UTF-8
>>>>> Content-Transfer-Encoding: 8bit
>>>>>
>>>>> Fixes: f12149908705 ("ext2: Read all 64bit of inode number")
>>>>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>>>>> ---
>>>>>  slof/fs/packages/ext2-files.fs | 2 +-
>>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/slof/fs/packages/ext2-files.fs b/slof/fs/packages/ext2-files.fs
>>>>> index b6a7880bd88e..f1d9fdfd67e2 100644
>>>>> --- a/slof/fs/packages/ext2-files.fs
>>>>> +++ b/slof/fs/packages/ext2-files.fs
>>>>> @@ -152,7 +152,7 @@ CONSTANT /ext4-ee
>>>>>    dup
>>>>>    8 + l@-le               \ reads bg_inode_table_lo
>>>>>    swap 28 + l@-le         \ reads bg_inode_table_hi
>>>>> -  32 lshift or
>>>>> +  32 rshift or
>>>>>    block-size @ *          \ # in group, inode table
>>>>>    swap inode-size @ * + xlsplit seek drop  inode @ inode-size @ read drop
>>>>>  ;
>>>>>
>>>>
>>>
>>
> 

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

On 18/02/2020 16:48, Philippe Mathieu-Daudé wrote:
> On 2/17/20 11:46 PM, David Gibson wrote:
>> On Mon, Feb 17, 2020 at 11:24:11AM +0100, Philippe Mathieu-Daudé wrote:
>>> On 2/17/20 10:26 AM, Philippe Mathieu-Daudé wrote:
>>>> Hi Alexey,
>>>>
>>>> On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
>>>>> The following changes since commit
>>>>> 05943fb4ca41f626078014c0327781815c6584c5:
>>>>>
>>>>>     ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23
>>>>> +1100)
>>>>>
>>>>> are available in the Git repository at:
>>>>>
>>>>>     git@github.com:aik/qemu.git tags/qemu-slof-20200217
>>>>>
>>>>> for you to fetch changes up to
>>>>> ea9a03e5aa023c5391bab5259898475d0298aac2:
>>>>>
>>>>>     pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
>>>>>
>>>>> ----------------------------------------------------------------
>>>>> Alexey Kardashevskiy (1):
>>>>>         pseries: Update SLOF firmware image
>>>>>
>>>>>    pc-bios/README   |   2 +-
>>>>>    pc-bios/slof.bin | Bin 931032 -> 968560 bytes
>>>>>    roms/SLOF        |   2 +-
>>>>>    3 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> I only received the cover, not the patch, have you posted it?
>>>
>>> OK I see the SLOF binary is almost 1MB. Maybe this got blocked by spam
>>> filter. FYI you can use 'git-format-patch --no-binary' to emit the patch
>>> with the commit description but without the content.
>>
>> Generally Alexey sends SLOF updates to me just as pull requests
>> without patches in full, because a huge slab of base64 encoded
>> firmware isn't particularly illuminating.
> 
> I understand, this is why I later suggested Alexey to use
> 'git-format-patch --no-binary', because Laszlo uses it for EDK2
> submodule, this allow to quickly review the change on the list (without
> posting the base64), see:
> 
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg624429.html
> (pull-request cover)
> 
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg624432.html
> "roms/edk2: update submodule"
> 
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg624435.html
> "pc-bios: refresh edk2 build artifacts"

I am not quite sure where to fit this "git-format-patch". I run now "git
request-pull" and "git send-email" so am I expected to run format-patch
and post it as a patchset but with the pull request mail as a cover
letter? This does not seem very useful though. For today, I'll add the
change log to the pull request mail. Thanks,



-- 
Alexey

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 3011 bytes --]

On Fri, Feb 21, 2020 at 03:09:46PM +1100, Alexey Kardashevskiy wrote:
> 
> 
> On 18/02/2020 16:48, Philippe Mathieu-Daudé wrote:
> > On 2/17/20 11:46 PM, David Gibson wrote:
> >> On Mon, Feb 17, 2020 at 11:24:11AM +0100, Philippe Mathieu-Daudé wrote:
> >>> On 2/17/20 10:26 AM, Philippe Mathieu-Daudé wrote:
> >>>> Hi Alexey,
> >>>>
> >>>> On 2/17/20 3:12 AM, Alexey Kardashevskiy wrote:
> >>>>> The following changes since commit
> >>>>> 05943fb4ca41f626078014c0327781815c6584c5:
> >>>>>
> >>>>>     ppc: free 'fdt' after reset the machine (2020-02-17 11:27:23
> >>>>> +1100)
> >>>>>
> >>>>> are available in the Git repository at:
> >>>>>
> >>>>>     git@github.com:aik/qemu.git tags/qemu-slof-20200217
> >>>>>
> >>>>> for you to fetch changes up to
> >>>>> ea9a03e5aa023c5391bab5259898475d0298aac2:
> >>>>>
> >>>>>     pseries: Update SLOF firmware image (2020-02-17 13:08:59 +1100)
> >>>>>
> >>>>> ----------------------------------------------------------------
> >>>>> Alexey Kardashevskiy (1):
> >>>>>         pseries: Update SLOF firmware image
> >>>>>
> >>>>>    pc-bios/README   |   2 +-
> >>>>>    pc-bios/slof.bin | Bin 931032 -> 968560 bytes
> >>>>>    roms/SLOF        |   2 +-
> >>>>>    3 files changed, 2 insertions(+), 2 deletions(-)
> >>>>
> >>>> I only received the cover, not the patch, have you posted it?
> >>>
> >>> OK I see the SLOF binary is almost 1MB. Maybe this got blocked by spam
> >>> filter. FYI you can use 'git-format-patch --no-binary' to emit the patch
> >>> with the commit description but without the content.
> >>
> >> Generally Alexey sends SLOF updates to me just as pull requests
> >> without patches in full, because a huge slab of base64 encoded
> >> firmware isn't particularly illuminating.
> > 
> > I understand, this is why I later suggested Alexey to use
> > 'git-format-patch --no-binary', because Laszlo uses it for EDK2
> > submodule, this allow to quickly review the change on the list (without
> > posting the base64), see:
> > 
> > https://www.mail-archive.com/qemu-devel@nongnu.org/msg624429.html
> > (pull-request cover)
> > 
> > https://www.mail-archive.com/qemu-devel@nongnu.org/msg624432.html
> > "roms/edk2: update submodule"
> > 
> > https://www.mail-archive.com/qemu-devel@nongnu.org/msg624435.html
> > "pc-bios: refresh edk2 build artifacts"
> 
> I am not quite sure where to fit this "git-format-patch". I run now "git
> request-pull" and "git send-email" so am I expected to run format-patch
> and post it as a patchset but with the pull request mail as a cover
> letter? This does not seem very useful though. For today, I'll add the
> change log to the pull request mail. Thanks,

Most git format-patch options can also be passed to git send-email,
and it will pass them through.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

The following changes since commit af9264da80073435fd78944bc5a46e695897d7e5:

  Merge tag '20231119-xtensa-1' of https://github.com/OSLL/qemu-xtensa into staging (2023-11-20 05:25:19 -0500)

are available in the Git repository at:

  git@github.com:aik/qemu.git tags/qemu-slof-20231121

for you to fetch changes up to b6838bf9c01c32bfecd5c446c98e788bbfd467d9:

  pseries: Update SLOF firmware image (2023-11-21 19:11:31 +1100)

----------------------------------------------------------------
Alexey Kardashevskiy (1):
      pseries: Update SLOF firmware image

 pc-bios/README   |   2 +-
 pc-bios/slof.bin | Bin 995176 -> 995000 bytes
 roms/SLOF        |   2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)


*** Note: this is not for master, this is for pseries

Just an update, nothing major. Thanks everyone for keeping
an eye on this!

Compiled with  gcc-12.1.0-nolibc

Tested with:
 /home/aik/b/q-slof/qemu-system-ppc64 \
-nodefaults \
-chardev stdio,id=STDIO0,signal=off,mux=on \
-device spapr-vty,id=svty0,reg=0x71000110,chardev=STDIO0 \
-mon id=MON0,chardev=STDIO0,mode=readline \
-nographic \
-vga none \
-m 4G \
-kernel /home/aik/t/vml4150le \
-initrd /home/aik/t/le.cpio \
-machine pseries,cap-cfpc=broken,cap-sbbc=broken,cap-ibs=broken,cap-ccf-assist=off \
-bios pc-bios/slof.bin \
-trace events=/home/aik/qemu_trace_events \
-d guest_errors \
-chardev socket,id=SOCKET0,server=on,wait=off,path=qemu.mon.60616 \
-mon chardev=SOCKET0,mode=control \
-name 60616,debug-threads=on


The complete change log is:

Alexey Kardashevskiy (3):
      Remove ?PICK
      version: update to 20230918
      version: update to 20231121

Bernhard M. Wiedemann (1):
      Allow to override build date with SOURCE_DATE_EPOCH

Jordan Niethe (1):
      virtio-serial: Do not close stdout on quiesce

Kautuk Consul (1):
      virtio-serial: Make read and write methods report failure

Thomas Huth (10):
      lib/libnet/ipv6: Silence compiler warning from Clang
      Fix typos in the board-qemu folder
      Fix typos in the lib/libnet folder
      Fix typos in the remaining lib folders
      Fix typos in the slof folder
      Fix typos in the board-js2x folder
      Fix typos in the llfw folder
      Fix typos in the board-js2x folder
      Fix typos in the clients folder
      Fix remaining typos in various folders

[PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

The following changes since commit 005ad32358f12fe9313a4a01918a55e60d4f39e5:

  Merge tag 'pull-tpm-2023-09-12-3' of https://github.com/stefanberger/qemu-tpm into staging (2023-09-13 13:41:57 -0400)

are available in the Git repository at:

  git@github.com:aik/qemu.git tags/qemu-slof-20230918

for you to fetch changes up to b4f872c6bcbf71f60326988c76b240318c51bd16:

  pseries: Update SLOF firmware image (2023-09-18 19:14:44 +1000)

----------------------------------------------------------------
Alexey Kardashevskiy (1):
      pseries: Update SLOF firmware image

 pc-bios/README   |   2 +-
 pc-bios/slof.bin | Bin 995176 -> 995000 bytes
 roms/SLOF        |   2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)


*** Note: this is not for master, this is for pseries

It's been a while. This fixes compile warning, typos and
a bug with virtio-serial being used after it was shutdown
at "quiesce".

The full changelog is here:

Alexey Kardashevskiy (2):
      Remove ?PICK
      version: update to 20230918

Jordan Niethe (1):
      virtio-serial: Do not close stdout on quiesce

Kautuk Consul (1):
      virtio-serial: Make read and write methods report failure

Thomas Huth (10):
      lib/libnet/ipv6: Silence compiler warning from Clang
      Fix typos in the board-qemu folder
      Fix typos in the lib/libnet folder
      Fix typos in the remaining lib folders
      Fix typos in the slof folder
      Fix typos in the board-js2x folder
      Fix typos in the llfw folder
      Fix typos in the board-js2x folder
      Fix typos in the clients folder
      Fix remaining typos in various folders

Compiled with gcc-12.1.0-nolibc

Tested with (sorry, no KVM):

/home/aik/b/q-slof/qemu-system-ppc64 \
-nodefaults \
-chardev stdio,id=STDIO0,signal=off,mux=on \
-device spapr-vty,id=svty0,reg=0x71000110,chardev=STDIO0 \
-mon id=MON0,chardev=STDIO0,mode=readline \
-nographic \
-vga none \
-m 2G \
-kernel /home/aik/t/vml4150le \
-initrd /home/aik/t/le.cpio \
-machine pseries,cap-cfpc=broken,cap-sbbc=broken,cap-ibs=broken,cap-ccf-assist=off \
-bios pc-bios/slof.bin \
-trace events=/home/aik/qemu_trace_events \
-d guest_errors \
-chardev socket,id=SOCKET0,server=on,wait=off,path=qemu.mon.604650 \
-mon chardev=SOCKET0,mode=control \
-name 604650,debug-threads=on

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Stefan Hajnoczi]

On Thu, 21 Jul 2022 at 05:06, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> On 21/07/2022 18:48, Peter Maydell wrote:
> > On Thu, 21 Jul 2022 at 09:19, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> >> On 21/07/2022 02:08, Daniel Henrique Barboza wrote:
> >>> Hey,
> >>>
> >>> On 7/19/22 04:59, Alexey Kardashevskiy wrote:
> >>>> Alexey Kardashevskiy (1):
> >>>>         pseries: Update SLOF firmware image
> >>>>
> >>>>    docs/system/ppc/pseries.rst |   2 +-
> >>>>    pc-bios/README              |   2 +-
> >>>>    pc-bios/slof.bin            | Bin 992384 -> 995176 bytes
> >>>>    roms/SLOF                   |   2 +-
> >>>>    4 files changed, 3 insertions(+), 3 deletions(-)
> >>>>
> >>>>
> >>>> *** Note: this is not for master, this is for pseries
> >>>> *** Note2: this has not sync'd to git.qemu.org but softfreeze is
> >>>> too soon so I am posting it anyway.
> >>>
> >>> I forgot to send a reply yesterday, sorry.
> >>>
> >>> Don't worry about rushing this SLOF pull. Given that this build doesn't
> >>> have bug fixes we can wait to pull it in 7.2. You'll have the time to
> >>> sync it up with git.qemu.org and so on.
> >>
> >>
> >> Well, the git.qemu.org is still not updated, and I have no control over
> >> this process anyway, who manages it?
> >
> > Syncing of those git repos is supposed to be automatic, but
> > occasionally something falls over. Stefan, who looks after
> > the sync process ?
> >
> > Alexey, which specific repo is not syncing ?
>
>
> https://git.qemu.org/git/SLOF.git from git@github.com:aik/SLOF.git
>
> For example, the latest is:
> https://github.com/aik/SLOF/releases/tag/qemu-slof-20220719
>
> But it has not made it to where git.qemu.org redirects to:
> https://gitlab.com/qemu-project/SLOF

Hi Alexey,
I have manually pushed the qemu-slof-20220719 tag and latest master to
QEMU's GitLab mirror.

The automatic GitLab mirror job should work. We just don't have much
control over it and maybe it got stuck ~6 days ago and couldn't pick
up your latest changes. Please let me know if you have mirroring
issues again in the future.

Thanks,
Stefan

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 652 bytes --]

On Thu, Jul 21, 2022, 14:52 Peter Maydell <peter.maydell@linaro.org> wrote:

> On Thu, 21 Jul 2022 at 19:41, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> > The SLOF repo was last synced automatically 6 days ago. I'm unable to
> > start a new sync operation and maybe the current one is stuck (the web
> > interface claims the sync is currently updating...).
> >
> > Peter: are you able to fetch https://github.com/aik/SLOF and push to
> > https://gitlab.com/qemu-project/SLOF to manually sync the repo?
>
> End-of-week for me, but I can look at it on Monday...
>

I will sync it manually tomorrow.

Have a nice weekend!

Stefan

>
> thanks
> -- PMM
>

[-- Attachment #2: Type: text/html, Size: 1556 bytes --]

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Peter Maydell]

On Thu, 21 Jul 2022 at 19:41, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> The SLOF repo was last synced automatically 6 days ago. I'm unable to
> start a new sync operation and maybe the current one is stuck (the web
> interface claims the sync is currently updating...).
>
> Peter: are you able to fetch https://github.com/aik/SLOF and push to
> https://gitlab.com/qemu-project/SLOF to manually sync the repo?

End-of-week for me, but I can look at it on Monday...

thanks
-- PMM

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Stefan Hajnoczi]

On Thu, 21 Jul 2022 at 04:49, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Thu, 21 Jul 2022 at 09:19, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> > On 21/07/2022 02:08, Daniel Henrique Barboza wrote:
> > > Hey,
> > >
> > > On 7/19/22 04:59, Alexey Kardashevskiy wrote:
> > >> Alexey Kardashevskiy (1):
> > >>        pseries: Update SLOF firmware image
> > >>
> > >>   docs/system/ppc/pseries.rst |   2 +-
> > >>   pc-bios/README              |   2 +-
> > >>   pc-bios/slof.bin            | Bin 992384 -> 995176 bytes
> > >>   roms/SLOF                   |   2 +-
> > >>   4 files changed, 3 insertions(+), 3 deletions(-)
> > >>
> > >>
> > >> *** Note: this is not for master, this is for pseries
> > >> *** Note2: this has not sync'd to git.qemu.org but softfreeze is
> > >> too soon so I am posting it anyway.
> > >
> > > I forgot to send a reply yesterday, sorry.
> > >
> > > Don't worry about rushing this SLOF pull. Given that this build doesn't
> > > have bug fixes we can wait to pull it in 7.2. You'll have the time to
> > > sync it up with git.qemu.org and so on.
> >
> >
> > Well, the git.qemu.org is still not updated, and I have no control over
> > this process anyway, who manages it?
>
> Syncing of those git repos is supposed to be automatic, but
> occasionally something falls over. Stefan, who looks after
> the sync process ?

I can help out with GitLab repo syncing. It should work for existing
qemu-project group repos. We currently cannot set up syncing for new
repos because qemu-project is in the GitLab Free tier.

The SLOF repo was last synced automatically 6 days ago. I'm unable to
start a new sync operation and maybe the current one is stuck (the web
interface claims the sync is currently updating...).

Peter: are you able to fetch https://github.com/aik/SLOF and push to
https://gitlab.com/qemu-project/SLOF to manually sync the repo?

I currently don't have easy access to my ssh key but let me know if
you can't and I'll see what I can do. Tomorrow I should have access
again.

Thanks,
Stefan


Stefan

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

On 21/07/2022 18:48, Peter Maydell wrote:
> On Thu, 21 Jul 2022 at 09:19, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
>> On 21/07/2022 02:08, Daniel Henrique Barboza wrote:
>>> Hey,
>>>
>>> On 7/19/22 04:59, Alexey Kardashevskiy wrote:
>>>> Alexey Kardashevskiy (1):
>>>>         pseries: Update SLOF firmware image
>>>>
>>>>    docs/system/ppc/pseries.rst |   2 +-
>>>>    pc-bios/README              |   2 +-
>>>>    pc-bios/slof.bin            | Bin 992384 -> 995176 bytes
>>>>    roms/SLOF                   |   2 +-
>>>>    4 files changed, 3 insertions(+), 3 deletions(-)
>>>>
>>>>
>>>> *** Note: this is not for master, this is for pseries
>>>> *** Note2: this has not sync'd to git.qemu.org but softfreeze is
>>>> too soon so I am posting it anyway.
>>>
>>> I forgot to send a reply yesterday, sorry.
>>>
>>> Don't worry about rushing this SLOF pull. Given that this build doesn't
>>> have bug fixes we can wait to pull it in 7.2. You'll have the time to
>>> sync it up with git.qemu.org and so on.
>>
>>
>> Well, the git.qemu.org is still not updated, and I have no control over
>> this process anyway, who manages it?
> 
> Syncing of those git repos is supposed to be automatic, but
> occasionally something falls over. Stefan, who looks after
> the sync process ?
> 
> Alexey, which specific repo is not syncing ?


https://git.qemu.org/git/SLOF.git from git@github.com:aik/SLOF.git

For example, the latest is:
https://github.com/aik/SLOF/releases/tag/qemu-slof-20220719

But it has not made it to where git.qemu.org redirects to:
https://gitlab.com/qemu-project/SLOF


-- 
Alexey

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Peter Maydell]

On Thu, 21 Jul 2022 at 09:19, Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> On 21/07/2022 02:08, Daniel Henrique Barboza wrote:
> > Hey,
> >
> > On 7/19/22 04:59, Alexey Kardashevskiy wrote:
> >> Alexey Kardashevskiy (1):
> >>        pseries: Update SLOF firmware image
> >>
> >>   docs/system/ppc/pseries.rst |   2 +-
> >>   pc-bios/README              |   2 +-
> >>   pc-bios/slof.bin            | Bin 992384 -> 995176 bytes
> >>   roms/SLOF                   |   2 +-
> >>   4 files changed, 3 insertions(+), 3 deletions(-)
> >>
> >>
> >> *** Note: this is not for master, this is for pseries
> >> *** Note2: this has not sync'd to git.qemu.org but softfreeze is
> >> too soon so I am posting it anyway.
> >
> > I forgot to send a reply yesterday, sorry.
> >
> > Don't worry about rushing this SLOF pull. Given that this build doesn't
> > have bug fixes we can wait to pull it in 7.2. You'll have the time to
> > sync it up with git.qemu.org and so on.
>
>
> Well, the git.qemu.org is still not updated, and I have no control over
> this process anyway, who manages it?

Syncing of those git repos is supposed to be automatic, but
occasionally something falls over. Stefan, who looks after
the sync process ?

Alexey, which specific repo is not syncing ?

thanks
-- PMM

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

On 21/07/2022 02:08, Daniel Henrique Barboza wrote:
> Hey,
> 
> On 7/19/22 04:59, Alexey Kardashevskiy wrote:
>> The following changes since commit 
>> d2066bc50d690a6605307eaf0e72a9cf51e6fc25:
>>
>>    target/ppc: Check page dir/table base alignment (2022-07-18 
>> 13:59:43 -0300)
>>
>> are available in the Git repository at:
>>
>>    git@github.com:aik/qemu.git tags/qemu-slof-20220719
>>
>> for you to fetch changes up to 17c1ad657904787b1d986fb4c85431fee006a6ea:
>>
>>    pseries: Update SLOF firmware image (2022-07-19 17:50:46 +1000)
>>
>> ----------------------------------------------------------------
>> Alexey Kardashevskiy (1):
>>        pseries: Update SLOF firmware image
>>
>>   docs/system/ppc/pseries.rst |   2 +-
>>   pc-bios/README              |   2 +-
>>   pc-bios/slof.bin            | Bin 992384 -> 995176 bytes
>>   roms/SLOF                   |   2 +-
>>   4 files changed, 3 insertions(+), 3 deletions(-)
>>
>>
>> *** Note: this is not for master, this is for pseries
>> *** Note2: this has not sync'd to git.qemu.org but softfreeze is
>> too soon so I am posting it anyway.
> 
> I forgot to send a reply yesterday, sorry.
> 
> Don't worry about rushing this SLOF pull. Given that this build doesn't
> have bug fixes we can wait to pull it in 7.2. You'll have the time to
> sync it up with git.qemu.org and so on.


Well, the git.qemu.org is still not updated, and I have no control over 
this process anyway, who manages it?


> 
> Thanks,
> 
> 
> Daniel
> 
>>
>>
>> The image grew in size because of change of the toolchain from
>> native PPC to cross on x86.
>>
>>
>> The only change is that now SLOF can also boot big endian zImage
>> but kernel-addr=0 is still required.
>>
>>

-- 
Alexey

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Daniel Henrique Barboza]

Hey,

On 7/19/22 04:59, Alexey Kardashevskiy wrote:
> The following changes since commit d2066bc50d690a6605307eaf0e72a9cf51e6fc25:
> 
>    target/ppc: Check page dir/table base alignment (2022-07-18 13:59:43 -0300)
> 
> are available in the Git repository at:
> 
>    git@github.com:aik/qemu.git tags/qemu-slof-20220719
> 
> for you to fetch changes up to 17c1ad657904787b1d986fb4c85431fee006a6ea:
> 
>    pseries: Update SLOF firmware image (2022-07-19 17:50:46 +1000)
> 
> ----------------------------------------------------------------
> Alexey Kardashevskiy (1):
>        pseries: Update SLOF firmware image
> 
>   docs/system/ppc/pseries.rst |   2 +-
>   pc-bios/README              |   2 +-
>   pc-bios/slof.bin            | Bin 992384 -> 995176 bytes
>   roms/SLOF                   |   2 +-
>   4 files changed, 3 insertions(+), 3 deletions(-)
> 
> 
> *** Note: this is not for master, this is for pseries
> *** Note2: this has not sync'd to git.qemu.org but softfreeze is
> too soon so I am posting it anyway.

I forgot to send a reply yesterday, sorry.

Don't worry about rushing this SLOF pull. Given that this build doesn't
have bug fixes we can wait to pull it in 7.2. You'll have the time to
sync it up with git.qemu.org and so on.


Thanks,


Daniel

> 
> 
> The image grew in size because of change of the toolchain from
> native PPC to cross on x86.
> 
> 
> The only change is that now SLOF can also boot big endian zImage
> but kernel-addr=0 is still required.
> 
> 

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

oops wrong maintainer :)



On 19/07/2022 17:59, Alexey Kardashevskiy wrote:
> The following changes since commit d2066bc50d690a6605307eaf0e72a9cf51e6fc25:
> 
>    target/ppc: Check page dir/table base alignment (2022-07-18 13:59:43 -0300)
> 
> are available in the Git repository at:
> 
>    git@github.com:aik/qemu.git tags/qemu-slof-20220719
> 
> for you to fetch changes up to 17c1ad657904787b1d986fb4c85431fee006a6ea:
> 
>    pseries: Update SLOF firmware image (2022-07-19 17:50:46 +1000)
> 
> ----------------------------------------------------------------
> Alexey Kardashevskiy (1):
>        pseries: Update SLOF firmware image
> 
>   docs/system/ppc/pseries.rst |   2 +-
>   pc-bios/README              |   2 +-
>   pc-bios/slof.bin            | Bin 992384 -> 995176 bytes
>   roms/SLOF                   |   2 +-
>   4 files changed, 3 insertions(+), 3 deletions(-)
> 
> 
> *** Note: this is not for master, this is for pseries
> *** Note2: this has not sync'd to git.qemu.org but softfreeze is
> too soon so I am posting it anyway.
> 
> 
> The image grew in size because of change of the toolchain from
> native PPC to cross on x86.
> 
> 
> The only change is that now SLOF can also boot big endian zImage
> but kernel-addr=0 is still required.
> 

-- 
Alexey

[PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

The following changes since commit d2066bc50d690a6605307eaf0e72a9cf51e6fc25:

  target/ppc: Check page dir/table base alignment (2022-07-18 13:59:43 -0300)

are available in the Git repository at:

  git@github.com:aik/qemu.git tags/qemu-slof-20220719

for you to fetch changes up to 17c1ad657904787b1d986fb4c85431fee006a6ea:

  pseries: Update SLOF firmware image (2022-07-19 17:50:46 +1000)

----------------------------------------------------------------
Alexey Kardashevskiy (1):
      pseries: Update SLOF firmware image

 docs/system/ppc/pseries.rst |   2 +-
 pc-bios/README              |   2 +-
 pc-bios/slof.bin            | Bin 992384 -> 995176 bytes
 roms/SLOF                   |   2 +-
 4 files changed, 3 insertions(+), 3 deletions(-)


*** Note: this is not for master, this is for pseries
*** Note2: this has not sync'd to git.qemu.org but softfreeze is
too soon so I am posting it anyway.


The image grew in size because of change of the toolchain from
native PPC to cross on x86.


The only change is that now SLOF can also boot big endian zImage
but kernel-addr=0 is still required.

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

I just pushed another update to SLOF but before I do pull request - I 
usually wait for it to sync up with git.qemu.org but the syncing does 
not seem happening this time, is that still supposed to work like that 
with gitlab too?


On 10/01/2022 16:04, Alexey Kardashevskiy wrote:
> The following changes since commit 0625c7760d5451d7436ef0738f763c6bb5141919:
> 
>    target/ppc: do not call hreg_compute_hflags() in helper_store_mmcr0() (2022-01-04 07:55:35 +0100)
> 
> are available in the Git repository at:
> 
>    git@github.com:aik/qemu.git tags/qemu-slof-20220110
> 
> for you to fetch changes up to 1c127fa8e2ff2b034ebf8e50faea2bbc5136afd2:
> 
>    pseries: Update SLOF firmware image (2022-01-10 15:31:14 +1100)
> 
> ----------------------------------------------------------------
> Alexey Kardashevskiy (1):
>        pseries: Update SLOF firmware image
> 
>   pc-bios/README   |   2 +-
>   pc-bios/slof.bin | Bin 991920 -> 992384 bytes
>   roms/SLOF        |   2 +-
>   3 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> *** Note: this is not for master, this is for pseries
> 
> The only change is that SLOF is compiled with -mcpu=power5
> to make it work on PPC970 too.
> 

-- 
Alexey

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Cédric Le Goater]

On 1/10/22 06:04, Alexey Kardashevskiy wrote:
> The following changes since commit 0625c7760d5451d7436ef0738f763c6bb5141919:
> 
>    target/ppc: do not call hreg_compute_hflags() in helper_store_mmcr0() (2022-01-04 07:55:35 +0100)
> 
> are available in the Git repository at:
> 
>    git@github.com:aik/qemu.git tags/qemu-slof-20220110
> 
> for you to fetch changes up to 1c127fa8e2ff2b034ebf8e50faea2bbc5136afd2:
> 
>    pseries: Update SLOF firmware image (2022-01-10 15:31:14 +1100)
> 
> ----------------------------------------------------------------
> Alexey Kardashevskiy (1):
>        pseries: Update SLOF firmware image
> 
>   pc-bios/README   |   2 +-
>   pc-bios/slof.bin | Bin 991920 -> 992384 bytes
>   roms/SLOF        |   2 +-
>   3 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> *** Note: this is not for master, this is for pseries
> 
> The only change is that SLOF is compiled with -mcpu=power5
> to make it work on PPC970 too.
> 
> 


Applied to ppc7.0.

Thanks,

C.

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Cédric Le Goater]

On 1/10/22 06:04, Alexey Kardashevskiy wrote:
> The following changes since commit 0625c7760d5451d7436ef0738f763c6bb5141919:
> 
>    target/ppc: do not call hreg_compute_hflags() in helper_store_mmcr0() (2022-01-04 07:55:35 +0100)
> 
> are available in the Git repository at:
> 
>    git@github.com:aik/qemu.git tags/qemu-slof-20220110
> 
> for you to fetch changes up to 1c127fa8e2ff2b034ebf8e50faea2bbc5136afd2:
> 
>    pseries: Update SLOF firmware image (2022-01-10 15:31:14 +1100)
> 
> ----------------------------------------------------------------
> Alexey Kardashevskiy (1):
>        pseries: Update SLOF firmware image
> 
>   pc-bios/README   |   2 +-
>   pc-bios/slof.bin | Bin 991920 -> 992384 bytes
>   roms/SLOF        |   2 +-
>   3 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> *** Note: this is not for master, this is for pseries
> 
> The only change is that SLOF is compiled with -mcpu=power5
> to make it work on PPC970 too.

P5+ also. See below.

Thanks,

C.


   root@vm24:~# dmesg
   [    0.000000] hash-mmu: Page sizes from device-tree:
   [    0.000000] hash-mmu: base_shift=12: shift=12, sllp=0x0000, avpnm=0x00000000, tlbiel=1, penc=0
   [    0.000000] Relocation on exceptions not supported
   [    0.000000] Page orders: linear mapping = 12, virtual = 12, io = 12, vmemmap = 12
   [    0.000000] hash-mmu: Initializing hash mmu with SLB
   [    0.000000] Linux version 5.15.0-2-powerpc64 (debian-kernel@lists.debian.org) (gcc-11 (Debian 11.2.0-13) 11.2.0, GNU ld (GNU Binutils for Debian) 2.37) #1 SMP Debian 5.15.5-2 (2021-12-18)
   [    0.000000] Found initrd at 0xc000000003e00000:0xc0000000059d559e
   ...
   
   root@vm24:~# cat /proc/cpuinfo
   processor	: 0
   cpu		: POWER5+ (gs)
   clock		: 1000.000000MHz
   revision	: 2.1 (pvr 003b 0201)
   
   processor	: 1
   cpu		: POWER5+ (gs)
   clock		: 1000.000000MHz
   revision	: 2.1 (pvr 003b 0201)
   
   processor	: 2
   cpu		: POWER5+ (gs)
   clock		: 1000.000000MHz
   revision	: 2.1 (pvr 003b 0201)
   
   processor	: 3
   cpu		: POWER5+ (gs)
   clock		: 1000.000000MHz
   revision	: 2.1 (pvr 003b 0201)
   
   timebase	: 512000000
   platform	: pSeries
   model		: IBM pSeries (emulated by qemu)
   machine	: CHRP IBM pSeries (emulated by qemu)
   MMU		: Hash
   root@vm24:~# lspci
   00:01.0 SCSI storage controller: Red Hat, Inc. Virtio SCSI
   00:02.0 Ethernet controller: Red Hat, Inc. Virtio network device
   00:04.0 USB controller: Red Hat, Inc. QEMU XHCI Host Controller (rev 01)
   00:05.0 Unclassified device [00ff]: Red Hat, Inc. Virtio RNG
   00:09.0 Unclassified device [00ff]: Red Hat, Inc. Virtio memory balloon
   

[PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

The following changes since commit 0625c7760d5451d7436ef0738f763c6bb5141919:

  target/ppc: do not call hreg_compute_hflags() in helper_store_mmcr0() (2022-01-04 07:55:35 +0100)

are available in the Git repository at:

  git@github.com:aik/qemu.git tags/qemu-slof-20220110

for you to fetch changes up to 1c127fa8e2ff2b034ebf8e50faea2bbc5136afd2:

  pseries: Update SLOF firmware image (2022-01-10 15:31:14 +1100)

----------------------------------------------------------------
Alexey Kardashevskiy (1):
      pseries: Update SLOF firmware image

 pc-bios/README   |   2 +-
 pc-bios/slof.bin | Bin 991920 -> 992384 bytes
 roms/SLOF        |   2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)


*** Note: this is not for master, this is for pseries

The only change is that SLOF is compiled with -mcpu=power5
to make it work on PPC970 too.

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Cédric Le Goater]

  
> No need to rebase if Alexey sends his pullreq once v6.2 is out.

Yeah. We might do that Alexey. No hurries.

Thanks,

C.

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Philippe Mathieu-Daudé]

On 11/17/21 09:49, Cédric Le Goater wrote:
> On 11/17/21 09:39, Richard Henderson wrote:
>> On 11/16/21 11:48 PM, Alexey Kardashevskiy wrote:
>>> Yup. I am doing SLOF updates this way for ages after diifs became
>>> quite huge to make mailman barfing on the size, and the "subsystem"
>>> in the subj was the way to reduce the noise Peter had to respond to :)
>>>
>>> btw should I be signing those? I am not now.
>>
>> You could if you and Cedric want to do so (is it really Alexey sending
>> the sub pr and not an impostor with access to the same github
>> account?), but it will not leave a permanent record in the mainline
>> history, because the merge object with the signature will be removed
>> by any rebase.
> 
> 
> Yes. I just noticed that the merge commit is lost :
> 
> 2021-11-09 15:50 +0100 Christophe Lombard                     o
> [ppc-7.0] {origin/ppc-7.0} pci-host: Allow extended config space access
> for PowerNV PHB4 model
> 2021-11-16 17:39 +0100 Cédric Le Goater                       M─┐ Merge
> tag 'qemu-slof-20211112' of github.com:aik/qemu into ppc-7.0
> 2021-11-13 14:47 +1100 Alexey Kardashevskiy                   │ o
> pseries: Update SLOF firmware image
> 2021-11-12 12:28 +0100 Richard Henderson                      M─│─┐
> Merge tag 'pull-ppc-20211112' of https://github.com/legoater/qemu into
> staging
> 2021-11-10 17:25 -0300 Daniel Henrique Barboza                │ o─┘
> {origin/ppc-for-upstream} {origin/ppc-next} <pull-ppc-20211112>
> ppc/mmu_helper.c: do not truncate 'ea
> ...
> 
> After rebase :
> 
> 2021-11-09 15:50 +0100 Christophe Lombard                     o
> [ppc-7.0] pci-host: Allow extended config space access for PowerNV PHB4
> model
> 2021-11-13 14:47 +1100 Alexey Kardashevskiy                   o pseries:
> Update SLOF firmware image
> 2021-11-16 21:07 +0100 Richard Henderson                      o Update
> version for v6.2.0-rc1 release
> 2021-11-16 18:55 +0100 Richard Henderson                      M─┐ Merge
> tag 'pull-nbd-2021-11-16' of https://repo.or.cz/qemu/ericb into staging
> ...

No need to rebase if Alexey sends his pullreq once v6.2 is out.

> Alexey's commit appears in the list with only his SoB and we loose :
> 
>     Merge tag 'qemu-slof-20211112' of github.com:aik/qemu into ppc-7.0
> 
>     * tag 'qemu-slof-20211112' of github.com:aik/qemu:
>       pseries: Update SLOF firmware image
> 
>     Signed-off-by: Cédric Le Goater <clg@kaod.org>
> 
> which I find interesting to identify where the SLOF blob is coming from.
> 
> 
> Thanks,
> 
> C.
> 

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

On 17/11/2021 19:49, Cédric Le Goater wrote:
> On 11/17/21 09:39, Richard Henderson wrote:
>> On 11/16/21 11:48 PM, Alexey Kardashevskiy wrote:
>>> Yup. I am doing SLOF updates this way for ages after diifs became 
>>> quite huge to make mailman barfing on the size, and the "subsystem" 
>>> in the subj was the way to reduce the noise Peter had to respond to :)
>>>
>>> btw should I be signing those? I am not now.
>>
>> You could if you and Cedric want to do so (is it really Alexey sending 
>> the sub pr and not an impostor with access to the same github 
>> account?), but it will not leave a permanent record in the mainline 
>> history, because the merge object with the signature will be removed 
>> by any rebase.
> 
> 
> Yes. I just noticed that the merge commit is lost :
> 
> 2021-11-09 15:50 +0100 Christophe Lombard                     o 
> [ppc-7.0] {origin/ppc-7.0} pci-host: Allow extended config space access 
> for PowerNV PHB4 model
> 2021-11-16 17:39 +0100 Cédric Le Goater                       M─┐ Merge 
> tag 'qemu-slof-20211112' of github.com:aik/qemu into ppc-7.0
> 2021-11-13 14:47 +1100 Alexey Kardashevskiy                   │ o 
> pseries: Update SLOF firmware image
> 2021-11-12 12:28 +0100 Richard Henderson                      M─│─┐ 
> Merge tag 'pull-ppc-20211112' of https://github.com/legoater/qemu into 
> staging
> 2021-11-10 17:25 -0300 Daniel Henrique Barboza                │ o─┘ 
> {origin/ppc-for-upstream} {origin/ppc-next} <pull-ppc-20211112> 
> ppc/mmu_helper.c: do not truncate 'ea
> ...
> 
> After rebase :
> 
> 2021-11-09 15:50 +0100 Christophe Lombard                     o 
> [ppc-7.0] pci-host: Allow extended config space access for PowerNV PHB4 
> model
> 2021-11-13 14:47 +1100 Alexey Kardashevskiy                   o pseries: 
> Update SLOF firmware image
> 2021-11-16 21:07 +0100 Richard Henderson                      o Update 
> version for v6.2.0-rc1 release
> 2021-11-16 18:55 +0100 Richard Henderson                      M─┐ Merge 
> tag 'pull-nbd-2021-11-16' of https://repo.or.cz/qemu/ericb into staging
> ...
> 
> Alexey's commit appears in the list with only his SoB and we loose :
> 
>      Merge tag 'qemu-slof-20211112' of github.com:aik/qemu into ppc-7.0
> 
>      * tag 'qemu-slof-20211112' of github.com:aik/qemu:
>        pseries: Update SLOF firmware image
> 
>      Signed-off-by: Cédric Le Goater <clg@kaod.org>
> 
> which I find interesting to identify where the SLOF blob is coming from.


Well, this is a feature of "git rebase" :) The only reliably treceable 
way I see is storing slof.bin in the SLOF tree.


-- 
Alexey

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Cédric Le Goater]

On 11/17/21 09:39, Richard Henderson wrote:
> On 11/16/21 11:48 PM, Alexey Kardashevskiy wrote:
>> Yup. I am doing SLOF updates this way for ages after diifs became quite huge to make mailman barfing on the size, and the "subsystem" in the subj was the way to reduce the noise Peter had to respond to :)
>>
>> btw should I be signing those? I am not now.
> 
> You could if you and Cedric want to do so (is it really Alexey sending the sub pr and not an impostor with access to the same github account?), but it will not leave a permanent record in the mainline history, because the merge object with the signature will be removed by any rebase.


Yes. I just noticed that the merge commit is lost :

2021-11-09 15:50 +0100 Christophe Lombard                     o [ppc-7.0] {origin/ppc-7.0} pci-host: Allow extended config space access for PowerNV PHB4 model
2021-11-16 17:39 +0100 Cédric Le Goater                       M─┐ Merge tag 'qemu-slof-20211112' of github.com:aik/qemu into ppc-7.0
2021-11-13 14:47 +1100 Alexey Kardashevskiy                   │ o pseries: Update SLOF firmware image
2021-11-12 12:28 +0100 Richard Henderson                      M─│─┐ Merge tag 'pull-ppc-20211112' of https://github.com/legoater/qemu into staging
2021-11-10 17:25 -0300 Daniel Henrique Barboza                │ o─┘ {origin/ppc-for-upstream} {origin/ppc-next} <pull-ppc-20211112> ppc/mmu_helper.c: do not truncate 'ea
...

After rebase :

2021-11-09 15:50 +0100 Christophe Lombard                     o [ppc-7.0] pci-host: Allow extended config space access for PowerNV PHB4 model
2021-11-13 14:47 +1100 Alexey Kardashevskiy                   o pseries: Update SLOF firmware image
2021-11-16 21:07 +0100 Richard Henderson                      o Update version for v6.2.0-rc1 release
2021-11-16 18:55 +0100 Richard Henderson                      M─┐ Merge tag 'pull-nbd-2021-11-16' of https://repo.or.cz/qemu/ericb into staging
...

Alexey's commit appears in the list with only his SoB and we loose :

     Merge tag 'qemu-slof-20211112' of github.com:aik/qemu into ppc-7.0

     * tag 'qemu-slof-20211112' of github.com:aik/qemu:
       pseries: Update SLOF firmware image

     Signed-off-by: Cédric Le Goater <clg@kaod.org>

which I find interesting to identify where the SLOF blob is coming from.


Thanks,

C.

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Richard Henderson]

On 11/16/21 11:48 PM, Alexey Kardashevskiy wrote:
> Yup. I am doing SLOF updates this way for ages after diifs became quite huge to make 
> mailman barfing on the size, and the "subsystem" in the subj was the way to reduce the 
> noise Peter had to respond to :)
> 
> btw should I be signing those? I am not now.

You could if you and Cedric want to do so (is it really Alexey sending the sub pr and not 
an impostor with access to the same github account?), but it will not leave a permanent 
record in the mainline history, because the merge object with the signature will be 
removed by any rebase.


r~

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

On 17/11/2021 04:28, Richard Henderson wrote:
> On 11/16/21 6:12 PM, Philippe Mathieu-Daudé wrote:
>> On 11/16/21 17:46, Cédric Le Goater wrote:
>>> On 11/14/21 01:51, Alexey Kardashevskiy wrote:
>>>> The following changes since commit
>>>> d139786e1b3d67991e6cb49a8a59bb2182350285:
>>>>
>>>>     ppc/mmu_helper.c: do not truncate 'ea' in
>>>> booke206_invalidate_ea_tlb() (2021-11-11 11:35:13 +0100)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>>     git@github.com:aik/qemu.git tags/qemu-slof-20211112
>>>>
>>>> for you to fetch changes up to 
>>>> 73944a4bf4ab259b489af8128b4aec525484d642:
>>>>
>>>>     pseries: Update SLOF firmware image (2021-11-13 14:47:56 +1100)
>>>>
>>>> ----------------------------------------------------------------
>>>> Alexey Kardashevskiy (1):
>>>>         pseries: Update SLOF firmware image
>>>>
>>>>    pc-bios/README   |   2 +-
>>>>    pc-bios/slof.bin | Bin 991744 -> 991920 bytes
>>>>    roms/SLOF        |   2 +-
>>>>    3 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> Queued for 7.0.
>>
>> I am not sure this is a good idea, as this will make bisection
>> painful over the release tag.
> 
> It is my understanding that Cedric will rebase for the mainline PR.  At 
> least that's how David was handling subsystem pulls.

Yup. I am doing SLOF updates this way for ages after diifs became quite 
huge to make mailman barfing on the size, and the "subsystem" in the 
subj was the way to reduce the noise Peter had to respond to :)

btw should I be signing those? I am not now.


-- 
Alexey

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Cédric Le Goater]

>>>>> Queued for 7.0.
>>>>
>>>> I am not sure this is a good idea, as this will make bisection
>>>> painful over the release tag.
>>>
>>> It is my understanding that Cedric will rebase for the mainline PR.
>>> At least that's how David was handling subsystem pulls.
>>
>> Yes. I don't plan to send a PR on tree without rebasing. I am just
>> collecting now.
> 
> Oh this is not a signed subsystem pull request, so you can rebase, OK.

I didn't know that. I understand your concern now.

Thanks,

C.

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Philippe Mathieu-Daudé]

On 11/16/21 18:30, Cédric Le Goater wrote:
> On 11/16/21 18:28, Richard Henderson wrote:
>> On 11/16/21 6:12 PM, Philippe Mathieu-Daudé wrote:
>>> On 11/16/21 17:46, Cédric Le Goater wrote:
>>>> On 11/14/21 01:51, Alexey Kardashevskiy wrote:
>>>>> The following changes since commit
>>>>> d139786e1b3d67991e6cb49a8a59bb2182350285:
>>>>>
>>>>>     ppc/mmu_helper.c: do not truncate 'ea' in
>>>>> booke206_invalidate_ea_tlb() (2021-11-11 11:35:13 +0100)
>>>>>
>>>>> are available in the Git repository at:
>>>>>
>>>>>     git@github.com:aik/qemu.git tags/qemu-slof-20211112
>>>>>
>>>>> for you to fetch changes up to
>>>>> 73944a4bf4ab259b489af8128b4aec525484d642:
>>>>>
>>>>>     pseries: Update SLOF firmware image (2021-11-13 14:47:56 +1100)
>>>>>
>>>>> ----------------------------------------------------------------
>>>>> Alexey Kardashevskiy (1):
>>>>>         pseries: Update SLOF firmware image
>>>>>
>>>>>    pc-bios/README   |   2 +-
>>>>>    pc-bios/slof.bin | Bin 991744 -> 991920 bytes
>>>>>    roms/SLOF        |   2 +-
>>>>>    3 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> Queued for 7.0.
>>>
>>> I am not sure this is a good idea, as this will make bisection
>>> painful over the release tag.
>>
>> It is my understanding that Cedric will rebase for the mainline PR. 
>> At least that's how David was handling subsystem pulls.
> 
> Yes. I don't plan to send a PR on tree without rebasing. I am just
> collecting now.

Oh this is not a signed subsystem pull request, so you can rebase, OK.

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Cédric Le Goater]

On 11/16/21 18:28, Richard Henderson wrote:
> On 11/16/21 6:12 PM, Philippe Mathieu-Daudé wrote:
>> On 11/16/21 17:46, Cédric Le Goater wrote:
>>> On 11/14/21 01:51, Alexey Kardashevskiy wrote:
>>>> The following changes since commit
>>>> d139786e1b3d67991e6cb49a8a59bb2182350285:
>>>>
>>>>     ppc/mmu_helper.c: do not truncate 'ea' in
>>>> booke206_invalidate_ea_tlb() (2021-11-11 11:35:13 +0100)
>>>>
>>>> are available in the Git repository at:
>>>>
>>>>     git@github.com:aik/qemu.git tags/qemu-slof-20211112
>>>>
>>>> for you to fetch changes up to 73944a4bf4ab259b489af8128b4aec525484d642:
>>>>
>>>>     pseries: Update SLOF firmware image (2021-11-13 14:47:56 +1100)
>>>>
>>>> ----------------------------------------------------------------
>>>> Alexey Kardashevskiy (1):
>>>>         pseries: Update SLOF firmware image
>>>>
>>>>    pc-bios/README   |   2 +-
>>>>    pc-bios/slof.bin | Bin 991744 -> 991920 bytes
>>>>    roms/SLOF        |   2 +-
>>>>    3 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> Queued for 7.0.
>>
>> I am not sure this is a good idea, as this will make bisection
>> painful over the release tag.
> 
> It is my understanding that Cedric will rebase for the mainline PR.  
> At least that's how David was handling subsystem pulls.

Yes. I don't plan to send a PR on tree without rebasing. I am just
collecting now.

Thanks,

C.

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Richard Henderson]

On 11/16/21 6:12 PM, Philippe Mathieu-Daudé wrote:
> On 11/16/21 17:46, Cédric Le Goater wrote:
>> On 11/14/21 01:51, Alexey Kardashevskiy wrote:
>>> The following changes since commit
>>> d139786e1b3d67991e6cb49a8a59bb2182350285:
>>>
>>>     ppc/mmu_helper.c: do not truncate 'ea' in
>>> booke206_invalidate_ea_tlb() (2021-11-11 11:35:13 +0100)
>>>
>>> are available in the Git repository at:
>>>
>>>     git@github.com:aik/qemu.git tags/qemu-slof-20211112
>>>
>>> for you to fetch changes up to 73944a4bf4ab259b489af8128b4aec525484d642:
>>>
>>>     pseries: Update SLOF firmware image (2021-11-13 14:47:56 +1100)
>>>
>>> ----------------------------------------------------------------
>>> Alexey Kardashevskiy (1):
>>>         pseries: Update SLOF firmware image
>>>
>>>    pc-bios/README   |   2 +-
>>>    pc-bios/slof.bin | Bin 991744 -> 991920 bytes
>>>    roms/SLOF        |   2 +-
>>>    3 files changed, 2 insertions(+), 2 deletions(-)
>>
>> Queued for 7.0.
> 
> I am not sure this is a good idea, as this will make bisection
> painful over the release tag.

It is my understanding that Cedric will rebase for the mainline PR.  At least that's how 
David was handling subsystem pulls.


r~

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Philippe Mathieu-Daudé]

On 11/16/21 17:46, Cédric Le Goater wrote:
> On 11/14/21 01:51, Alexey Kardashevskiy wrote:
>> The following changes since commit
>> d139786e1b3d67991e6cb49a8a59bb2182350285:
>>
>>    ppc/mmu_helper.c: do not truncate 'ea' in
>> booke206_invalidate_ea_tlb() (2021-11-11 11:35:13 +0100)
>>
>> are available in the Git repository at:
>>
>>    git@github.com:aik/qemu.git tags/qemu-slof-20211112
>>
>> for you to fetch changes up to 73944a4bf4ab259b489af8128b4aec525484d642:
>>
>>    pseries: Update SLOF firmware image (2021-11-13 14:47:56 +1100)
>>
>> ----------------------------------------------------------------
>> Alexey Kardashevskiy (1):
>>        pseries: Update SLOF firmware image
>>
>>   pc-bios/README   |   2 +-
>>   pc-bios/slof.bin | Bin 991744 -> 991920 bytes
>>   roms/SLOF        |   2 +-
>>   3 files changed, 2 insertions(+), 2 deletions(-)
> 
> Queued for 7.0.

I am not sure this is a good idea, as this will make bisection
painful over the release tag.

Alexey, do you mind reposting after v7.0 is released?

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Cédric Le Goater]

On 11/14/21 01:51, Alexey Kardashevskiy wrote:
> The following changes since commit d139786e1b3d67991e6cb49a8a59bb2182350285:
> 
>    ppc/mmu_helper.c: do not truncate 'ea' in booke206_invalidate_ea_tlb() (2021-11-11 11:35:13 +0100)
> 
> are available in the Git repository at:
> 
>    git@github.com:aik/qemu.git tags/qemu-slof-20211112
> 
> for you to fetch changes up to 73944a4bf4ab259b489af8128b4aec525484d642:
> 
>    pseries: Update SLOF firmware image (2021-11-13 14:47:56 +1100)
> 
> ----------------------------------------------------------------
> Alexey Kardashevskiy (1):
>        pseries: Update SLOF firmware image
> 
>   pc-bios/README   |   2 +-
>   pc-bios/slof.bin | Bin 991744 -> 991920 bytes
>   roms/SLOF        |   2 +-
>   3 files changed, 2 insertions(+), 2 deletions(-)

Queued for 7.0.

Thanks,

C.

[PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

The following changes since commit d139786e1b3d67991e6cb49a8a59bb2182350285:

  ppc/mmu_helper.c: do not truncate 'ea' in booke206_invalidate_ea_tlb() (2021-11-11 11:35:13 +0100)

are available in the Git repository at:

  git@github.com:aik/qemu.git tags/qemu-slof-20211112

for you to fetch changes up to 73944a4bf4ab259b489af8128b4aec525484d642:

  pseries: Update SLOF firmware image (2021-11-13 14:47:56 +1100)

----------------------------------------------------------------
Alexey Kardashevskiy (1):
      pseries: Update SLOF firmware image

 pc-bios/README   |   2 +-
 pc-bios/slof.bin | Bin 991744 -> 991920 bytes
 roms/SLOF        |   2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)


*** Note: this is not for master, this is for pseries

This has really just one fix from Stefan, the rest is housekeeping.

The full changelog is:

Alexey Kardashevskiy (3):
      Revert "make: Define default rule for .c when V=1 or V=2"
      js2x: Fix compile and cleanup
      version: update to 20211112

Stefan Berger (1):
      tcgbios: Disable platform hierarchy in case of failure

Thomas Huth (8):
      Mention the CR vs. LF problem in the documentation
      slof/fs/accept: Replace TABs with spaces
      Fix the URL to the Linux kernel coding style
      lib/libc/README.txt: Fix "cannel" typo
      travis.yml: Fix keywords
      travis.yml: Update to Focal Fossa
      travis.yml: Compile-test the qemu build
      Silence some trivial compiler warning in the js2x code

[PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

The following changes since commit 82123b756a1a2f1965350e5794aaa7b5c6a15282:

  target/ppc: Support for H_RPT_INVALIDATE hcall (2021-07-09 11:01:06 +1000)

are available in the Git repository at:

  git@github.com:aik/qemu.git tags/qemu-slof-20210711

for you to fetch changes up to 13a20db82f3d177a348ac9839e30ece66dfa40f7:

  pseries: Update SLOF firmware image (2021-07-12 00:05:05 +1000)

----------------------------------------------------------------
Alexey Kardashevskiy (1):
      pseries: Update SLOF firmware image

 pc-bios/README   |   2 +-
 pc-bios/slof.bin | Bin 968888 -> 991744 bytes
 roms/SLOF        |   2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)


*** Note: this is not for master, this is for pseries

This is all about TPM fixes and improvements.

The change log is:

Alexey Kardashevskiy (2):
      tcgbios: Fix warnings
      version: update to 20210711

Stefan Berger (9):
      tcgbios: Fix details in log entries
      tcgbios: Fix a typo in the sha256 algo description
      tcgbios: Add implementations for sha1, sha384, and sha512
      tpm: Add firmware API call 2HASH-EXT-LOG
      tcgbios: Change format of S_CRTM_VERSION string to ucs-2
      tcgbios: Use assembly for 32 bit rotr in sha256
      tcgbios: Use The proper sha function for each PCR bank
      tcgbios: Add test cases and test script to run them
      Travis: Add script for running tests on Travis

Thomas Huth (1):
      Fix bad header guard in version.h

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1886 bytes --]

On Fri, Feb 19, 2021 at 03:13:33PM +1100, Alexey Kardashevskiy wrote:
> The following changes since commit ef450767d7d162dec67ec4674f85f9044a3d80cc:
> 
>   spapr_drc.c: do not call spapr_drc_detach() in drc_isolate_logical() (2021-02-17 11:50:21 +1100)
> 
> are available in the Git repository at:
> 
>   git@github.com:aik/qemu.git tags/qemu-slof-20210217
> 
> for you to fetch changes up to 7745df3b2bc512e71badb52f8f07452260ad7409:
> 
>   pseries: Update SLOF firmware image (2021-02-19 14:56:39 +1100)

Merged into ppc-for-6.0, thanks.

> 
> ----------------------------------------------------------------
> Alexey Kardashevskiy (1):
>       pseries: Update SLOF firmware image
> 
>  pc-bios/README   |   2 +-
>  pc-bios/slof.bin | Bin 968368 -> 968888 bytes
>  roms/SLOF        |   2 +-
>  3 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> *** Note: this is not for master, this is for pseries
> 
> This is mostly compiler warnings fixed but while doing this,
> a bug in MIN() in tcgbios was found.
> 
> Alexey Kardashevskiy (14):
>       helpers: Define MIN()
>       libc: Compile with -Wextra
>       elf: Compile with -Wextra
>       usb: Compile with -Wextra
>       veth: Compile with -Wextra
>       virtio: Compile with -Wextra
>       e1000: Compile with -Wextra
>       libnet: Compile with -Wextra
>       libhv: Compile with -Wextra
>       libnvram: Compile with -Wextra
>       libtpm: Compile with -Wextra
>       slof/prim: Compile with -Wextra
>       Makefile: Actually compile with -Wextra
>       version: update to 20210217
> 
> Thomas Huth (1):
>       virtio-serial: Remove superfluous serial-* words
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

The following changes since commit ef450767d7d162dec67ec4674f85f9044a3d80cc:

  spapr_drc.c: do not call spapr_drc_detach() in drc_isolate_logical() (2021-02-17 11:50:21 +1100)

are available in the Git repository at:

  git@github.com:aik/qemu.git tags/qemu-slof-20210217

for you to fetch changes up to 7745df3b2bc512e71badb52f8f07452260ad7409:

  pseries: Update SLOF firmware image (2021-02-19 14:56:39 +1100)

----------------------------------------------------------------
Alexey Kardashevskiy (1):
      pseries: Update SLOF firmware image

 pc-bios/README   |   2 +-
 pc-bios/slof.bin | Bin 968368 -> 968888 bytes
 roms/SLOF        |   2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)


*** Note: this is not for master, this is for pseries

This is mostly compiler warnings fixed but while doing this,
a bug in MIN() in tcgbios was found.

Alexey Kardashevskiy (14):
      helpers: Define MIN()
      libc: Compile with -Wextra
      elf: Compile with -Wextra
      usb: Compile with -Wextra
      veth: Compile with -Wextra
      virtio: Compile with -Wextra
      e1000: Compile with -Wextra
      libnet: Compile with -Wextra
      libhv: Compile with -Wextra
      libnvram: Compile with -Wextra
      libtpm: Compile with -Wextra
      slof/prim: Compile with -Wextra
      Makefile: Actually compile with -Wextra
      version: update to 20210217

Thomas Huth (1):
      virtio-serial: Remove superfluous serial-* words

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 2080 bytes --]

On Fri, Jul 17, 2020 at 01:27:05PM +1000, Alexey Kardashevskiy wrote:
> The following changes since commit 1038a309ec829f05a3a3e52a9951cfdb24dfd02c:
> 
>   spapr: Add a new level of NUMA for GPUs (2020-07-17 10:36:28 +1000)
> 
> are available in the Git repository at:
> 
>   git@github.com:aik/qemu.git tags/qemu-slof-20200717
> 
> for you to fetch changes up to 7f5258dd8327d574de455a2271788474fa25548d:
> 
>   pseries: Update SLOF firmware image (2020-07-17 13:23:00 +1000)

Merged, thanks.

> 
> ----------------------------------------------------------------
> Alexey Kardashevskiy (1):
>       pseries: Update SLOF firmware image
> 
>  pc-bios/README   |   2 +-
>  pc-bios/slof.bin | Bin 965112 -> 968368 bytes
>  roms/SLOF        |   2 +-
>  3 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> *** Note: this is not for master, this is for pseries
> 
> This adds tcgbios (this was posted earlier [1] but got lost)
> and fixes FDT update at ibm,client-architecture-support
> for huge guests.
> 
> The full list of changes:
> 
> Alexey Kardashevskiy (4):
>       make: Define default rule for .c when V=1 or V=2
>       version: update to 20200513
>       fdt: Avoid recursion when traversing tree
>       version: update to 20200717
> 
> Gustavo Romero (1):
>       board-qemu: Fix comment about SLOF start address
> 
> Stefan Berger (6):
>       tcgbios: Only write logs for PCRs that are allocated
>       tcgbios: Fix the vendorInfoSize to be of type uint8_t
>       tcgbios: Add support for SHA3 type of algorithms
>       elf: Implement elf_get_file_size to determine size of an ELF image
>       tcgbios: Implement tpm_hash_log_extend_event_buffer
>       tcgbios: Measure the bootloader file read from disk
> 
> [1] https://patchwork.ozlabs.org/project/qemu-devel/patch/20200513024355.121476-1-aik@ozlabs.ru/
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

The following changes since commit 1038a309ec829f05a3a3e52a9951cfdb24dfd02c:

  spapr: Add a new level of NUMA for GPUs (2020-07-17 10:36:28 +1000)

are available in the Git repository at:

  git@github.com:aik/qemu.git tags/qemu-slof-20200717

for you to fetch changes up to 7f5258dd8327d574de455a2271788474fa25548d:

  pseries: Update SLOF firmware image (2020-07-17 13:23:00 +1000)

----------------------------------------------------------------
Alexey Kardashevskiy (1):
      pseries: Update SLOF firmware image

 pc-bios/README   |   2 +-
 pc-bios/slof.bin | Bin 965112 -> 968368 bytes
 roms/SLOF        |   2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)


*** Note: this is not for master, this is for pseries

This adds tcgbios (this was posted earlier [1] but got lost)
and fixes FDT update at ibm,client-architecture-support
for huge guests.

The full list of changes:

Alexey Kardashevskiy (4):
      make: Define default rule for .c when V=1 or V=2
      version: update to 20200513
      fdt: Avoid recursion when traversing tree
      version: update to 20200717

Gustavo Romero (1):
      board-qemu: Fix comment about SLOF start address

Stefan Berger (6):
      tcgbios: Only write logs for PCRs that are allocated
      tcgbios: Fix the vendorInfoSize to be of type uint8_t
      tcgbios: Add support for SHA3 type of algorithms
      elf: Implement elf_get_file_size to determine size of an ELF image
      tcgbios: Implement tpm_hash_log_extend_event_buffer
      tcgbios: Measure the bootloader file read from disk

[1] https://patchwork.ozlabs.org/project/qemu-devel/patch/20200513024355.121476-1-aik@ozlabs.ru/

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

Ping?

On 13/05/2020 12:43, Alexey Kardashevskiy wrote:
> The following changes since commit 83b700a441ef8303983eed16c244adde8e40e808:
> 
>   target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate() (2020-05-11 11:44:03 +1000)
> 
> are available in the Git repository at:
> 
>   git@github.com:aik/qemu.git tags/qemu-slof-20200513
> 
> for you to fetch changes up to dc5e3ca3fd80048593153636020edae23cc583ac:
> 
>   pseries: Update SLOF firmware image (2020-05-13 12:34:59 +1000)
> 
> ----------------------------------------------------------------
> Alexey Kardashevskiy (1):
>       pseries: Update SLOF firmware image
> 
>  pc-bios/README   |   2 +-
>  pc-bios/slof.bin | Bin 965112 -> 968392 bytes
>  roms/SLOF        |   2 +-
>  3 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> *** Note: this is not for master, this is for pseries
> 
> This adds measuring the bootloader for secure boot and
> some TPM related fixes.
> 
> The full changelog is:
> 
> Alexey Kardashevskiy (2):
>       make: Define default rule for .c when V=1 or V=2
>       version: update to 20200513
> 
> Stefan Berger (6):
>       tcgbios: Only write logs for PCRs that are allocated
>       tcgbios: Fix the vendorInfoSize to be of type uint8_t
>       tcgbios: Add support for SHA3 type of algorithms
>       elf: Implement elf_get_file_size to determine size of an ELF image
>       tcgbios: Implement tpm_hash_log_extend_event_buffer
>       tcgbios: Measure the bootloader file read from disk
> 

-- 
Alexey

[PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

The following changes since commit 83b700a441ef8303983eed16c244adde8e40e808:

  target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate() (2020-05-11 11:44:03 +1000)

are available in the Git repository at:

  git@github.com:aik/qemu.git tags/qemu-slof-20200513

for you to fetch changes up to dc5e3ca3fd80048593153636020edae23cc583ac:

  pseries: Update SLOF firmware image (2020-05-13 12:34:59 +1000)

----------------------------------------------------------------
Alexey Kardashevskiy (1):
      pseries: Update SLOF firmware image

 pc-bios/README   |   2 +-
 pc-bios/slof.bin | Bin 965112 -> 968392 bytes
 roms/SLOF        |   2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)


*** Note: this is not for master, this is for pseries

This adds measuring the bootloader for secure boot and
some TPM related fixes.

The full changelog is:

Alexey Kardashevskiy (2):
      make: Define default rule for .c when V=1 or V=2
      version: update to 20200513

Stefan Berger (6):
      tcgbios: Only write logs for PCRs that are allocated
      tcgbios: Fix the vendorInfoSize to be of type uint8_t
      tcgbios: Add support for SHA3 type of algorithms
      elf: Implement elf_get_file_size to determine size of an ELF image
      tcgbios: Implement tpm_hash_log_extend_event_buffer
      tcgbios: Measure the bootloader file read from disk

[PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

The following changes since commit 736cf607e40674776d752acc201f565723e86045:

  Update version for v5.0.0-rc0 release (2020-03-24 17:50:00 +0000)

are available in the Git repository at:

  git@github.com:aik/qemu.git tags/qemu-slof-20200327

for you to fetch changes up to 78b145a0330b9c44478f7404b97a710e692bfc96:

  pseries: Update SLOF firmware image (2020-03-27 13:58:00 +1100)

----------------------------------------------------------------
Alexey Kardashevskiy (1):
      pseries: Update SLOF firmware image

 pc-bios/README   |   2 +-
 pc-bios/slof.bin | Bin 965008 -> 965112 bytes
 roms/SLOF        |   2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)


*** Note: this is not for master, this is for pseries

This is a single regression fix for for 5.0:

Greg Kurz (1):
      slof: Only close stdout for virtio-serial devices

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]

On Tue, Mar 17, 2020 at 10:33:06AM +1100, Alexey Kardashevskiy wrote:
> The following changes since commit 33dead675695e596b7f32c72e6f6a20390e86d8a:
> 
>   pseries: Update SLOF firmware image (2020-03-13 17:50:44 +1100)
> 
> are available in the Git repository at:
> 
>   git@github.com:aik/qemu.git tags/qemu-slof-20200317
> 
> for you to fetch changes up to b7cf539920376542f03df8337602c3b8974bd1a1:
> 
>   pseries: Update SLOF firmware image (2020-03-17 10:27:34 +1100)
> 
> ----------------------------------------------------------------
> Alexey Kardashevskiy (1):
>       pseries: Update SLOF firmware image
> 
>  pc-bios/README   |   2 +-
>  pc-bios/slof.bin | Bin 968848 -> 965008 bytes
>  roms/SLOF        |   2 +-
>  3 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> *** Note: this is not for master, this is for pseries
> 
> The only change here is moving the decision about rtas-size
> to QEMU.

Merged to ppc-for-5.0, thanks.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

The following changes since commit 33dead675695e596b7f32c72e6f6a20390e86d8a:

  pseries: Update SLOF firmware image (2020-03-13 17:50:44 +1100)

are available in the Git repository at:

  git@github.com:aik/qemu.git tags/qemu-slof-20200317

for you to fetch changes up to b7cf539920376542f03df8337602c3b8974bd1a1:

  pseries: Update SLOF firmware image (2020-03-17 10:27:34 +1100)

----------------------------------------------------------------
Alexey Kardashevskiy (1):
      pseries: Update SLOF firmware image

 pc-bios/README   |   2 +-
 pc-bios/slof.bin | Bin 968848 -> 965008 bytes
 roms/SLOF        |   2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)


*** Note: this is not for master, this is for pseries

The only change here is moving the decision about rtas-size
to QEMU.

[PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

The following changes since commit 0ba04f78e7c37748db89885249a653b28c962bd9:

  ppc/spapr: Move GPRs setup to one place (2020-03-12 10:21:16 +1100)

are available in the Git repository at:

  git@github.com:aik/qemu.git tags/qemu-slof-20200312

for you to fetch changes up to 8b1987b232d0da2df1f33bf9e3e25fcb1874b91d:

  pseries: Update SLOF firmware image (2020-03-12 15:04:40 +1100)

----------------------------------------------------------------
Alexey Kardashevskiy (1):
      pseries: Update SLOF firmware image

 pc-bios/README   |   2 +-
 pc-bios/slof.bin | Bin 968616 -> 968848 bytes
 roms/SLOF        |   2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)


*** Note: this is not for master, this is for pseries


This mainly fixes virtio-serial with and without
enabled iommu-platform.

The full list of changes is:

Alexey Kardashevskiy (3):
      llfw: Fix debug printf warnings
      virtio-serial: Close device completely
      version: update to 20200312

Cédric Le Goater (1):
      virtio: Fix typo in virtio_serial_init()

Greg Kurz (2):
      virtio-serial: Don't override some words
      virtio-serial: Rework shutdown sequence

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

Uff. Forgot to add that his replaces the update tagged as
qemu-slof-20200217, the difference from that is this fixes handling of
64bit ext4 and removes

"disk-label: Try ext2 filesystem when booting from GPT partition"

as it did not help with what I wanted to achieve (zImage loading into
slof from ext4 - there are still problems) and it broke things elsewhere.


On 21/02/2020 14:52, Alexey Kardashevskiy wrote:
> The following changes since commit 438bafcac55308eef4f9029c94dbadd2c7ac3bb7:
> 
>   hw/ppc/virtex_ml507:fix leak of fdevice tree blob (2020-02-21 09:15:04 +1100)
> 
> are available in the Git repository at:
> 
>   git@github.com:aik/qemu.git tags/qemu-slof-20200221
> 
> for you to fetch changes up to fcd350cb4646255845f643cdb1711bb7004038e7:
> 
>   pseries: Update SLOF firmware image (2020-02-21 14:20:23 +1100)
> 
> ----------------------------------------------------------------
> Alexey Kardashevskiy (1):
>       pseries: Update SLOF firmware image
> 
>  pc-bios/README   |   2 +-
>  pc-bios/slof.bin | Bin 931032 -> 968616 bytes
>  roms/SLOF        |   2 +-
>  3 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> *** Note: this is not for master, this is for pseries
> 
> The full changelog is:
> 
> Alexey Kardashevskiy (10):
>       disk-label: Prepare for extenting
>       disk-label: Support Linux GPT partition type
>       ext2: Prepare for extending
>       ext2: Rename group-desc-size
>       ext2: Read size of group descriptors
>       ext2: Read all 64bit of inode number
>       ext2/4: Add basic extent tree support
>       elf64: Add LE64 ABIv1/2 support for loading images to given address
>       fdt: Fix creating new nodes at H_CAS
>       version: update to 20200221
> 
> Greg Kurz (2):
>       fdt: Fix update of "interrupt-controller" node at CAS
>       fdt: Delete nodes of devices removed between boot and CAS
> 
> Stefan Berger (8):
>       slof: Implement SLOF_get_keystroke() and SLOF_reset()
>       slof: Make linker script variables accessible
>       qemu: Make print_version variable accessible
>       tpm: Add TPM CRQ driver implementation
>       tpm: Add sha256 implementation
>       tcgbios: Add TPM 2.0 support and firmware API
>       tcgbios: Implement menu to clear TPM 2 and activate its PCR banks
>       tcgbios: Measure the GPT table
> 

-- 
Alexey

[PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

The following changes since commit 438bafcac55308eef4f9029c94dbadd2c7ac3bb7:

  hw/ppc/virtex_ml507:fix leak of fdevice tree blob (2020-02-21 09:15:04 +1100)

are available in the Git repository at:

  git@github.com:aik/qemu.git tags/qemu-slof-20200221

for you to fetch changes up to fcd350cb4646255845f643cdb1711bb7004038e7:

  pseries: Update SLOF firmware image (2020-02-21 14:20:23 +1100)

----------------------------------------------------------------
Alexey Kardashevskiy (1):
      pseries: Update SLOF firmware image

 pc-bios/README   |   2 +-
 pc-bios/slof.bin | Bin 931032 -> 968616 bytes
 roms/SLOF        |   2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)


*** Note: this is not for master, this is for pseries

The full changelog is:

Alexey Kardashevskiy (10):
      disk-label: Prepare for extenting
      disk-label: Support Linux GPT partition type
      ext2: Prepare for extending
      ext2: Rename group-desc-size
      ext2: Read size of group descriptors
      ext2: Read all 64bit of inode number
      ext2/4: Add basic extent tree support
      elf64: Add LE64 ABIv1/2 support for loading images to given address
      fdt: Fix creating new nodes at H_CAS
      version: update to 20200221

Greg Kurz (2):
      fdt: Fix update of "interrupt-controller" node at CAS
      fdt: Delete nodes of devices removed between boot and CAS

Stefan Berger (8):
      slof: Implement SLOF_get_keystroke() and SLOF_reset()
      slof: Make linker script variables accessible
      qemu: Make print_version variable accessible
      tpm: Add TPM CRQ driver implementation
      tpm: Add sha256 implementation
      tcgbios: Add TPM 2.0 support and firmware API
      tcgbios: Implement menu to clear TPM 2 and activate its PCR banks
      tcgbios: Measure the GPT table

[PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

The following changes since commit 5084c8b76365f4570520e2cb549089ad523dc953:

  ppc/pnv: Drop PnvChipClass::type (2019-12-17 10:59:11 +1100)

are available in the Git repository at:

  git@github.com:aik/qemu.git tags/qemu-slof-20191217

for you to fetch changes up to 37d7f4242316380fb58566f6b667ac7ddbbc22dd:

  pseries: Update SLOF firmware image (2019-12-17 11:32:10 +1100)

----------------------------------------------------------------
Alexey Kardashevskiy (1):
      pseries: Update SLOF firmware image

 pc-bios/README   |   2 +-
 pc-bios/slof.bin | Bin 931040 -> 931032 bytes
 roms/SLOF        |   2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)


*** Note: this is not for master, this is for pseries

[PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

[Alexey Kardashevskiy]

The following changes since commit 1bdc319ab5d289ce6b822e06fb2b13666fd9278e:

  Update version for v4.2.0-rc4 release (2019-12-03 17:56:30 +0000)

are available in the Git repository at:

  git@github.com:aik/qemu.git tags/qemu-slof-20191209

for you to fetch changes up to 5d8e32b0d6b4f1240c240184d5012ec200da65ab:

  pseries: Update SLOF firmware image (2019-12-09 12:08:25 +1100)

----------------------------------------------------------------
Alexey Kardashevskiy (1):
      pseries: Update SLOF firmware image

 pc-bios/README   |   2 +-
 pc-bios/slof.bin | Bin 928552 -> 931040 bytes
 roms/SLOF        |   2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)


*** Note: this is not for master, this is for pseries


I am not quite sure what exactly is a subsystem here (pseries or
pc-bios/slof.bin), either way I hope I have right keywords in
the right places to keep certain mailfilters happy :) Thanks,