Re: [RFC 05/13] ARM: dts: ti: add support for building .dtb files containing symbols

[Tero Kristo <t-kristo@ti.com>]

On 19/04/18 01:43, Rob Herring wrote:
> On Wed, Apr 18, 2018 at 9:20 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> Hi Tero,
>>
>> On Tue, Apr 17, 2018 at 11:10 AM, Tero Kristo <t-kristo@ti.com> wrote:
>>> Symbols in the DTB files are needed so that overlays can be applied
>>> properly. Add support for building TI SoC specific .dtb files, the
>>> source is fetched from parent directory.
>>>
>>> Signed-off-by: Tero Kristo <t-kristo@ti.com>
>>
>> Thanks for your patch!
>>
>>> ---
>>>   arch/arm/boot/dts/ti/Makefile | 5 +++++
>>>   1 file changed, 5 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/ti/Makefile b/arch/arm/boot/dts/ti/Makefile
>>> index b26328b..7d2d411 100644
>>> --- a/arch/arm/boot/dts/ti/Makefile
>>> +++ b/arch/arm/boot/dts/ti/Makefile
>>> @@ -1 +1,6 @@
>>> +DTC_FLAGS += -@ -Wno-reg_format -Wno-avoid_default_addr_size
>>
>> Why the -W options?
>>
>>> +
>>> +$(obj)/%.dtb: $(src)/../%.dts FORCE
>>
>> I guess you want a dependency on $(DTC), too?
> 
> I think that is handled globally already. I did a fix not to long ago.

Globally it is handled, but as you see this is a special rule under the 
TI SoC specific makefile. This is building the .dts files under 
arch/arm/boot/dts/* into arch/arm/boot/dts/ti/ containing the symbol 
info (-@ flag for DTC.)

-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki