From: Matthieu Baerts <matthieu.baerts at tessares.net>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH mptcp-next v2] selftests: mptcp: add link failure test case
Date: Sat, 24 Oct 2020 12:05:17 +0200 [thread overview]
Message-ID: <76abec4c-0056-e328-682c-ad135b979613@tessares.net> (raw)
In-Reply-To: 20201009151117.6672-1-fw@strlen.de
[-- Attachment #1: Type: text/plain, Size: 1639 bytes --]
Hi Florian,
On 09/10/2020 17:11, Florian Westphal wrote:
> Add a test case where a link fails with multiple subflows.
> The expectation is that MPTCP will transmit any data that
> could not be delivered via the failed link on another subflow.
Thank you for these modifications!
(...)
> @@ -279,14 +308,32 @@ run_tests()
> listener_ns="$1"
> connector_ns="$2"
> connect_addr="$3"
> - rm_nr_ns1="${4:-0}"
> - rm_nr_ns2="${5:-0}"
> - speed="${6:-fast}"
> + test_linkfail="$4"
> + rm_nr_ns1="${5:-0}"
> + rm_nr_ns2="${6:-0}"
> + speed="${7:-fast}"
> lret=0
> + oldin=""
> +
> + if [ "$test_linkfail" -eq 1 ];then
> + size=$((RANDOM%1024))
> + size=$((size+1))
> + size=$((size*128)) > +
> + oldin=$(mktemp)
> + cp "$cin" "$oldin"
> + make_file "$cin" "client" $size
This will create one file up to 1024*128 KB = ~131MB when later using
this command:
dd if=/dev/urandom of="$name" bs=1024 count=$size
This file will be duplicated a few times later when doing the transfer:
( cat "$cin" ; (...) ; cat "$cin" ) | \
tee "$cinsent" | \
(...) $mptcp_connect (...) > "$cout"
If I am not mistaken, we then have:
- $cin = max 131MB: initial file
- $cinsent = 2 times $cin
- $sout = $cinsent
→ total: 5*$cin = max 655MB
Was it the intension? Could we reduce the maximum size while keeping the
test valid?
On my side, /tmp is mounted in tmpfs and currently limited to 490M. Just
to know if I need to increase the size of modify the selftest script :)
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
next reply other threads:[~2020-10-24 10:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 10:05 Matthieu Baerts [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-10-24 12:17 [MPTCP] Re: [PATCH mptcp-next v2] selftests: mptcp: add link failure test case Florian Westphal
2020-10-17 7:31 Matthieu Baerts
2020-10-15 0:09 Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76abec4c-0056-e328-682c-ad135b979613@tessares.net \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.