From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1342C6379F for ; Thu, 9 Feb 2023 11:01:20 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.492331.761826 (Exim 4.92) (envelope-from ) id 1pQ4fu-0007No-Lb; Thu, 09 Feb 2023 11:01:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 492331.761826; Thu, 09 Feb 2023 11:01:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4fu-0007Nh-Ic; Thu, 09 Feb 2023 11:01:10 +0000 Received: by outflank-mailman (input) for mailman id 492331; Thu, 09 Feb 2023 11:01:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4ft-0007Nb-Eh for xen-devel@lists.xenproject.org; Thu, 09 Feb 2023 11:01:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pQ4fn-0001Oh-SN; Thu, 09 Feb 2023 11:01:03 +0000 Received: from [54.239.6.186] (helo=[192.168.16.230]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pQ4fn-0004zR-Lu; Thu, 09 Feb 2023 11:01:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=RW106rl1fQFXuUIoFYfUQuUJuq0X/pDgQA2BjdR4iCc=; b=SVpGzDQZgqqy60qrbYCq7Ts67a 0BEOPV5it88qYHoDXwyxoRoAx3eUOJVFyijmFJpIE0SwUsWeQjGSpCyUtZND/EOOZYppq9+KdJ6J+ s8DaiTqwgm2suqW/pZEQddMCGH6GlHlF3bb0FOFj4NUfybi/Y8BmOp801Mm9d1E7Oaq0=; Message-ID: <76b615ea-f899-76fb-6e50-98bd071ebf60@xen.org> Date: Thu, 9 Feb 2023 11:01:01 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 31/40] xen/mpu: disable FIXMAP in MPU system Content-Language: en-US To: Jan Beulich , Penny Zheng Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20230113052914.3845596-1-Penny.Zheng@arm.com> <20230113052914.3845596-32-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 13/01/2023 10:10, Jan Beulich wrote: > On 13.01.2023 06:29, Penny Zheng wrote: >> --- a/xen/arch/arm/Kconfig >> +++ b/xen/arch/arm/Kconfig >> @@ -13,9 +13,10 @@ config ARM >> def_bool y >> select HAS_ALTERNATIVE if !ARM_V8R >> select HAS_DEVICE_TREE >> + select HAS_FIXMAP if !ARM_V8R >> select HAS_PASSTHROUGH >> select HAS_PDX >> - select HAS_PMAP >> + select HAS_PMAP if !ARM_V8R >> select IOMMU_FORCE_PT_SHARE >> select HAS_VMAP if !ARM_V8R > > Thinking about it - wouldn't it make sense to fold HAS_VMAP and HAS_FIXMAP > into a single HAS_MMU? I think it would make sense. Furthermore, this patch would be better towards the start of the series. Cheers, -- Julien Grall