Re: [PATCH 00/19] staging: r8188eu: migrate os_dep/xmit_linux.c

From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Michael Straube <straube.linux@gmail.com>, gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/19] staging: r8188eu: migrate os_dep/xmit_linux.c
Date: Mon, 22 Aug 2022 19:58:55 +0200	[thread overview]
Message-ID: <76b7bb06-8eae-4340-4cf3-d4b39e366307@gmail.com> (raw)
In-Reply-To: <20220820181623.12497-1-straube.linux@gmail.com>

On 8/20/22 20:16, Michael Straube wrote:
> This series moves the functions, or their functionality, from
> os_dep/xmit_linux.c to the core/* part of the driver and finally
> removes os_dep/xmit_linux.c and the xmit_osdep.h header.
> 
> Tested on x86_64 with Inter-Tech DMG-02.
> 
> Please apply this on top of:
> [PATCH] staging: r8188eu: remove rtw_endofpktfile()
> 
> Thanks,
> Michael
> 
> Michael Straube (19):
>    staging: r8188eu: make rtw_remainder_len() static
>    staging: r8188eu: make rtw_os_xmit_schedule() static
>    staging: r8188eu: rename rtw_os_xmit_schedule()
>    staging: r8188eu: make rtw_os_xmit_resource_alloc() static
>    staging: r8188eu: rename rtw_os_xmit_resource_alloc()
>    staging: r8188eu: make rtw_os_xmit_resource_free() static
>    staging: r8188eu: rename rtw_os_xmit_resource_free()
>    staging: r8188eu: make _rtw_open_pktfile() static
>    staging: r8188eu: rename _rtw_open_pktfile()
>    staging: r8188eu: make _rtw_pktfile_read() static
>    staging: r8188eu: rename _rtw_pktfile_read()
>    staging: r8188eu: remove unnecessary initialization to zero
>    staging: r8188eu: move struct pkt_file to rtw_xmit.h
>    staging: r8188eu: move rtw_os_xmit_complete() to rtw_xmit.c
>    staging: r8188eu: rename rtw_os_xmit_complete()
>    staging: r8188eu: make rtw_os_pkt_complete() static
>    staging: r8188eu: rename rtw_os_pkt_complete()
>    staging: r8188eu: remove os_dep/xmit_linux.c
>    staging: r8188eu: remove xmit_osdep.h
> 
>   drivers/staging/r8188eu/Makefile             |   1 -
>   drivers/staging/r8188eu/core/rtw_mlme.c      |  23 +-
>   drivers/staging/r8188eu/core/rtw_mlme_ext.c  |   2 +-
>   drivers/staging/r8188eu/core/rtw_sta_mgt.c   |   1 -
>   drivers/staging/r8188eu/core/rtw_xmit.c      | 232 +++++++++++++++++--
>   drivers/staging/r8188eu/hal/rtl8188eu_xmit.c |   4 +-
>   drivers/staging/r8188eu/include/rtw_xmit.h   |  16 +-
>   drivers/staging/r8188eu/include/xmit_osdep.h |  48 ----
>   drivers/staging/r8188eu/os_dep/os_intfs.c    |   7 +-
>   drivers/staging/r8188eu/os_dep/usb_intf.c    |   1 -
>   drivers/staging/r8188eu/os_dep/xmit_linux.c  | 226 ------------------
>   11 files changed, 251 insertions(+), 310 deletions(-)
>   delete mode 100644 drivers/staging/r8188eu/include/xmit_osdep.h
>   delete mode 100644 drivers/staging/r8188eu/os_dep/xmit_linux.c
> 

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150