From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F433C4332F for ; Mon, 19 Dec 2022 10:48:22 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7Dgg-0005Oo-C2; Mon, 19 Dec 2022 05:48:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7DgY-0005O7-D5; Mon, 19 Dec 2022 05:47:54 -0500 Received: from mail.csgraf.de ([85.25.223.15] helo=zulu616.server4you.de) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7DgV-0003d5-JC; Mon, 19 Dec 2022 05:47:53 -0500 Received: from [192.168.106.118] (dynamic-077-002-090-134.77.2.pool.telefonica.de [77.2.90.134]) by csgraf.de (Postfix) with ESMTPSA id 7A0506080321; Mon, 19 Dec 2022 11:47:42 +0100 (CET) Message-ID: <76c8912f-4fb7-118a-2105-efe08f343f77@csgraf.de> Date: Mon, 19 Dec 2022 11:47:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 1/5] target/arm: only build psci for TCG To: Claudio Fontana , Fabiano Rosas , Peter Maydell Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Richard Henderson , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Paolo Bonzini , Eduardo Habkost References: <20221216212944.28229-2-farosas@suse.de> <459E39B4-44F5-41B2-A595-1B0DB5AD80F3@csgraf.de> <3355a215-dd7a-e80a-ca53-b0d65eb435b5@suse.de> Content-Language: en-US From: Alexander Graf In-Reply-To: <3355a215-dd7a-e80a-ca53-b0d65eb435b5@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=85.25.223.15; envelope-from=agraf@csgraf.de; helo=zulu616.server4you.de X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-1.148, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hey Claudio, On 19.12.22 09:37, Claudio Fontana wrote: > > On 12/16/22 22:59, Alexander Graf wrote: >> Hi Claudio, >> >> If the PSCI implementation becomes TCG only, can we also move to a tcg accel directory? It slowly gets super confusing to keep track of which files are supposed to be generic target code and which ones TCG specific> >> Alex > Hi Alex, Fabiano, Peter and all, > > that was the plan but at the time of: > > https://lore.kernel.org/all/20210416162824.25131-1-cfontana@suse.de/ > > Peter mentioned that HVF AArch64 might use that code too: > > https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg00509.html > > so from v2 to v3 the series changed to not move the code under tcg/ , expecting HVF to be reusing that code "soon". > > I see that your hvf code in hvf/ implements psci, is there some plan to reuse pieces from the tcg implementation now? I originally reused the PSCI code in earlier versions of my hvf patch set, but then we realized that some functions like remote CPU reset are wired in a TCG specific view of the world with full target CPU register ownership. So if we want to actually share it, we'll need to abstract it up a level. Hence I'd suggest to move it to a TCG directory for now and then later move it back into a generic helper if we want / need to. The code just simply isn't generic yet. Or alternatively, you create a patch (set) to actually merge the 2 implementations into a generic one again which then can live at a generic place :) Alex