Re: [Qemu-devel] [PATCH 4/5] migration: Disable hotplug/unplug during migration

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]

On 04/06/2017 08:13 AM, Juan Quintela wrote:
> Until we have reviewed what can/can't be hotplug during migration,

s/hotplug/hotplugged/

> disable it.  We can enable it later for the things that we know that
> work.  For instance, memory hotplug during postcopy don't work

s/don't/doesn't/

> currently.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> 
> --
> 

> @@ -603,6 +604,11 @@ DeviceState *qdev_device_add(QemuOpts *opts, Error **errp)
>          return NULL;
>      }
>  
> +    if (!migration_is_idle()) {
> +        error_setg(errp, "device_add not allowed while migrating");
> +        return NULL;
> +    }
> +
>      /* create device */
>      dev = DEVICE(object_new(driver));
>  
> @@ -853,6 +859,11 @@ void qdev_unplug(DeviceState *dev, Error **errp)
>          return;
>      }
>  
> +    if (!migration_is_idle()) {
> +        error_setg(errp, "device_add not allowed while migrating");

s/device_add/device_del/ ?

> +        return;
> +    }
> +
>      qdev_hot_removed = true;
>  
>      hotplug_ctrl = qdev_get_hotplug_handler(dev);
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]