From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cxVJu-0006Lz-OF for qemu-devel@nongnu.org; Mon, 10 Apr 2017 05:09:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cxVJq-0005wy-Oq for qemu-devel@nongnu.org; Mon, 10 Apr 2017 05:09:10 -0400 Received: from 9.mo179.mail-out.ovh.net ([46.105.76.148]:42265) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cxVJq-0005uj-IK for qemu-devel@nongnu.org; Mon, 10 Apr 2017 05:09:06 -0400 Received: from player690.ha.ovh.net (b6.ovh.net [213.186.33.56]) by mo179.mail-out.ovh.net (Postfix) with ESMTP id B809D3582F for ; Mon, 10 Apr 2017 11:08:57 +0200 (CEST) References: <1491396106-26376-1-git-send-email-clg@kaod.org> <1491396106-26376-12-git-send-email-clg@kaod.org> <20170410051738.GJ27571@umbus> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <76f8a1aa-4f42-098e-ee2a-f2a04af3cb2a@kaod.org> Date: Mon, 10 Apr 2017 11:08:53 +0200 MIME-Version: 1.0 In-Reply-To: <20170410051738.GJ27571@umbus> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 11/21] ppc/pnv: scan ISA bus to populate device tree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 04/10/2017 07:17 AM, David Gibson wrote: > On Wed, Apr 05, 2017 at 02:41:36PM +0200, C=E9dric Le Goater wrote: >> This is an empty shell that we will use to include nodes in the device >> tree for ISA devices. We expect RTC, UART and IPMI BT devices. >> >> Signed-off-by: C=E9dric Le Goater >=20 > This is so simple, I'd probably fold it into the next patch. But > apart from that. yes. I agree. The goal was to find an alternative to qbus_walk_children()= =20 which is not a QOM API.=20 C. > Reviewed-by: David Gibson >=20 >> --- >> hw/ppc/pnv.c | 32 ++++++++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> >> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c >> index 493c7eed7980..a3c8f6594d10 100644 >> --- a/hw/ppc/pnv.c >> +++ b/hw/ppc/pnv.c >> @@ -281,6 +281,36 @@ static void powernv_populate_chip(PnvChip *chip, = void *fdt) >> g_free(typename); >> } >> =20 >> +typedef struct ForeachPopulateArgs { >> + void *fdt; >> + int offset; >> +} ForeachPopulateArgs; >> + >> +static int powernv_populate_isa_device(DeviceState *dev, void *opaque= ) >> +{ >> + return 0; >> +} >> + >> +static void powernv_populate_isa(ISABus *bus, void *fdt) >> +{ >> + int lpc_offset; >> + ForeachPopulateArgs args; >> + >> + lpc_offset =3D fdt_node_offset_by_compatible(fdt, -1, "ibm,lpc"); >> + if (lpc_offset < 0) { >> + error_report("Could find the lpc node !?"); >> + return; >> + } >> + >> + args.fdt =3D fdt; >> + args.offset =3D lpc_offset; >> + >> + /* ISA devices are not necessarily parented to the ISA bus so we >> + * can not use object_child_foreach() */ >> + qbus_walk_children(BUS(bus), powernv_populate_isa_device, >> + NULL, NULL, NULL, &args); >> +} >> + >> static void *powernv_create_fdt(MachineState *machine) >> { >> const char plat_compat[] =3D "qemu,powernv\0ibm,powernv"; >> @@ -328,6 +358,8 @@ static void *powernv_create_fdt(MachineState *mach= ine) >> for (i =3D 0; i < pnv->num_chips; i++) { >> powernv_populate_chip(pnv->chips[i], fdt); >> } >> + >> + powernv_populate_isa(pnv->isa_bus, fdt); >> return fdt; >> } >> =20 >=20