From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752184AbcGUKyv (ORCPT ); Thu, 21 Jul 2016 06:54:51 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:61017 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751641AbcGUKys convert rfc822-to-8bit (ORCPT ); Thu, 21 Jul 2016 06:54:48 -0400 From: Arnd Bergmann To: Wan Zongshun Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Wan Zongshun , Daniel Lezcano , Russell King , linux-kernel@vger.kernel.org, Thomas Gleixner Subject: Re: [PATCH 4/6] irqchip: add irqchip driver for nuc900 Date: Sat, 09 Jul 2016 22:17:06 +0200 Message-ID: <7701071.Nr6sCmDkjL@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <57806E9F.3020407@iommu.org> References: <1466851042-22239-1-git-send-email-vw@iommu.org> <8706947.5rzUDVsB2F@wuerfel> <57806E9F.3020407@iommu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K0:nSeUehvI/b2f5SemfNz3EJsaqG/f7ZvB9ga+0k6NTadFeNJaB6a li5qAFqrawg5I+c+GjKk0HICg34L5cL2d3GxzWSrpttmdJUDFS8ghwnzDiy4/2cBb0oL48C VqcPld48jPGHUv40lxpl9M0IOr/UWXI9rZWtVfJGz0nYDi23sJkQfExIpYs5IAsTDtq+Ydi Sa8d2bBb2HFQ5CQqZDjUg== X-UI-Out-Filterresults: notjunk:1;V01:K0:HKhF4B3gsbY=:G532D2elW+v3sXuUZ+0TYc H1C/JgjBBUoi9vqD8Q2UWGi4Cyz4vvjhJW73GVcgq/sDbqd+QFNhzzrUnb4jBQC5GXEMrZgic 14D2/at7g8uKjUAr+hdutiM+J0H19Jm/JNa58l24Sm8wtOqxDxb/RGjPHyBrcvnrPKN1yvRm5 WtANP27RQqt4kTs7XF1NfU3OskswTvXRuktxMg/6qrVknpcnvk6fD7lRl94wLBEdFLGEmU3Fa UAy2Gwa66KzLDt5IyZYNixTNaCc+XkGzaAPx7HnEzV+Ne3l4zztEo38PVIbTDfur8zhpXE9go 6f3cl8a+X6gdMrc/RJBqvDn2mc0ShauD2nWgBi9gQdIZ0PS7LY7/a3ofqTraXkxGnwjWFXOLw BdfReq5Zx+dal6rDArOj9i7EQSmb9uzk2EDqAu77aiuKPNGthG3MBq7IRj/SjUNF+0mhvNGu2 gzyVeIsityXEBF3GaUIjORZHfGMxR8taGsRV1hiU5ypZ6l83NGHpI3NW539Y4j/e4Pm2kXv53 iO9sN9Lii62M/1ie7ET2cdBo3/jdVXPVbcHQRCVwOdmrM0ddteM0z1Ii/eHHAXObiQvcaID/u heD/BCVQ9ZuEO2roypPqBVdUuVR0u2TNeScSb7FXgONT7pbEZVLRXaGEovWSkzqwFSUdOirJW xzRvRiAnrBGzFW69uTQ0QEXbV41vKpT4zcVLAFBUO+V3G+eyMuNxpjnsXgTM6ljobPlzticKH hzQpTjaB0LPXC6q/ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, July 9, 2016 11:25:19 AM CEST Wan Zongshun wrote: > On 2016年06月29日 23:27, Arnd Bergmann wrote: > > On Saturday, June 25, 2016 6:37:20 PM CEST Wan Zongshun wrote: > >> +#define IRQ_WDT W90X900_IRQ(1) > >> +#define IRQ_WWDT W90X900_IRQ(2) > >> +#define IRQ_LVD W90X900_IRQ(3) > >> +#define IRQ_EXT0 W90X900_IRQ(4) > >> +#define IRQ_EXT1 W90X900_IRQ(5) > >> +#define IRQ_EXT2 W90X900_IRQ(6) > >> +#define IRQ_EXT3 W90X900_IRQ(7) > >> +#define IRQ_EXT4 W90X900_IRQ(8) > >> +#define IRQ_EXT5 W90X900_IRQ(9) > >> +#define IRQ_EXT6 W90X900_IRQ(10) > > > > I'd suggest dropping the list, the contents are now in the dts. > > Arnd, I will drop this file later, since old w90x900 plat still need it. Sure. > but I will remove the Macros related to nuc970 and avoid nuc970 > interrupt using those Macro. > > But I still need hack this irqs.h like below, since here NR_IRQS defined > and it is need for nuc970 irqchip driver. > > #if !defined(CONFIG_SOC_NUC900) > #define NR_IRQS (IRQ_ADC+1) > #else > #define NR_IRQS 62 > #endif Have you considered using CONFIG_SPARSE_IRQ? That would avoid the need for setting NR_IRQS entirely, but may also require more work elsewhere. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 4/6] irqchip: add irqchip driver for nuc900 Date: Sat, 09 Jul 2016 22:17:06 +0200 Message-ID: <7701071.Nr6sCmDkjL@wuerfel> References: <1466851042-22239-1-git-send-email-vw@iommu.org> <8706947.5rzUDVsB2F@wuerfel> <57806E9F.3020407@iommu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <57806E9F.3020407-6ukY98dZOFrYtjvyW6yDsg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wan Zongshun Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wan Zongshun , Daniel Lezcano , Russell King , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thomas Gleixner List-Id: devicetree@vger.kernel.org On Saturday, July 9, 2016 11:25:19 AM CEST Wan Zongshun wrote: > On 2016=E5=B9=B406=E6=9C=8829=E6=97=A5 23:27, Arnd Bergmann wrote: > > On Saturday, June 25, 2016 6:37:20 PM CEST Wan Zongshun wrote: > >> +#define IRQ_WDT W90X900_IRQ(1) > >> +#define IRQ_WWDT W90X900_IRQ(2) > >> +#define IRQ_LVD W90X900_IRQ(3) > >> +#define IRQ_EXT0 W90X900_IRQ(4) > >> +#define IRQ_EXT1 W90X900_IRQ(5) > >> +#define IRQ_EXT2 W90X900_IRQ(6) > >> +#define IRQ_EXT3 W90X900_IRQ(7) > >> +#define IRQ_EXT4 W90X900_IRQ(8) > >> +#define IRQ_EXT5 W90X900_IRQ(9) > >> +#define IRQ_EXT6 W90X900_IRQ(10) > > > > I'd suggest dropping the list, the contents are now in the dts. >=20 > Arnd, I will drop this file later, since old w90x900 plat still need = it. Sure. > but I will remove the Macros related to nuc970 and avoid nuc970=20 > interrupt using those Macro. >=20 > But I still need hack this irqs.h like below, since here NR_IRQS defi= ned=20 > and it is need for nuc970 irqchip driver. >=20 > #if !defined(CONFIG_SOC_NUC900) > #define NR_IRQS (IRQ_ADC+1) > #else > #define NR_IRQS 62 > #endif Have you considered using CONFIG_SPARSE_IRQ? That would avoid the need for setting NR_IRQS entirely, but may also require more work elsewhere. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Sat, 09 Jul 2016 22:17:06 +0200 Subject: [PATCH 4/6] irqchip: add irqchip driver for nuc900 In-Reply-To: <57806E9F.3020407@iommu.org> References: <1466851042-22239-1-git-send-email-vw@iommu.org> <8706947.5rzUDVsB2F@wuerfel> <57806E9F.3020407@iommu.org> Message-ID: <7701071.Nr6sCmDkjL@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Saturday, July 9, 2016 11:25:19 AM CEST Wan Zongshun wrote: > On 2016?06?29? 23:27, Arnd Bergmann wrote: > > On Saturday, June 25, 2016 6:37:20 PM CEST Wan Zongshun wrote: > >> +#define IRQ_WDT W90X900_IRQ(1) > >> +#define IRQ_WWDT W90X900_IRQ(2) > >> +#define IRQ_LVD W90X900_IRQ(3) > >> +#define IRQ_EXT0 W90X900_IRQ(4) > >> +#define IRQ_EXT1 W90X900_IRQ(5) > >> +#define IRQ_EXT2 W90X900_IRQ(6) > >> +#define IRQ_EXT3 W90X900_IRQ(7) > >> +#define IRQ_EXT4 W90X900_IRQ(8) > >> +#define IRQ_EXT5 W90X900_IRQ(9) > >> +#define IRQ_EXT6 W90X900_IRQ(10) > > > > I'd suggest dropping the list, the contents are now in the dts. > > Arnd, I will drop this file later, since old w90x900 plat still need it. Sure. > but I will remove the Macros related to nuc970 and avoid nuc970 > interrupt using those Macro. > > But I still need hack this irqs.h like below, since here NR_IRQS defined > and it is need for nuc970 irqchip driver. > > #if !defined(CONFIG_SOC_NUC900) > #define NR_IRQS (IRQ_ADC+1) > #else > #define NR_IRQS 62 > #endif Have you considered using CONFIG_SPARSE_IRQ? That would avoid the need for setting NR_IRQS entirely, but may also require more work elsewhere. Arnd