All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Wei Yongjun <weiyongjun1@huawei.com>,
	Jon Maloy <jon.maloy@ericsson.com>,
	Ying Xue <ying.xue@windriver.com>,
	Hoang Le <hoang.h.le@dektech.com.au>
Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] tipc: fix return value check in tipc_mcast_send_sync()
Date: Thu, 21 Mar 2019 01:58:41 -0700	[thread overview]
Message-ID: <771238ae-6e47-cac2-7dfe-f44475e90e43@gmail.com> (raw)
In-Reply-To: <20190321085810.96037-1-weiyongjun1@huawei.com>



On 03/21/2019 01:58 AM, Wei Yongjun wrote:
> Fix the return value check which testing the wrong variable
> in tipc_mcast_send_sync().
> 
> Fixes: c55c8edafa91 ("tipc: smooth change between replicast and broadcast")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  net/tipc/bcast.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c
> index 5264a8ff6e01..a41c0fa9c650 100644
> --- a/net/tipc/bcast.c
> +++ b/net/tipc/bcast.c
> @@ -329,7 +329,7 @@ static int tipc_mcast_send_sync(struct net *net, struct sk_buff *skb,
>  
>  	/* Allocate dummy message */
>  	_skb = tipc_buf_acquire(MCAST_H_SIZE, GFP_KERNEL);
> -	if (!skb)
> +	if (!_skb)
>  		return -ENOMEM;
>  
>  	/* Preparing for 'synching' header */
> 
> 
> 

Thanks for the patch, but some 'Reported-by:' tags are missing :/


WARNING: multiple messages have this Message-ID (diff)
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Wei Yongjun <weiyongjun1@huawei.com>,
	Jon Maloy <jon.maloy@ericsson.com>,
	Ying Xue <ying.xue@windriver.com>,
	Hoang Le <hoang.h.le@dektech.com.au>
Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] tipc: fix return value check in tipc_mcast_send_sync()
Date: Thu, 21 Mar 2019 08:58:41 +0000	[thread overview]
Message-ID: <771238ae-6e47-cac2-7dfe-f44475e90e43@gmail.com> (raw)
In-Reply-To: <20190321085810.96037-1-weiyongjun1@huawei.com>



On 03/21/2019 01:58 AM, Wei Yongjun wrote:
> Fix the return value check which testing the wrong variable
> in tipc_mcast_send_sync().
> 
> Fixes: c55c8edafa91 ("tipc: smooth change between replicast and broadcast")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  net/tipc/bcast.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c
> index 5264a8ff6e01..a41c0fa9c650 100644
> --- a/net/tipc/bcast.c
> +++ b/net/tipc/bcast.c
> @@ -329,7 +329,7 @@ static int tipc_mcast_send_sync(struct net *net, struct sk_buff *skb,
>  
>  	/* Allocate dummy message */
>  	_skb = tipc_buf_acquire(MCAST_H_SIZE, GFP_KERNEL);
> -	if (!skb)
> +	if (!_skb)
>  		return -ENOMEM;
>  
>  	/* Preparing for 'synching' header */
> 
> 
> 

Thanks for the patch, but some 'Reported-by:' tags are missing :/

  reply	other threads:[~2019-03-21  8:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21  8:58 [PATCH net-next] tipc: fix return value check in tipc_mcast_send_sync() Wei Yongjun
2019-03-21  8:58 ` Wei Yongjun
2019-03-21  8:58 ` Eric Dumazet [this message]
2019-03-21  8:58   ` Eric Dumazet
2019-03-25  6:31 ` [PATCH net-next v2] " Wei Yongjun
2019-03-25  6:31   ` Wei Yongjun
2019-03-25 16:29   ` Jon Maloy
2019-03-25 16:29     ` Jon Maloy
2019-03-26 18:39   ` David Miller
2019-03-26 18:39     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=771238ae-6e47-cac2-7dfe-f44475e90e43@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=hoang.h.le@dektech.com.au \
    --cc=jon.maloy@ericsson.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tipc-discussion@lists.sourceforge.net \
    --cc=weiyongjun1@huawei.com \
    --cc=ying.xue@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.