From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32344C43381 for ; Thu, 21 Mar 2019 08:58:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F2357218A2 for ; Thu, 21 Mar 2019 08:58:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KPYbTnvs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727953AbfCUI6p (ORCPT ); Thu, 21 Mar 2019 04:58:45 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:44242 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727841AbfCUI6p (ORCPT ); Thu, 21 Mar 2019 04:58:45 -0400 Received: by mail-wr1-f68.google.com with SMTP id w2so5608319wrt.11; Thu, 21 Mar 2019 01:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=K+j80itJMYuiryQx5MgH4nagVSxAowc/8gW1RkvWIpw=; b=KPYbTnvsjv3OKRAEwjayVv5OUuZSdN8yLWS2AmZCa9bbb6X4a1F55jCii/Zq/M7uZ0 HvuF3lHk9YZAdTBUx29g7uEVls4ff/o/JQ5QGfDQNfKBcphWlNyp7C5Dek7UWmy66+8r k0ZYUQXq6RFEOPe47KiRmda6oDsH8RPMWBPXDLycNeH2nFhAxKm+xuQAEw91q0Pt1drk QSBUZHY9y8FHiIl2MiegOCtX+CQOCeAuWDgoarVb1kpwiMNPU227fBB7CmnRSYKy8Hme 38BF8fwqs0qX0Llo3ChZ810E0XoBnZbQ/MNWwTaLoDsj5mtiWJ7rMDE17CPjrGAgOmQh AijA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=K+j80itJMYuiryQx5MgH4nagVSxAowc/8gW1RkvWIpw=; b=lhcg9A7ieJyeBiw2SljH+QuvbtUCd0XI4cmK2M9Z6e/U91If+1UzOfIhCzaQiQDzP2 hQW4gb+3JHZclloS6isSdR5Wm98xIwhOAcdy6KuthYvxObcW2MW9/EKRDxU53ghJjmvM gSqW2gmohqLFsun+SYapRTQohLoKPnznJ42KgSKZdZv/nkEHrQm42X3KmnmOzCOA5TjL j26jSTrDK0MZp6HDoNO6AiBPU/+Cu8YEEXez5XPiiJ0D9q8kMHHRfmOPNNZFG+qtg/TX ETd1QA/bNuVsU98VQDWWk5DsgMzWbVqNzmME3MPfYHMCF8TFdLNF1Bzo4bvRMeA7cHuS Zl/w== X-Gm-Message-State: APjAAAWKFrPp8OFtW9teQgUKiAsJMV8+DpypOupz5vdAUaYTPa38iRWu y7XJky5GCuTmrUWk1h4UFa46JgA6 X-Google-Smtp-Source: APXvYqzpgdTHjiNXC94Kri6wGV/ModtG4LvXGVMmoCmgSYRFoCuJ1fdc55f1ghgh9D6xqsFKpq1mBA== X-Received: by 2002:adf:e547:: with SMTP id z7mr1591919wrm.295.1553158723889; Thu, 21 Mar 2019 01:58:43 -0700 (PDT) Received: from [172.31.96.190] ([195.39.71.253]) by smtp.gmail.com with ESMTPSA id c10sm1609972wru.83.2019.03.21.01.58.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Mar 2019 01:58:43 -0700 (PDT) Subject: Re: [PATCH net-next] tipc: fix return value check in tipc_mcast_send_sync() To: Wei Yongjun , Jon Maloy , Ying Xue , Hoang Le Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, kernel-janitors@vger.kernel.org References: <20190321085810.96037-1-weiyongjun1@huawei.com> From: Eric Dumazet Message-ID: <771238ae-6e47-cac2-7dfe-f44475e90e43@gmail.com> Date: Thu, 21 Mar 2019 01:58:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190321085810.96037-1-weiyongjun1@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 03/21/2019 01:58 AM, Wei Yongjun wrote: > Fix the return value check which testing the wrong variable > in tipc_mcast_send_sync(). > > Fixes: c55c8edafa91 ("tipc: smooth change between replicast and broadcast") > Signed-off-by: Wei Yongjun > --- > net/tipc/bcast.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c > index 5264a8ff6e01..a41c0fa9c650 100644 > --- a/net/tipc/bcast.c > +++ b/net/tipc/bcast.c > @@ -329,7 +329,7 @@ static int tipc_mcast_send_sync(struct net *net, struct sk_buff *skb, > > /* Allocate dummy message */ > _skb = tipc_buf_acquire(MCAST_H_SIZE, GFP_KERNEL); > - if (!skb) > + if (!_skb) > return -ENOMEM; > > /* Preparing for 'synching' header */ > > > Thanks for the patch, but some 'Reported-by:' tags are missing :/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Date: Thu, 21 Mar 2019 08:58:41 +0000 Subject: Re: [PATCH net-next] tipc: fix return value check in tipc_mcast_send_sync() Message-Id: <771238ae-6e47-cac2-7dfe-f44475e90e43@gmail.com> List-Id: References: <20190321085810.96037-1-weiyongjun1@huawei.com> In-Reply-To: <20190321085810.96037-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wei Yongjun , Jon Maloy , Ying Xue , Hoang Le Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, kernel-janitors@vger.kernel.org On 03/21/2019 01:58 AM, Wei Yongjun wrote: > Fix the return value check which testing the wrong variable > in tipc_mcast_send_sync(). > > Fixes: c55c8edafa91 ("tipc: smooth change between replicast and broadcast") > Signed-off-by: Wei Yongjun > --- > net/tipc/bcast.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c > index 5264a8ff6e01..a41c0fa9c650 100644 > --- a/net/tipc/bcast.c > +++ b/net/tipc/bcast.c > @@ -329,7 +329,7 @@ static int tipc_mcast_send_sync(struct net *net, struct sk_buff *skb, > > /* Allocate dummy message */ > _skb = tipc_buf_acquire(MCAST_H_SIZE, GFP_KERNEL); > - if (!skb) > + if (!_skb) > return -ENOMEM; > > /* Preparing for 'synching' header */ > > > Thanks for the patch, but some 'Reported-by:' tags are missing :/