From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 896CEC47257 for ; Tue, 5 May 2020 16:31:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 660FF206FA for ; Tue, 5 May 2020 16:31:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PSRWhVm+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730153AbgEEQbH (ORCPT ); Tue, 5 May 2020 12:31:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729840AbgEEQbG (ORCPT ); Tue, 5 May 2020 12:31:06 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57BFEC061A0F; Tue, 5 May 2020 09:31:06 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id b8so1228475pgi.11; Tue, 05 May 2020 09:31:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hfJ7CD8kT1IxAQsPsr4fznv4yl20HQI5OOnUts3Y7HI=; b=PSRWhVm+KF9bJV+bKC+qaUXSsdqLvJm958luEJ4SlPY3I761Out/MWDDOnIlGmMzPE CqF4cMPzJIcRzNu3KLsfroHFQYw9SCHuklgE1GCpTCr+Dv0lArr+uzDEtXxID4AbVzQi JKuq/S9IXtx8wRzqNG/eeEsRkcb6PAbXaWyMB1i01RKRmMQR/ZtWPZlFGnPgNy4rIeiD 9QM2wu7AMN8aWcGtpJVmvJ3gIbTCFturHjn/d3xUpiVLF0eUn0yW+7mBrz2ZOsdaGmZe up5oLX1k7b5iSjno4IIOAQQtnemXvUtNRBQ2vT/XiuiXcOTymL9hhoncKX+aYV+GBMvo N86w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hfJ7CD8kT1IxAQsPsr4fznv4yl20HQI5OOnUts3Y7HI=; b=ZpR8GE65+rHpfp5oi55oGNS9+p5EQ9YVAoKn50+CIUzqCb1Y9NpxEoCEPivgIcwHET PU0OHrHBQLyOzFGFq31/mwTEowBXwX8Vz7pVxL6HxXfR/aLJWR4vBSq+3xxTIUugSBD0 5+rIzp+uOFsvBtOJg2VZFd6L/vcl9CIlbDmYiMO1QBr66sR5wLcLt94yjhuUR/PIg9sP O0B/CFujLM9+Tcn6NbuFzVzWUsKkDEHTdfyzcAFN/ygSOsu7+5dOWs4rhMi24belg0Ec 65EV3w3zQmrWIYfH6aCnT8PswwSftEnqCf4YcjMQvZoWVFsBXnyhGnM2/IQ6qNyeSLrY YeKw== X-Gm-Message-State: AGi0Pub76SYbs+nM2axWpD24ww39nNxWLbXmi1b7vpelWEBJi82tchDO 2TzAFuIwvnzdYFNavwS+CBLhh7g5 X-Google-Smtp-Source: APiQypLsqZvCUtbY5LmgDxny4jtbsy+eBRYHAzhG0adC0fKtlM2K6mqcontLK4x83hEAyDMOQi8+6w== X-Received: by 2002:a62:4e88:: with SMTP id c130mr4010584pfb.122.1588696265889; Tue, 05 May 2020 09:31:05 -0700 (PDT) Received: from [192.168.86.235] (c-73-241-150-58.hsd1.ca.comcast.net. [73.241.150.58]) by smtp.gmail.com with ESMTPSA id e11sm2348271pfl.85.2020.05.05.09.31.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 May 2020 09:31:05 -0700 (PDT) Subject: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change To: SeongJae Park , Eric Dumazet Cc: David Miller , Al Viro , Jakub Kicinski , Greg Kroah-Hartman , sj38.park@gmail.com, netdev , LKML , SeongJae Park , snu@amazon.com, amit@kernel.org, stable@vger.kernel.org, Paul McKenney References: <20200505161302.547-1-sjpark@amazon.com> <05843a3c-eb9d-3a0d-f992-7e4b97cc1f19@gmail.com> From: Eric Dumazet Message-ID: <77124fc2-86b2-27f6-fd7c-4f1e86eb3fff@gmail.com> Date: Tue, 5 May 2020 09:31:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <05843a3c-eb9d-3a0d-f992-7e4b97cc1f19@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/5/20 9:25 AM, Eric Dumazet wrote: > > > On 5/5/20 9:13 AM, SeongJae Park wrote: >> On Tue, 5 May 2020 09:00:44 -0700 Eric Dumazet wrote: >> >>> On Tue, May 5, 2020 at 8:47 AM SeongJae Park wrote: >>>> >>>> On Tue, 5 May 2020 08:20:50 -0700 Eric Dumazet wrote: >>>> >>>>> >>>>> >>>>> On 5/5/20 8:07 AM, SeongJae Park wrote: >>>>>> On Tue, 5 May 2020 07:53:39 -0700 Eric Dumazet wrote: >>>>>> >>>>> >>>>>>> Why do we have 10,000,000 objects around ? Could this be because of >>>>>>> some RCU problem ? >>>>>> >>>>>> Mainly because of a long RCU grace period, as you guess. I have no idea how >>>>>> the grace period became so long in this case. >>>>>> >>>>>> As my test machine was a virtual machine instance, I guess RCU readers >>>>>> preemption[1] like problem might affected this. >>>>>> >>>>>> [1] https://www.usenix.org/system/files/conference/atc17/atc17-prasad.pdf >>>>>> >>>>>>> >>>>>>> Once Al patches reverted, do you have 10,000,000 sock_alloc around ? >>>>>> >>>>>> Yes, both the old kernel that prior to Al's patches and the recent kernel >>>>>> reverting the Al's patches didn't reproduce the problem. >>>>>> >>>>> >>>>> I repeat my question : Do you have 10,000,000 (smaller) objects kept in slab caches ? >>>>> >>>>> TCP sockets use the (very complex, error prone) SLAB_TYPESAFE_BY_RCU, but not the struct socket_wq >>>>> object that was allocated in sock_alloc_inode() before Al patches. >>>>> >>>>> These objects should be visible in kmalloc-64 kmem cache. >>>> >>>> Not exactly the 10,000,000, as it is only the possible highest number, but I >>>> was able to observe clear exponential increase of the number of the objects >>>> using slabtop. Before the start of the problematic workload, the number of >>>> objects of 'kmalloc-64' was 5760, but I was able to observe the number increase >>>> to 1,136,576. >>>> >>>> OBJS ACTIVE USE OBJ SIZE SLABS OBJ/SLAB CACHE SIZE NAME >>>> before: 5760 5088 88% 0.06K 90 64 360K kmalloc-64 >>>> after: 1136576 1136576 100% 0.06K 17759 64 71036K kmalloc-64 >>>> >>> >>> Great, thanks. >>> >>> How recent is the kernel you are running for your experiment ? >> >> It's based on 5.4.35. >> >>> >>> Let's make sure the bug is not in RCU. >> >> One thing I can currently say is that the grace period passes at last. I >> modified the benchmark to repeat not 10,000 times but only 5,000 times to run >> the test without OOM but easily observable memory pressure. As soon as the >> benchmark finishes, the memory were freed. >> >> If you need more tests, please let me know. >> > > I would ask Paul opinion on this issue, because we have many objects > being freed after RCU grace periods. > > If RCU subsystem can not keep-up, I guess other workloads will also suffer. > > Sure, we can revert patches there and there trying to work around the issue, > but for objects allocated from process context, we should not have these problems. > I wonder if simply adjusting rcu_divisor to 6 or 5 would help diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index d9a49cd6065a20936edbda1b334136ab597cde52..fde833bac0f9f81e8536211b4dad6e7575c1219a 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -427,7 +427,7 @@ module_param(qovld, long, 0444); static ulong jiffies_till_first_fqs = ULONG_MAX; static ulong jiffies_till_next_fqs = ULONG_MAX; static bool rcu_kick_kthreads; -static int rcu_divisor = 7; +static int rcu_divisor = 6; module_param(rcu_divisor, int, 0644); /* Force an exit from rcu_do_batch() after 3 milliseconds. */