From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A85CC433F5 for ; Tue, 19 Oct 2021 09:38:34 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 75CEC6137E for ; Tue, 19 Oct 2021 09:38:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 75CEC6137E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=oktetlabs.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D661C40E5A; Tue, 19 Oct 2021 11:38:32 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id A5BB340683 for ; Tue, 19 Oct 2021 11:38:31 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 427AB7F4FE; Tue, 19 Oct 2021 12:38:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 427AB7F4FE DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1634636311; bh=2C2eEjpve07r4voV1Iy5fCjHSi5pJX7IEbHeDzPmUJI=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=eE/78X9ll3IHSL/j+1bjDDoZZQdS7SqDnTM1f/XZTz5kHdjuHpOhr3HiZOYP/63ls dDmPvsXhHpJxcmdLds8++Ci9u2RKR4PySvnkDSTM2urYhoqVOvuLxudyCDlrN/KLPj p/hIxFo+dV6fwlo6wb59Y9jsJtQ3wNZ6edlXrikI= To: David Marchand , Thomas Monjalon Cc: Olivier Matz , Ray Kinsella , "Artem V. Andreev" , Ashwin Sekhar T K , Pavan Nikhilesh , Hemant Agrawal , Sachin Saxena , Harman Kalra , Jerin Jacob , Nithin Dabilpuram , dev References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru> <20211018144907.1145028-6-andrew.rybchenko@oktetlabs.ru> <86905833-5c40-76ce-3794-ec3c2e447242@oktetlabs.ru> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <771cb36a-abf2-cc5a-72a4-e52f272366a5@oktetlabs.ru> Date: Tue, 19 Oct 2021 12:38:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 5/6] mempool: add namespace to driver register macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/19/21 12:27 PM, David Marchand wrote: > On Tue, Oct 19, 2021 at 11:05 AM Andrew Rybchenko > wrote: >> >> On 10/19/21 11:49 AM, David Marchand wrote: >>> On Mon, Oct 18, 2021 at 4:50 PM Andrew Rybchenko >>> wrote: >>>> >>>> Add RTE_ prefix to macro used to register mempool driver. >>>> The old one is still available but deprecated. >>> >>> ODP seems to use its own mempools. >>> >>> $ git grep-all -w MEMPOOL_REGISTER_OPS >>> OpenDataplane/platform/linux-generic/pktio/dpdk.c:MEMPOOL_REGISTER_OPS(odp_pool_ops); >>> >>> I'd say it counts as a driver macro. >>> If so, we could hide it in a driver-only header, along with >>> rte_mempool_register_ops getting marked as internal. >>> >>> $ git grep-all -w rte_mempool_register_ops >>> FD.io-VPP/src/plugins/dpdk/buffer.c: rte_mempool_register_ops (&ops); >>> FD.io-VPP/src/plugins/dpdk/buffer.c: rte_mempool_register_ops (&ops); >> >> Do I understand correctly that it is required to remove it from >> stable ABI/API, but still allow external SW to use it? >> >> Should I add one more patch to the series? > > If we want to do the full job, we need to inspect driver-only symbols > in rte_mempool.h. > But this goes way further than a simple prefixing as this series intended. > > I just read your reply, I think we agree. > Let's go with simple prefix and take a note to cleanup in the future. Agreed.