All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: dhowells@redhat.com, Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Gilad Ben-Yossef <gilad@benyossef.com>,
	Tobias Markus <tobias@markus-regensburg.de>,
	Tee Hao Wei <angelsl@in04.sg>,
	keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] X.509: Fix crash caused by NULL pointer
Date: Thu, 07 Jan 2021 10:58:02 +0000	[thread overview]
Message-ID: <772253.1610017082@warthog.procyon.org.uk> (raw)
In-Reply-To: <20210107092855.76093-1-tianjia.zhang@linux.alibaba.com>

Tianjia Zhang <tianjia.zhang@linux.alibaba.com> wrote:

> On the following call path, `sig->pkey_algo` is not assigned
> in asymmetric_key_verify_signature(), which causes runtime
> crash in public_key_verify_signature().
> 
>   keyctl_pkey_verify
>     asymmetric_key_verify_signature
>       verify_signature
>         public_key_verify_signature
> 
> This patch simply check this situation and fixes the crash
> caused by NULL pointer.
> 
> Fixes: 215525639631 ("X.509: support OSCCA SM2-with-SM3 certificate verification")
> Cc: stable@vger.kernel.org # v5.10+
> Reported-by: Tobias Markus <tobias@markus-regensburg.de>
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>

Looks reasonable:

Acked-by: David Howells <dhowells@redhat.com>

I wonder, though, if cert_sig_digest_update() should be obtained by some sort
of function pointer.  It doesn't really seem to belong in this file.  But this
is a separate issue.

David


  reply	other threads:[~2021-01-07 10:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07  9:28 [PATCH] X.509: Fix crash caused by NULL pointer Tianjia Zhang
2021-01-07 10:58 ` David Howells [this message]
2021-01-13  3:02   ` Tianjia Zhang
2021-01-13 13:03 David Howells
2021-01-13 13:06 David Howells
2021-01-19  0:13 David Howells
2021-01-21  9:06 hansyao
2021-01-22 12:19  Tan Zhongjun
2021-01-22 13:03 ` Greg KH
2021-01-22 12:24  Tan Zhongjun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=772253.1610017082@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=angelsl@in04.sg \
    --cc=davem@davemloft.net \
    --cc=gilad@benyossef.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tianjia.zhang@linux.alibaba.com \
    --cc=tobias@markus-regensburg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.