From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FC33C4332F for ; Tue, 21 Sep 2021 07:20:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54BC9610E8 for ; Tue, 21 Sep 2021 07:20:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230160AbhIUHVd (ORCPT ); Tue, 21 Sep 2021 03:21:33 -0400 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:36756 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230124AbhIUHVc (ORCPT ); Tue, 21 Sep 2021 03:21:32 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id A8F13402D0 for ; Tue, 21 Sep 2021 07:20:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632208802; bh=AEgBA3R77w9KryrrVCKS+IcMBHSWWQYQcCPJfI9REUY=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=q5I2OKK/BHIgeadXIt4B504ihWDnqoms3PgcGZQGSft7i44IlbxsDlXvkhVjJFIW3 mzYuofJjMvriDGreAPnbacsXV4600h+II6SoC0/cUriDo8/BwzS1MsBO4ZYx1WoBRY Hhiz/tJZjvxtjhGvANGJlRhJ/ZPg4lKfqDYZ6sYHyc267AUtnWybwqolIxF49/bRVf lYGazccFPhBDNT5/WgSwoDgG70BJdUuJOV58O8soOlGA4x2ifxfz2Vbb4dVsBor53I PeZHGG2I7TKlyOocxsFvmTY7QOZVuO5RA0wJ7vMhnXmk2OGAhpLM5q87yNT9wrvMBU JYcuEZT4dxsQQ== Received: by mail-wr1-f70.google.com with SMTP id e1-20020adfa741000000b0015e424fdd01so7581046wrd.11 for ; Tue, 21 Sep 2021 00:20:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AEgBA3R77w9KryrrVCKS+IcMBHSWWQYQcCPJfI9REUY=; b=u172Hl3o0SFQubyKiFUuMjE00MiPYlUfpoUNaDW0MjnpbPhBsxIF9lsfKdMt7i1fV3 CpUYgXQrgH7J24+gT7pj1s2KpCWxKrgkYhqjCFl/fRTQl2v6MWKKm1xhXXwftMRxETzU 7Fw+q2kaN9vCatL600ZpCdalJL33jhzRlsaDLqRA4nhzEFQpggt8NmhEq9Nlz3DqgPqt ik4HyU5vQL7KcICIXRqyH1cH49LynquwYgoGkTFRYPSWkA9shLT9xdZxO9wYZgx8QBy9 D5QwTLeAN3E0XtcKabObH1mzpox3XXky5RA8dPYfUxayrP//OIkQA2vaunDPc4sGpVcx gv7w== X-Gm-Message-State: AOAM532DkLpdJbtdGMvXDxplXMXifYMwYC7JmJbnrIKqUWbo5Ssizbmi 6T4gnOyYB4n6o0FD6fZYddrYlDgxoo/rQOIpKm9fbfyxIWLvs4HQjlXSZoP+omPUD2XIbhp7kFm B/XCmFgLxUvS6ybCexzZk/YUDbZ4aMDaX5s2+doc= X-Received: by 2002:a7b:c750:: with SMTP id w16mr2977696wmk.128.1632208802084; Tue, 21 Sep 2021 00:20:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzO5jz1FEI8gyX7GyxtVi5eDjZZJeMMrwVlptuHEN5O7i5u5mvto6Hcns9xoz5xze1ScI9CPA== X-Received: by 2002:a7b:c750:: with SMTP id w16mr2977671wmk.128.1632208801861; Tue, 21 Sep 2021 00:20:01 -0700 (PDT) Received: from [192.168.0.134] (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id u5sm3543492wrg.57.2021.09.21.00.20.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 00:20:01 -0700 (PDT) Subject: Re: [PATCH v1 0/4] arm64: Kconfig: Update ARCH_EXYNOS select configs To: Will McVicker , Catalin Marinas , Will Deacon , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Linus Walleij , Alessandro Zummo , Alexandre Belloni Cc: Lee Jones , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org References: <20210920190350.3860821-1-willmcvicker@google.com> From: Krzysztof Kozlowski Message-ID: <7735b09c-cf1c-5e37-a737-9a330fbacf1e@canonical.com> Date: Tue, 21 Sep 2021 09:19:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210920190350.3860821-1-willmcvicker@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 20/09/2021 21:03, Will McVicker wrote: > This patch series tries to address the issue of ARCH_EXYNOS force selecting > a handful of drivers without allowing the vendor to override any of the > default configs. This takes away from the flexibilty of compiling a generic > kernel with exynos kernel modules. For example, it doesn't allow vendors to > modularize these drivers out of the core kernel in order to share a generic > kernel image across multiple devices that require device-specific kernel > modules. You do not address the issue in these patches. The problem you describe is that drivers are not modules and you are not changing them into modules. > > To address this without impacting the existing behavior, this series > switches the default config logic for the offending configs to use "default > y if ARCH_EXYNOS" versus having ARCH_EXYNOS directly select them. I have > verified that these patches do not impact the default aarch64 .config. Yep, this is what you did but it does not match the described problem. You are not solving it but doing something else. > > Will McVicker (4): > clk: samsung: change COMMON_CLK_SAMSUNG default config logic > soc: samsung: change SOC_SAMSUNG default config logic > pinctrl: samsung: change PINCTRL_EXYNOS default config logic > rtc: change HAVE_S3C_RTC default config logic > I received only two patches from this set. Please resend following get_maintainers.pl script. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88A5AC433F5 for ; Tue, 21 Sep 2021 07:22:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5673660FE6 for ; Tue, 21 Sep 2021 07:22:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5673660FE6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=XTwxpXNQO/NhsIeKYdwoBOjV2vWW398LJqFywwEbc3A=; b=q6JUwqFGU20L/pJvmothCx8Jtw BXPFwYIzy+bNmpJn6mnM13iNk9zcygPgTcIdWRvBk1ya9hQCPnPNETk4P4/p3SyQJucj1KAke+tCb NZ+s9NqAaEK4fbhk1GQGyDgsDlAtK+hp+GK/hMIlCQ+IE9zy3LP7BmqriNHUa5a17owvipI5U5iPE smexy6zWBBtrrBWV+F2ovLH63+7SF5SQgkdhsdvLZlK/3EiOfCTrPToGv9lLO/ONo0z93jAcBEQX6 MVBeIFfyNXQ2U0/fhdpLqnD0qBqIURw1rRJFPQyI3uZKqg9YJL8VmrRnQVjWb/hI9w5M0+1J+7nn9 kBtePuig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSa4a-003m0U-D2; Tue, 21 Sep 2021 07:20:12 +0000 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSa4X-003lzC-18 for linux-arm-kernel@lists.infradead.org; Tue, 21 Sep 2021 07:20:10 +0000 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 748173F320 for ; Tue, 21 Sep 2021 07:20:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632208802; bh=AEgBA3R77w9KryrrVCKS+IcMBHSWWQYQcCPJfI9REUY=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=q5I2OKK/BHIgeadXIt4B504ihWDnqoms3PgcGZQGSft7i44IlbxsDlXvkhVjJFIW3 mzYuofJjMvriDGreAPnbacsXV4600h+II6SoC0/cUriDo8/BwzS1MsBO4ZYx1WoBRY Hhiz/tJZjvxtjhGvANGJlRhJ/ZPg4lKfqDYZ6sYHyc267AUtnWybwqolIxF49/bRVf lYGazccFPhBDNT5/WgSwoDgG70BJdUuJOV58O8soOlGA4x2ifxfz2Vbb4dVsBor53I PeZHGG2I7TKlyOocxsFvmTY7QOZVuO5RA0wJ7vMhnXmk2OGAhpLM5q87yNT9wrvMBU JYcuEZT4dxsQQ== Received: by mail-wr1-f69.google.com with SMTP id r15-20020adfce8f000000b0015df1098ccbso8054466wrn.4 for ; Tue, 21 Sep 2021 00:20:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AEgBA3R77w9KryrrVCKS+IcMBHSWWQYQcCPJfI9REUY=; b=wb45vTTRQK0dry0nbygn6S5DTFNjgHEABNsq++xTyyeD4cJ+w0kjznu95RF1ZzANMi VujwBmvxUG2/BLHd1zqea6ek1W0JIkTzLi/106O3Y0YYXXnn5tAoq2mTz0ElW7xUOvku Xr4hlslfkPKbFw/fB0krDMu9IHUvBa0aOJ2zmo9+PaBTSZRx4P+S/D9peZWJAOTx5AZX m4jDeKVZdXgUeVgB9L43FGMYkNP75g6P/HcNxsoScgjIzutWVUavn7nW/TMMxO1yyAbI MdEk3T3Je21HGqp/iaJn9hAz6rEQhT1LfnZYLyaHAq8/K9OAvbNV1rjondmYBcBl2bi9 aFKA== X-Gm-Message-State: AOAM531XMvD3GcPZmel4S6lDoqi3LcHND+blNihvVS9UUU0uoSpAySd6 MF2m/VYhZrvKGCZTPExt1z8iIG7X24DwviXxfaaEeFkcJ7LrNc2TToc75NhdkvsyH4B0NcoQEkJ 3IeymHtxhA1NrqucIzmo94utUSBM7I+UDh9KjXg92ni7TeMFlvryl X-Received: by 2002:a7b:c750:: with SMTP id w16mr2977691wmk.128.1632208802084; Tue, 21 Sep 2021 00:20:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzO5jz1FEI8gyX7GyxtVi5eDjZZJeMMrwVlptuHEN5O7i5u5mvto6Hcns9xoz5xze1ScI9CPA== X-Received: by 2002:a7b:c750:: with SMTP id w16mr2977671wmk.128.1632208801861; Tue, 21 Sep 2021 00:20:01 -0700 (PDT) Received: from [192.168.0.134] (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id u5sm3543492wrg.57.2021.09.21.00.20.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 00:20:01 -0700 (PDT) Subject: Re: [PATCH v1 0/4] arm64: Kconfig: Update ARCH_EXYNOS select configs To: Will McVicker , Catalin Marinas , Will Deacon , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Michael Turquette , Stephen Boyd , Linus Walleij , Alessandro Zummo , Alexandre Belloni Cc: Lee Jones , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org References: <20210920190350.3860821-1-willmcvicker@google.com> From: Krzysztof Kozlowski Message-ID: <7735b09c-cf1c-5e37-a737-9a330fbacf1e@canonical.com> Date: Tue, 21 Sep 2021 09:19:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210920190350.3860821-1-willmcvicker@google.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210921_002009_262083_7CD89885 X-CRM114-Status: GOOD ( 23.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/09/2021 21:03, Will McVicker wrote: > This patch series tries to address the issue of ARCH_EXYNOS force selecting > a handful of drivers without allowing the vendor to override any of the > default configs. This takes away from the flexibilty of compiling a generic > kernel with exynos kernel modules. For example, it doesn't allow vendors to > modularize these drivers out of the core kernel in order to share a generic > kernel image across multiple devices that require device-specific kernel > modules. You do not address the issue in these patches. The problem you describe is that drivers are not modules and you are not changing them into modules. > > To address this without impacting the existing behavior, this series > switches the default config logic for the offending configs to use "default > y if ARCH_EXYNOS" versus having ARCH_EXYNOS directly select them. I have > verified that these patches do not impact the default aarch64 .config. Yep, this is what you did but it does not match the described problem. You are not solving it but doing something else. > > Will McVicker (4): > clk: samsung: change COMMON_CLK_SAMSUNG default config logic > soc: samsung: change SOC_SAMSUNG default config logic > pinctrl: samsung: change PINCTRL_EXYNOS default config logic > rtc: change HAVE_S3C_RTC default config logic > I received only two patches from this set. Please resend following get_maintainers.pl script. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel