From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH iproute2] bridge: make -c match -compressvlans first instead of -color Date: Wed, 28 Nov 2018 11:11:53 -0700 Message-ID: <7738ff43-c8c2-c491-3192-be8ee6f16a70@cumulusnetworks.com> References: <1543370572-19373-1-git-send-email-roopa@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, nikolay@cumulusnetworks.com, julien@cumulusnetworks.com To: Roopa Prabhu , stephen@networkplumber.org Return-path: Received: from mail-pl1-f193.google.com ([209.85.214.193]:40077 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725994AbeK2FO0 (ORCPT ); Thu, 29 Nov 2018 00:14:26 -0500 Received: by mail-pl1-f193.google.com with SMTP id u18so5200782plq.7 for ; Wed, 28 Nov 2018 10:11:56 -0800 (PST) In-Reply-To: <1543370572-19373-1-git-send-email-roopa@cumulusnetworks.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/27/18 7:02 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > commit c7c1a1ef51ae ("bridge: colorize output and use JSON print library") > broke previous use of -c to represent compressvlans. This restores > previous use of -c to represent compressvlans. Understand the original > motivation to use -c to represent color consistently everywhere but > there are apps and network interface managers out there that are already > using -c to prepresent compressed vlans. > > Fixes: c7c1a1ef51ae ("bridge: colorize output and use JSON print library") > Signed-off-by: Roopa Prabhu > --- > bridge/bridge.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: David Ahern