All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@xilinx.com>
To: Huisong Li <lihuisong@huawei.com>, <andrew.rybchenko@oktetlabs.ru>
Cc: <dev@dpdk.org>, <thomas@monjalon.net>, <weiyuanx.li@intel.com>,
	<huangdaode@huawei.com>, <liudongdong3@huawei.com>
Subject: Re: [PATCH] app/testpmd: fix display types failure when query RSS rule
Date: Thu, 7 Jul 2022 13:22:28 +0100	[thread overview]
Message-ID: <773cea2b-68e3-ac28-b6cc-dd57377144b1@xilinx.com> (raw)
In-Reply-To: <20220707105044.10567-1-lihuisong@huawei.com>

On 7/7/2022 11:50 AM, Huisong Li wrote:
> Now testpmd fails to display types when query RSS rule. The failure is
> because the '\n' character is missing at the end of the function
> 'rss_config_display()'.
> 

Bugzilla ID: 1048

> Fixes: 534988c490f1 ("app/testpmd: unify RSS types display")
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> ---
>   app/test-pmd/config.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 608bec9796..bcb6d42da3 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1693,6 +1693,7 @@ rss_config_display(struct rte_flow_action_rss *rss_conf)
>   		return;
>   	}
>   	rss_types_display(rss_conf->types, TESTPMD_RSS_TYPES_CHAR_NUM_PER_LINE);
> +	printf("\n");


Thanks Huisong for the fix.

What do you think to have '\n' in the 'rss_types_display()' function and 
update 'port_rss_hash_conf_show()' usage?

And can do same change for 'rss_offload_types_display()', having last 
'\n' in the function.

>   }
>   
>   static struct port_indirect_action *


  reply	other threads:[~2022-07-07 12:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07 10:50 [PATCH] app/testpmd: fix display types failure when query RSS rule Huisong Li
2022-07-07 12:22 ` Ferruh Yigit [this message]
2022-07-07 12:42   ` lihuisong (C)
2022-07-07 13:12     ` Ferruh Yigit
2022-07-08  1:21       ` lihuisong (C)
2022-07-08  1:41 ` [PATCH V2] " Huisong Li
2022-07-08  5:32   ` Li, WeiyuanX
2022-07-08  8:15     ` Jiang, YuX
2022-07-08 10:31     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=773cea2b-68e3-ac28-b6cc-dd57377144b1@xilinx.com \
    --to=ferruh.yigit@xilinx.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=huangdaode@huawei.com \
    --cc=lihuisong@huawei.com \
    --cc=liudongdong3@huawei.com \
    --cc=thomas@monjalon.net \
    --cc=weiyuanx.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.