From: Andrew Donnellan <ajd@linux.ibm.com>
To: Benjamin Gray <bgray@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org
Cc: jniethe5@gmail.com, npiggin@gmail.com, cmr@bluescreens.de,
fbarrat@linux.ibm.com
Subject: Re: [PATCH v10 5/9] cxl: Use radix__flush_all_mm instead of generic flush_all_mm
Date: Fri, 25 Nov 2022 13:42:35 +1100 [thread overview]
Message-ID: <773fc15ae2f350c7586a8181c9fe2ca53814cc4b.camel@linux.ibm.com> (raw)
In-Reply-To: <20221109045112.187069-6-bgray@linux.ibm.com>
On Wed, 2022-11-09 at 15:51 +1100, Benjamin Gray wrote:
> The generic implementation of this function isn't really generic
> (Hash
> is not implemented). Unfortunately, the runtime warnings cannot be
> replaced with BUILD_BUG's, so it seems safer not to provide a stub in
> the first place.
>
> Signed-off-by: Benjamin Gray <bgray@linux.ibm.com>
[+ Fred]
This seems fine to me.
Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>
> ---
> v10: * New in v10 to remove hash__flush_all_mm,
> hash__local_flush_all_mm
> ---
> arch/powerpc/include/asm/mmu_context.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/mmu_context.h
> b/arch/powerpc/include/asm/mmu_context.h
> index c1ea270bb848..57f5017111f4 100644
> --- a/arch/powerpc/include/asm/mmu_context.h
> +++ b/arch/powerpc/include/asm/mmu_context.h
> @@ -151,8 +151,8 @@ static inline void mm_context_remove_copro(struct
> mm_struct *mm)
> * nMMU and/or PSL need to be cleaned up.
> *
> * Both the 'copros' and 'active_cpus' counts are looked at
> in
> - * flush_all_mm() to determine the scope (local/global) of
> the
> - * TLBIs, so we need to flush first before decrementing
> + * radix__flush_all_mm() to determine the scope
> (local/global)
> + * of the TLBIs, so we need to flush first before
> decrementing
> * 'copros'. If this API is used by several callers for the
> * same context, it can lead to over-flushing. It's hopefully
> * not common enough to be a problem.
> @@ -164,7 +164,7 @@ static inline void mm_context_remove_copro(struct
> mm_struct *mm)
> * in-between.
> */
> if (radix_enabled()) {
> - flush_all_mm(mm);
> + radix__flush_all_mm(mm);
>
> c = atomic_dec_if_positive(&mm->context.copros);
> /* Detect imbalance between add and remove */
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
next prev parent reply other threads:[~2022-11-25 2:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 4:51 [PATCH v10 0/9] powerpc/code-patching: Use temporary mm for Radix MMU Benjamin Gray
2022-11-09 4:51 ` [PATCH v10 1/9] powerpc: Allow clearing and restoring registers independent of saved breakpoint state Benjamin Gray
2022-11-09 4:51 ` [PATCH v10 2/9] powerpc/code-patching: Use WARN_ON and fix check in poking_init Benjamin Gray
2022-11-09 6:12 ` Christophe Leroy
2022-11-09 4:51 ` [PATCH v10 3/9] powerpc/mm: Remove extern from function prototypes Benjamin Gray
2022-11-09 6:16 ` Christophe Leroy
2022-11-25 3:12 ` Andrew Donnellan
2022-11-09 4:51 ` [PATCH v10 4/9] powerpc/mm: Remove empty hash__ functions Benjamin Gray
2022-11-09 6:16 ` Christophe Leroy
2022-11-09 4:51 ` [PATCH v10 5/9] cxl: Use radix__flush_all_mm instead of generic flush_all_mm Benjamin Gray
2022-11-09 6:16 ` Christophe Leroy
2022-11-25 2:42 ` Andrew Donnellan [this message]
2022-11-09 4:51 ` [PATCH v10 6/9] powerpc/mm: Remove flush_all_mm, local_flush_all_mm Benjamin Gray
2022-11-09 6:17 ` Christophe Leroy
2022-11-09 4:51 ` [PATCH v10 7/9] powerpc/tlb: Add local flush for page given mm_struct and psize Benjamin Gray
2022-11-09 6:18 ` Christophe Leroy
2022-11-09 4:51 ` [PATCH v10 8/9] powerpc/code-patching: Use temporary mm for Radix MMU Benjamin Gray
2022-12-15 20:17 ` Nathan Chancellor
2022-12-15 20:17 ` Nathan Chancellor
2022-12-16 0:23 ` Michael Ellerman
2022-11-09 4:51 ` [PATCH v10 9/9] powerpc/code-patching: Consolidate and cache per-cpu patching context Benjamin Gray
2022-11-09 6:23 ` Christophe Leroy
2022-12-08 12:39 ` [PATCH v10 0/9] powerpc/code-patching: Use temporary mm for Radix MMU Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=773fc15ae2f350c7586a8181c9fe2ca53814cc4b.camel@linux.ibm.com \
--to=ajd@linux.ibm.com \
--cc=bgray@linux.ibm.com \
--cc=cmr@bluescreens.de \
--cc=fbarrat@linux.ibm.com \
--cc=jniethe5@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.