All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>,
	Fugang Duan <fugang.duan@nxp.com>,
	kernel@pengutronix.de, linux-imx@nxp.com,
	linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dong Aisheng <aisheng.dong@nxp.com>,
	Fabio Estevam <festevam@gmail.com>, Kangjie Lu <kjlu@umn.edu>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>, Wolfram Sang <wsa@kernel.org>
Subject: Re: [PATCH v3] i2c: imx-lpi2c: Fix runtime PM imbalance in lpi2c_imx_master_enable()
Date: Mon, 1 Jun 2020 08:42:08 +0200	[thread overview]
Message-ID: <77448b13-9233-20a8-5e68-a8830314c27d@web.de> (raw)
In-Reply-To: <20200601061640.27632-1-dinghao.liu@zju.edu.cn>

> pm_runtime_get_sync() increments the runtime PM usage counter even
> the call returns an error code. Thus a corresponding decrement is
> needed on the error handling path to keep the counter balanced.
>
> Fix this by adding the missed function call.

How do you think about a wording variant like the following?

   Change description:
   The PM runtime usage counter is incremented even if a call of
   the function “pm_runtime_get_sync” failed. Thus decrement it also
   in an error case so that the reference counting is kept consistent.


Regards,
Markus

WARNING: multiple messages have this Message-ID
From: Markus Elfring <Markus.Elfring@web.de>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>,
	Fugang Duan <fugang.duan@nxp.com>,
	kernel@pengutronix.de, linux-imx@nxp.com,
	linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
	kernel-janitors@vger.kernel.org,
	Sascha Hauer <s.hauer@pengutronix.de>, Kangjie Lu <kjlu@umn.edu>,
	linux-kernel@vger.kernel.org, Wolfram Sang <wsa@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH v3] i2c: imx-lpi2c: Fix runtime PM imbalance in lpi2c_imx_master_enable()
Date: Mon, 01 Jun 2020 06:42:08 +0000	[thread overview]
Message-ID: <77448b13-9233-20a8-5e68-a8830314c27d@web.de> (raw)
In-Reply-To: <20200601061640.27632-1-dinghao.liu@zju.edu.cn>

> pm_runtime_get_sync() increments the runtime PM usage counter even
> the call returns an error code. Thus a corresponding decrement is
> needed on the error handling path to keep the counter balanced.
>
> Fix this by adding the missed function call.

How do you think about a wording variant like the following?

   Change description:
   The PM runtime usage counter is incremented even if a call of
   the function “pm_runtime_get_sync” failed. Thus decrement it also
   in an error case so that the reference counting is kept consistent.


Regards,
Markus

WARNING: multiple messages have this Message-ID
From: Markus Elfring <Markus.Elfring@web.de>
To: Dinghao Liu <dinghao.liu@zju.edu.cn>,
	Fugang Duan <fugang.duan@nxp.com>,
	kernel@pengutronix.de, linux-imx@nxp.com,
	linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
	kernel-janitors@vger.kernel.org,
	Sascha Hauer <s.hauer@pengutronix.de>, Kangjie Lu <kjlu@umn.edu>,
	linux-kernel@vger.kernel.org, Wolfram Sang <wsa@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH v3] i2c: imx-lpi2c: Fix runtime PM imbalance in lpi2c_imx_master_enable()
Date: Mon, 1 Jun 2020 08:42:08 +0200	[thread overview]
Message-ID: <77448b13-9233-20a8-5e68-a8830314c27d@web.de> (raw)
In-Reply-To: <20200601061640.27632-1-dinghao.liu@zju.edu.cn>

> pm_runtime_get_sync() increments the runtime PM usage counter even
> the call returns an error code. Thus a corresponding decrement is
> needed on the error handling path to keep the counter balanced.
>
> Fix this by adding the missed function call.

How do you think about a wording variant like the following?

   Change description:
   The PM runtime usage counter is incremented even if a call of
   the function “pm_runtime_get_sync” failed. Thus decrement it also
   in an error case so that the reference counting is kept consistent.


Regards,
Markus

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-06-01  6:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-01  6:16 [PATCH] [v3] i2c: imx-lpi2c: Fix runtime PM imbalance on error Dinghao Liu
2020-06-01  6:16 ` Dinghao Liu
2020-06-01  6:24 ` [EXT] " Andy Duan
2020-06-01  6:24   ` Andy Duan
2020-06-01  6:42 ` Markus Elfring [this message]
2020-06-01  6:42   ` [PATCH v3] i2c: imx-lpi2c: Fix runtime PM imbalance in lpi2c_imx_master_enable() Markus Elfring
2020-06-01  6:42   ` Markus Elfring
2020-06-14  9:12 ` [PATCH] [v3] i2c: imx-lpi2c: Fix runtime PM imbalance on error Wolfram Sang
2020-06-14  9:12   ` Wolfram Sang
2020-06-14 12:08   ` dinghao.liu
2020-06-14 12:08     ` dinghao.liu
2020-06-15  6:33   ` Aisheng Dong
2020-06-15  6:33     ` Aisheng Dong
2020-06-15  7:06     ` Wolfram Sang
2020-06-15  7:06       ` Wolfram Sang
2020-06-15  7:40       ` Markus Elfring
2020-06-15  7:40         ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77448b13-9233-20a8-5e68-a8830314c27d@web.de \
    --to=markus.elfring@web.de \
    --cc=aisheng.dong@nxp.com \
    --cc=dinghao.liu@zju.edu.cn \
    --cc=festevam@gmail.com \
    --cc=fugang.duan@nxp.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=kjlu@umn.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=wsa@kernel.org \
    --subject='Re: [PATCH v3] i2c: imx-lpi2c: Fix runtime PM imbalance in lpi2c_imx_master_enable()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.